rt/NomadNet
1
0
Fork 0
mirror of https://github.com/markqvist/NomadNet.git synced 2026-10-25 18:40:13 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Conversation: avoid calling conversation_list() on every received announce; this can cause fd starvation during an announce storm

Browse source
This commit is contained in:
Jeremy O'Brien 2026-05-28 11:50:01 -04:00
parent 1a7288517e
commit 7bc691169a
No known key found for this signature in database
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
nomadnet/Conversation.py
View file

@ -24,15 +24,13 @@ class Conversation:
if not destination_hash in app.ignored_list:
destination_hash_text = RNS.hexrep(destination_hash, delimit=False)
# Check if the announced destination is in
# our list of conversations
if destination_hash_text in [e[0] for e in Conversation.conversation_list(app)]:
if app.directory.find(destination_hash):
if Conversation.created_callback != None:
Conversation.created_callback()
else:
if Conversation.created_callback != None:
Conversation.created_callback()
# Notify if the announced destination is one of our
# existing conversations. Checking the directory directly
# avoids scanning and opening every conversation on disk
# for each announce received.
if os.path.isdir(app.conversationpath + "/" + destination_hash_text):
if Conversation.created_callback != None:
Conversation.created_callback()
# This reformats the new v0.5.0 announce data back to the expected format
# for nomadnets storage and other handling functions.