rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-25 18:40:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Extend the raid regression test with some more case

Browse source
This commit is contained in:
Andrea Mazzoleni 2015-03-30 18:57:33 +02:00
parent 36061561cc
commit 0ac0a8eceb
2 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
raid/check.c
View file

@ -165,7 +165,7 @@ int raid_scan(int *ir, int nd, int np, size_t size, void **v)
int r;
/* check the special case of no failure */
if (raid_check(0, 0, nd, np, size, v) == 0)
if (np != 0 && raid_check(0, 0, nd, np, size, v) == 0)
return 0;
/* for each number of possible failures */

22
raid/module.c
View file

@ -274,9 +274,6 @@ static int raid_test_scan(int nr, int *ir, int nd, int np, size_t size, void **v
/* this block is bad */
t[i] = v[i];
++j;
/* make it really bad */
memset(t[i], i, size);
} else {
/* this block is used for recovering */
t[i] = ref[i];
@ -286,11 +283,8 @@ static int raid_test_scan(int nr, int *ir, int nd, int np, size_t size, void **v
ret = raid_scan(is, nd, np, size, t);
/* compare identified bad blocks */
if (ret != nr) {
/* LCOV_EXCL_START */
if (ret != nr)
return -1;
/* LCOV_EXCL_STOP */
}
for (i = 0; i < nr; ++i) {
if (ir[i] != is[i]) {
/* LCOV_EXCL_START */
@ -438,6 +432,12 @@ int raid_selftest(void)
/* bad parity */
ir[np / 2 + i] = nd + i;
}
for (i = 0; i < np - 1; ++i) {
/* make blocks bad */
/* we cannot fill them with 0, because the original */
/* data may be already filled with 0 */
memset(v[ir[i]], 0x55, size);
}
ret = raid_test_scan(np - 1, ir, nd, np, size, v, ref);
if (ret != 0) {
@ -447,6 +447,14 @@ int raid_selftest(void)
}
}
/* scan test with no parity */
ret = raid_test_scan(0, 0, nd, 0, size, v, ref);
if (ret != -1) {
/* LCOV_EXCL_START */
goto bail;
/* LCOV_EXCL_STOP */
}
bail:
free(v);
free(v_alloc);