rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 10:51:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix an invalid assumption when using the -e option

Browse source 
With -e we cannot postprocess files as we don't have any guarantee
to fully process them, as the select blocks cover likely only
a subset of the file.
This commit is contained in:
Andrea Mazzoleni 2015-08-31 22:01:34 +02:00
parent bf4ac37cdf
commit 0ba25d5304
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cmdline/check.c
View file

@ -588,12 +588,21 @@ static int repair(struct snapraid_state* state, int rehash, unsigned pos, unsign
* Post process all the files at the specified block index ::i.
* For each file, if we are at the last block, closes it,
* adjust the timestamp, and prints the result.
*
* This works with the assumption to always process the whole files to
* fix. This assumption is not always correct, and in such case we have to
* skip the whole postprocessing. And example, is when fixing only bad blocks.
*/
static int file_post(struct snapraid_state* state, int fix, unsigned i, struct snapraid_handle* handle, unsigned diskmax)
{
unsigned j;
int ret;
/* if we are processing only bad blocks, we don't have to do any postprocessing */
/* as we don't have any guarantee to process the last block of the fixed files */
if (state->opt.badonly)
return 0;
/* for all the files prints the final status, and does the final time fix */
/* we also ensure to close files after processing the last block */
for (j = 0; j < diskmax; ++j) {