rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 02:49:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Mark scrub/sync blocks bad when data file open fails with an I/O error

Browse source
This commit is contained in:
Andrea Mazzoleni 2026-09-23 16:11:20 +02:00
parent e481b5f207
commit 1a5b28ad38
3 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cmdline/scrub.c
View file

@ -333,6 +333,10 @@ static void scrub_data_reader(struct snapraid_worker* worker, struct snapraid_ta
block_off_t blockcur = task->position;
unsigned char* buffer = task->buffer;
int ret;
/* tasks are reused, so a previous close failure must not affect this position */
task->unrelated_error = 0;
/* if the disk position is not used */
if (!disk) {
/* use an empty block */
@ -370,6 +374,7 @@ static void scrub_data_reader(struct snapraid_worker* worker, struct snapraid_ta
log_fatal_errno(errno, disk->name);
log_fatal(errno, "Stopping at block %" PRIu64 "\n", blockcur);
task->unrelated_error = 1;
if (is_hw(errno)) {
task->state = TASK_STATE_IOERROR;
} else {
@ -676,6 +681,11 @@ static int state_scrub_process(struct snapraid_state* state, struct snapraid_par
if (task->state == TASK_STATE_IOERROR) {
/* LCOV_EXCL_START */
++io_error;
/* closing the previous file says nothing about this parity position */
if (!task->unrelated_error) {
info_set(&state->infoarr, blockcur, info_set_bad(info));
state->need_write = 1;
}
goto bail;
/* LCOV_EXCL_STOP */
}