rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 10:51:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix undefined behavior in extent file comparison by casting pointers to uintptr_t

Browse source
This commit is contained in:
Andrea Mazzoleni 2026-08-17 10:07:41 +02:00
parent bd856b456b
commit 3185e1bf34
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
cmdline/elem.c
View file

@ -701,10 +701,13 @@ int extent_file_compare(const void* void_a, const void* void_b)
{
const struct snapraid_extent* arg_a = void_a;
const struct snapraid_extent* arg_b = void_b;
uintptr_t file_a = (uintptr_t)arg_a->file;
uintptr_t file_b = (uintptr_t)arg_b->file;
if (arg_a->file < arg_b->file)
/* cast to uintptr_t to avoid undefined behavior when comparing pointers to distinct heap allocations */
if (file_a < file_b)
return -1;
if (arg_a->file > arg_b->file)
if (file_a > file_b)
return 1;
if (arg_a->file_pos < arg_b->file_pos)
@ -1293,10 +1296,13 @@ static int extent_file_inside_compare_unlock(const void* void_a, const void* voi
{
const struct extent_file_inside* arg_a = void_a;
const struct snapraid_extent* arg_b = void_b;
uintptr_t file_a = (uintptr_t)arg_a->file;
uintptr_t file_b = (uintptr_t)arg_b->file;
if (arg_a->file < arg_b->file)
/* cast to uintptr_t to avoid undefined behavior when comparing pointers to distinct heap allocations */
if (file_a < file_b)
return -1;
if (arg_a->file > arg_b->file)
if (file_a > file_b)
return 1;
if (arg_a->file_pos < arg_b->file_pos)