From 4defb748e8232cfe8a6b846044a371d83166ab39 Mon Sep 17 00:00:00 2001 From: Andrea Mazzoleni Date: Wed, 12 Aug 2026 09:54:35 +0200 Subject: [PATCH] Document why invalid GUID validation in fssnapshot_create returns immediately without WMI cleanup --- cmdline/mingwapp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmdline/mingwapp.c b/cmdline/mingwapp.c index 06e2cca8..01e9e543 100644 --- a/cmdline/mingwapp.c +++ b/cmdline/mingwapp.c @@ -541,6 +541,7 @@ int fssnapshot_create(const struct fssnapshot_struct* fss, const char* name) const char* guid = out + 3; + /* do not jump to bail_and_delete if GUID is invalid because an unvalidated GUID cannot be safely used in a WMI query */ if (windows_guid_is_valid(guid, strlen(guid)) != 0) { errno = EINVAL; log_error(errno, "Invalid GUID received from VSS shadow copy creation: '%s'\n", guid);