rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 10:51:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

As option argument never accept an empty string for the 0 value

Browse source
This commit is contained in:
Andrea Mazzoleni 2026-03-19 15:07:43 +01:00
parent 8ee24aa26c
commit 80bb5af22e
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
cmdline/snapraid.c
View file

@ -907,7 +907,7 @@ int parse_option_size(const char* arg, uint64_t* out_size)
/* parse the number part */
data_off_t size = strtoul(arg, &e, 10);
if (!e || e == arg)
if (e == arg)
return -1;
/* Handle suffixes */
@ -919,7 +919,7 @@ int parse_option_size(const char* arg, uint64_t* out_size)
size *= GIGA;
} else if ((e[0] == 't' || e[0] == 'T') && e[1] == 0) {
size *= TERA;
} else if (e[0] != '\0') {
} else if (e[0] != 0) {
return -1;
}
@ -1100,7 +1100,8 @@ int snapraid_main(int argc, char* argv[])
plan100 = SCRUB_FULL;
} else {
double plan_double = strtod(optarg, &e);
if (!e || *e != 0
if (e == optarg
|| *e != 0
|| !isfinite(plan_double)
|| plan_double < 0
|| plan_double > 100
@ -1115,7 +1116,7 @@ int snapraid_main(int argc, char* argv[])
break;
case 'o' :
olderthan = strtoul(optarg, &e, 10);
if (!e || *e || olderthan > 1000) {
if (e == optarg || *e || olderthan > 1000) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid number of days '%s'\n", optarg);
exit(EXIT_FAILURE);
@ -1139,7 +1140,7 @@ int snapraid_main(int argc, char* argv[])
break;
case 'S' :
blockstart = strtoul(optarg, &e, 0);
if (!e || *e) {
if (e == optarg || *e) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid start position '%s'\n", optarg);
exit(EXIT_FAILURE);
@ -1148,7 +1149,7 @@ int snapraid_main(int argc, char* argv[])
break;
case 'B' :
blockcount = strtoul(optarg, &e, 0);
if (!e || *e) {
if (e == optarg || *e) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid count number '%s'\n", optarg);
exit(EXIT_FAILURE);
@ -1157,7 +1158,7 @@ int snapraid_main(int argc, char* argv[])
break;
case 'L' :
opt.io_error_limit = strtoul(optarg, &e, 0);
if (!e || *e) {
if (e == optarg || *e) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid error limit number '%s'\n", optarg);
exit(EXIT_FAILURE);
@ -1262,7 +1263,7 @@ int snapraid_main(int argc, char* argv[])
break;
case OPT_GUI_THRESHOLD_REMOVES :
opt.gui_threshold_removes = strtoul(optarg, &e, 0);
if (!e || *e) {
if (e == optarg || *e) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid threshold '%s'\n", optarg);
exit(EXIT_FAILURE);
@ -1271,7 +1272,7 @@ int snapraid_main(int argc, char* argv[])
break;
case OPT_GUI_THRESHOLD_UPDATES :
opt.gui_threshold_updates = strtoul(optarg, &e, 0);
if (!e || *e) {
if (e == optarg || *e) {
/* LCOV_EXCL_START */
log_fatal(EUSER, "Invalid threshold '%s'\n", optarg);
exit(EXIT_FAILURE);