rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 02:49:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix parse_option_size() to reject negative values, ERANGE errors, and suffix multiplication overflow.

Browse source
This commit is contained in:
Andrea Mazzoleni 2026-08-18 22:21:59 +02:00
parent 24a8464fc0
commit a89b6f3126
1 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

28
cmdline/snapraid.c
View file

@ -861,28 +861,42 @@ static struct option long_options[] = {
*/
#define OPTIONS "t:c:f:d:mebp:o:S:B:L:i:l:AZEUDNFRW:ahTC:vqHVw:"
int parse_option_size(const char* arg, uint64_t* out_size)
static int parse_option_size(const char* arg, uint64_t* out_size)
{
char* e;
uint64_t mult = 1;
while (isspace((unsigned char)*arg))
++arg;
if (*arg == '-')
return -1;
/* parse the number part */
errno = 0;
uint64_t size = strtoull(arg, &e, 10);
if (e == arg)
if (e == arg || errno == ERANGE)
return -1;
/* Handle suffixes */
/* handle suffixes */
if ((e[0] == 'k' || e[0] == 'K') && e[1] == 0) {
size *= KILO;
mult = KILO;
} else if ((e[0] == 'm' || e[0] == 'M') && e[1] == 0) {
size *= MEGA;
mult = MEGA;
} else if ((e[0] == 'g' || e[0] == 'G') && e[1] == 0) {
size *= GIGA;
mult = GIGA;
} else if ((e[0] == 't' || e[0] == 'T') && e[1] == 0) {
size *= TERA;
mult = TERA;
} else if (e[0] != 0) {
return -1;
}
if (mult != 1) {
if (size > UINT64_MAX / mult)
return -1;
size *= mult;
}
*out_size = size;
return 0;
}