rt/snapraid
1
0
Fork 0
mirror of https://github.com/amadvance/snapraid.git synced 2026-10-26 10:51:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reworks the keep function to make it easier to understand.

Browse source
This commit is contained in:
Andrea Mazzoleni 2014-06-15 17:59:00 +02:00
parent 69acc1e251
commit c5d6dd0cc7
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
cmdline/scan.c
View file

@ -293,28 +293,29 @@ static int file_is_full_hashed_and_stable(struct snapraid_state* state, struct s
/**
* Keeps the file as it's (or with only a name/inode modification).
*
* If a file contains only blocks with invalid parity, it's reallocated to ensure
* If the file is kept, nothing has to be done.
*
* But if a file contains only blocks with invalid parity, it's reallocated to ensure
* to always minimize the space used in the parity.
*
* This could happen after a failed sync, when some other files are deleted,
* and then new ones can be moved to fill the hole created.
* and then new ones can be moved backward to fill the hole created.
*/
static void scan_file_keep(struct snapraid_scan* scan, struct snapraid_file* file)
{
struct snapraid_disk* disk = scan->disk;
/* if the file has some valid block or rehash, keep it where it is */
if (!file_is_full_invalid_parity_and_stable(scan->state, file))
return;
/* if the file is full invalid, schedule a reinsert at later stage */
if (file_is_full_invalid_parity_and_stable(scan->state, file)) {
/* deallocate the file from the parity */
scan_file_deallocate(scan, file);
/* deallocate the file from the parity */
scan_file_deallocate(scan, file);
/* remove the file from the list */
tommy_list_remove_existing(&disk->filelist, &file->nodelist);
/* remove the file from the list */
tommy_list_remove_existing(&disk->filelist, &file->nodelist);
/* insert the file in the delayed block allocation */
tommy_list_insert_tail(&scan->file_insert_list, &file->nodelist, file);
/* insert the file in the delayed block allocation */
tommy_list_insert_tail(&scan->file_insert_list, &file->nodelist, file);
}
}
/**