From e760df8877091257e316a2dd1179f9eb802b124c Mon Sep 17 00:00:00 2001 From: Andrea Mazzoleni Date: Sun, 10 Apr 2016 23:01:42 +0200 Subject: [PATCH] Reset all fields of the Windows overlapped struct To be 100% compliant with MSDN. --- cmdline/mingw.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cmdline/mingw.c b/cmdline/mingw.c index e7c5b804..4d0b0d8e 100644 --- a/cmdline/mingw.c +++ b/cmdline/mingw.c @@ -1700,11 +1700,9 @@ ssize_t windows_pread(int fd, void* buffer, size_t size, off_t offset) } retry: - overlapped.Internal = 0; - overlapped.InternalHigh = 0; + memset(&overlapped, 0, sizeof(overlapped)); overlapped.Offset = offset & 0xFFFFFFFF; overlapped.OffsetHigh = offset >> 32; - overlapped.hEvent = 0; if (!ReadFile(h, buffer, size, &count, &overlapped)) { DWORD err = GetLastError(); @@ -1758,11 +1756,9 @@ ssize_t windows_pwrite(int fd, const void* buffer, size_t size, off_t offset) } retry: - overlapped.Internal = 0; - overlapped.InternalHigh = 0; + memset(&overlapped, 0, sizeof(overlapped)); overlapped.Offset = offset & 0xFFFFFFFF; overlapped.OffsetHigh = offset >> 32; - overlapped.hEvent = 0; if (!WriteFile(h, buffer, size, &count, &overlapped)) { DWORD err = GetLastError();