Commit graph

389 commits

Author SHA1 Message Date
Andrea Mazzoleni
f3046b4053 Fix some misuses of MiB and MB 2016-01-16 07:56:52 +01:00
Andrea Mazzoleni
eaa89473b4 Keep different the functions that may not find the parity 2016-01-15 20:05:38 +01:00
Andrea Mazzoleni
56bef0d90f Fix an invalid assumption about allocated parity
In the copy detection it's possible to need to
copy from a file wihout parity. This could result
in the parity position not found.
2016-01-15 19:50:21 +01:00
Andrea Mazzoleni
2f5c6a39a9 Fix unaligned memory access in import
After extent conversion, the hash is not not aligned anymore,
and we cannot cast anymore to uint32.
2016-01-09 10:06:37 +01:00
Andrea Mazzoleni
9d4fd25774 Avoid a float division by zero in testing
In the regression testing the fake probability goes
to 0, resulting in an impossible division.
2016-01-09 10:05:57 +01:00
Andrea Mazzoleni
a45641dcc9 Add explicit conversion to unsigned from byte
Implicit conversion is to signed int, that may overlow,
resulting in what C considers undefined behaviour.
Better to avoid it.
2016-01-09 10:01:33 +01:00
Andrea Mazzoleni
9b918c3ca0 Some more coverage commenting 2016-01-06 00:26:24 +01:00
Andrea Mazzoleni
84f7a623ab Be more verbose in log and messages about UUID 2016-01-05 23:35:55 +01:00
Andrea Mazzoleni
cc8ca88ecf Add some more coverage exclusions 2016-01-05 12:23:05 +01:00
Andrea Mazzoleni
c879140663 Print the exit status of addr2line 2016-01-05 11:16:03 +01:00
Andrea Mazzoleni
fe20160958 Fix the precision field in the addr2line call
It must be a int type in x64.
2016-01-05 11:04:04 +01:00
Andrea Mazzoleni
62aba9228a Add a new test option to force parity update 2016-01-04 10:43:43 +01:00
Andrea Mazzoleni
5249f9cb04 Fix various typos in comments 2016-01-02 16:52:20 +01:00
Andrea Mazzoleni
b853b4c406 More explicative StackTrace message 2016-01-02 12:23:48 +01:00
Andrea Mazzoleni
7ad70c26f8 Remove the need of helgrind/drd suppression
Using a mutex for protectign the global memory counter
should not affect performance.
2016-01-01 17:57:04 +01:00
Andrea Mazzoleni
b059457190 Disable multi thread for content write
It's not necessarely faster, so better to be safe
and avoid possible slowdown.
Also, the original reason of this feature was to detect
potential memory errors, but the original issue triggering this need
was instead not related to it. It was instead the problem to empty links.
2016-01-01 17:56:42 +01:00
Andrea Mazzoleni
354d51725b Enable again multi write for content files for monothread environments
If no thread support is present, keep the old way to write content files.
2016-01-01 17:37:00 +01:00
Andrea Mazzoleni
f4289a9d7e More explicative rename message
Some commands don't have UUID, and cannot detect
the rename.
2015-12-30 22:21:48 +01:00
Andrea Mazzoleni
a8e0214a9a Clarify the message about text content file not supported 2015-12-29 08:05:32 +01:00
Andrea Mazzoleni
776c6a48ef Add the new --no-warnings option for release 2015-12-28 14:49:10 +01:00
Andrea Mazzoleni
cacc1cb0ce Autorename disks using UUID for matching 2015-12-28 13:55:22 +01:00
Andrea Mazzoleni
801d01c55b Store UUIDs in the disk element 2015-12-28 12:09:13 +01:00
Andrea Mazzoleni
c80fd07058 Remove warnings when building with low optimizations 2015-12-20 17:23:58 +01:00
Andrea Mazzoleni
584c362ba4 Handle correctly files without offset
This avoid the warnings about duplicate offsets.
2015-12-20 17:19:57 +01:00
Andrea Mazzoleni
4d52890c32 Avoid the Windows abort dialog 2015-12-19 08:20:51 +01:00
Andrea Mazzoleni
d5c0a8c2f3 Support the case of an empty symlink
There is the report of a such condition in Windows.
2015-12-18 19:52:30 +01:00
Andrea Mazzoleni
61402049bc Fix the counting of different bits, as it was always return 0 2015-12-13 18:42:36 +01:00
Andrea Mazzoleni
96501697bb More os_abort() use after decoding_error() 2015-12-12 18:17:30 +01:00
Andrea Mazzoleni
c7ed079f79 More info in case of the "Path too long" message 2015-12-12 17:56:44 +01:00
Andrea Mazzoleni
448774fb8f Print also the too long path to help detection 2015-12-12 17:10:31 +01:00
Andrea Mazzoleni
7313e3d9d0 In case of the "Path too long" message prints the stacktrace 2015-12-12 17:10:28 +01:00
Andrea Mazzoleni
f8214de959 Adjust UUID printing in the log 2015-12-11 18:59:24 +01:00
Andrea Mazzoleni
5541f8d5e6 Add UUID reading support using libblkid
This fixes the Btrfs case where the root UUIDs are not
present in the /dev/disk/by-uuid directory.
2015-12-10 22:51:19 +01:00
Andrea Mazzoleni
fcc3894667 Add regression test for UUID change 2015-12-10 22:51:16 +01:00
Andrea Mazzoleni
cab1b43d3b Add a missing newline in the force-empty message 2015-12-04 22:13:26 +01:00
Andrea Mazzoleni
f71ddbb3fd Add backtrace support for internal errors 2015-12-04 22:02:31 +01:00
Andrea Mazzoleni
a66ccb5cc1 Some more regression tests for move/copy/invalidate 2015-12-01 23:44:06 +01:00
Andrea Mazzoleni
a79052baa6 Add a new --test-no-warnings option
It disables annoying warnings that expert user don't
want to see.
2015-11-24 18:49:20 +01:00
Andrea Mazzoleni
f389afe678 Avoid to log limits if not relevant for the scrub plan 2015-11-20 19:29:04 +01:00
Andrea Mazzoleni
193519d8fc Fix a data race in Windows for the customized strerror()
To proper support multithread we have to use the thread local
storage for keeping the latest error.
2015-11-20 18:58:59 +01:00
Andrea Mazzoleni
d927a58e4e Remove dead code about adjusting the first free parity position
We already known that the update of the first parity position
is never triggered, and then we can avoid to query the parity
position at all.
2015-11-20 18:29:53 +01:00
Andrea Mazzoleni
df22c18515 Remove abort() call left in for testing 2015-11-20 00:01:18 +01:00
Andrea Mazzoleni
13ebe5824f Fix a possible data race in Windows for UTF-8 conversion
We had less conversion buffers than possible threads,
possibly resulting in a buffer used more than one time.
Now converted to use local stack buffers to avoid
the need of any kind of syncronization between threads.
2015-11-19 19:38:39 +01:00
Andrea Mazzoleni
b775135175 Fix a build issue when the pthread library is not available 2015-11-19 19:14:15 +01:00
Andrea Mazzoleni
910c7b717c Fix a typo in a comment 2015-11-18 23:19:57 +01:00
Andrea Mazzoleni
cf335f8258 Avoid an unused variable warning in the Windows builds 2015-11-18 23:17:10 +01:00
Andrea Mazzoleni
496611f476 Fix an integer overflow when computing the size of a deleted entry
This bug prevented SnapRAID to read a valid content file, in case
a deleted entry bigger than 4 GB was present.
This could be reproduced deleting a file bigger than 4 GB and then sync.
2015-11-18 23:14:04 +01:00
Andrea Mazzoleni
9bd0f18439 Replace assertions with more informative messages 2015-11-18 22:10:50 +01:00
Andrea Mazzoleni
6b55d2a292 Add extra assertions and consistency checks 2015-11-16 22:54:00 +01:00
Andrea Mazzoleni
903ced679f Disable the file zero check in Windows 2015-11-14 17:03:52 +01:00