wrolpi/scripts/singlefile_browser_wrapper.sh

9 lines
452 B
Bash
Raw Permalink Normal View History

Single file deno (#478) * Singlefile runs under Deno 2.8.3; browser leftovers are reaped. single-file-cli is designed for Deno. Under node 18 (Debian 12/RPi OS) it cannot reach the browser CDP on IPv6-enabled hosts ("localhost" resolves to ::1 first with no IPv4 fallback) and it never exits after a successful save, blocking the download worker forever. The native path and the Archive docker container now run single-file with "deno run". Deno is pinned at v2.8.3 everywhere because yt-dlp 2026.06.09 requires at least 2.3.0 (our node is Debian's v18, below yt-dlp's v22 minimum). Deno >= 2.3 kills the browser single-file spawns (piped stderr that single-file never reads), so the browser is run through singlefile_browser_wrapper.sh which discards its stderr. Commands are run in their own process group which is killed when they finish, reaping the browser single-file leaves behind. The Archive downloader now has a ten minute timeout. Install scripts install Deno (previously only upgrade.sh and the image builds did). * Singlefile writes to a file instead of dumping to stdout. Deno >= 2.3 truncates large --dump-content output at exit; compressed (SingleFileZ) singlefiles of large pages lost their ZIP tail, failed the compression check in write_archive_files, and were destroyed by the HTML prettifier (blank white archives). single-file now writes its result to a temporary file which WROLPi reads back. As insurance, a singlefile marked compressed (<html data-sfz) whose ZIP is unreadable is now stored verbatim instead of being prettified. * Compressed Archive screenshots and readability images are no longer broken. The index.html inside a compressed (SingleFileZ) singlefile references its resources by relative ZIP paths. Screenshots are now taken from the fully extracted ZIP so those references resolve. Readability images are inlined as data URIs read from the ZIP (readability-extractor absolutizes relative srcs against the page URL, so both forms are matched). * Compressed Archives are created by converting the uncompressed capture. The page is always captured uncompressed; readability, screenshot, and title come from that canonical page (its images are inline data URIs, so no ZIP extraction or image inlining is needed). When compress_singlefile is set, a second single-file run converts the captured file into a compressed (SingleFileZ) self-extracting file. The conversion is a local file:// operation - the page is not fetched again, and single-file preserves the original URL header when re-saving its own pages. If the conversion fails, the uncompressed singlefile is stored instead. * Consolidating duplicate compressed-singlefile tests. The write_archive_files tests (verbatim write, title fallback, broken-ZIP guard, readability inlining) are combined into one test; the helper probes and the setting-plumbing tests are each merged into one. The do_singlefile compression-failure scenario and the timeout constant are folded into the main do_singlefile test, which shared their setup. * Addressing review comments: removeprefix, PermissionError when killing. * Bumping version to 0.24.1-beta. * Install scripts assert the deno.zip hash to avoid malicious or invalid files. The hashes are the official sha256sum assets of the Deno v2.8.3 release, per architecture. * Archive Dockerfile asserts the deno.zip hash to avoid malicious or invalid files. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-06-12 17:07:10 -06:00
#!/bin/sh
# Runs the browser for single-file with stderr discarded.
#
# single-file spawns the browser with piped stderr that it never reads; under Deno >= 2.3 this
# kills the browser during startup (the CDP port never opens and single-file fails with
# "tcp connect error: Connection refused"). WROLPi passes this wrapper as the
# --browser-executable-path and provides the real browser via WROLPI_BROWSER.
exec "${WROLPI_BROWSER}" "$@" 2>/dev/null