test: the theme drives the colour scheme, and mockModule takes the module
Both of Greptile's findings on #591 were real, and the first was a plain miss:
mockModule shipped with no caller, so its documented usage had never once been
executed and could not have worked. It called jest.requireActual on a path
passed in by the spec, which resolves relative to test-utils.js rather than to
the caller -- for any spec in a subdirectory the documented
'../hooks/customHooks' pointed outside src altogether. It now takes the module
the spec has already resolved, and throws on a string rather than quietly
resolving to the wrong one, which was the original failure.
It also has a caller now. FileBrowser.test.js listed six hooks in a hand-written
factory and returned only those, so every other export of customHooks was
undefined for anything it rendered -- the exact landmine the helper exists to
remove.
The second: `inverted` drove Mantine's colour scheme on its own, so asking for
night or amber through the new theme option produced a tree that reported a dark
theme while Mantine rendered its light one. Production cannot reach that
combination, and a harness that invents states the app never has is worse than
one that is merely incomplete -- what a test proves about such a tree is true of
nothing. The scheme is now derived from the theme name via isDarkTheme, and
data-theme is stamped on <html>, without which a component test cannot exercise
any token table or the night-mode treatment at all. isDark remains overridable
so a spec can still make the two disagree deliberately.
test-utils.test.js covers the harness itself, which had none. Eight of its
twelve assertions were red against the code above.
986 jest, 46 e2e, clean cache-busted build, tsc clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:39:30 -06:00
|
|
|
import React from 'react';
|
|
|
|
|
import {mockModule, render, renderUI, screen} from './test-utils';
|
|
|
|
|
import {ThemeContext} from './contexts/contexts';
|
|
|
|
|
import {amberTheme, darkTheme, lightTheme, nightTheme} from './themes/names';
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The harness itself needs tests.
|
|
|
|
|
*
|
|
|
|
|
* Both of these cover mistakes it shipped with. `mockModule` had no caller at all, so its
|
|
|
|
|
* documented usage was never once executed and could not have worked; and the theme option
|
style: spell it "color" everywhere
283 occurrences across 23 files, all of them mine and all of them in the
theme/UI work: comments, test names, and a handful of local identifiers
(`colours`, `roleColours`, `awaitColoured`) plus one test fixture tag named
'Uncoloured'.
Nothing was required to keep the other spelling. Checked before replacing: no
CSS custom property or class name contains it, no library prop or API key does,
and every string holding it is a test name or our own copy. The renamed
identifiers were checked for collisions with an existing `color`/`colors` in the
same file first -- there were none.
Verified as a pure rename: 262 lines changed, and normalising the spelling on
every removed line reproduces the added line exactly, for all 262. So the diff
contains no other edit hiding in it.
1134 jest / 64 suites, 271 cypress component tests with the same 12 pre-existing
Semantic-era failures in Tags/Channels/Download/Inventory, clean npm run build.
2026-08-02 18:02:44 -06:00
|
|
|
* moved ThemeContext without moving Mantine's color scheme, so asking for night produced a
|
test: the theme drives the colour scheme, and mockModule takes the module
Both of Greptile's findings on #591 were real, and the first was a plain miss:
mockModule shipped with no caller, so its documented usage had never once been
executed and could not have worked. It called jest.requireActual on a path
passed in by the spec, which resolves relative to test-utils.js rather than to
the caller -- for any spec in a subdirectory the documented
'../hooks/customHooks' pointed outside src altogether. It now takes the module
the spec has already resolved, and throws on a string rather than quietly
resolving to the wrong one, which was the original failure.
It also has a caller now. FileBrowser.test.js listed six hooks in a hand-written
factory and returned only those, so every other export of customHooks was
undefined for anything it rendered -- the exact landmine the helper exists to
remove.
The second: `inverted` drove Mantine's colour scheme on its own, so asking for
night or amber through the new theme option produced a tree that reported a dark
theme while Mantine rendered its light one. Production cannot reach that
combination, and a harness that invents states the app never has is worse than
one that is merely incomplete -- what a test proves about such a tree is true of
nothing. The scheme is now derived from the theme name via isDarkTheme, and
data-theme is stamped on <html>, without which a component test cannot exercise
any token table or the night-mode treatment at all. isDark remains overridable
so a spec can still make the two disagree deliberately.
test-utils.test.js covers the harness itself, which had none. Eight of its
twelve assertions were red against the code above.
986 jest, 46 e2e, clean cache-busted build, tsc clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:39:30 -06:00
|
|
|
* tree that reported night and rendered light -- a state production never reaches, which is
|
|
|
|
|
* the one thing a test harness must not invent.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
const ThemeProbe = () => {
|
|
|
|
|
const {theme, isDark} = React.useContext(ThemeContext);
|
|
|
|
|
return <div data-testid='probe'>{`${theme}:${isDark}`}</div>;
|
|
|
|
|
};
|
|
|
|
|
|
style: spell it "color" everywhere
283 occurrences across 23 files, all of them mine and all of them in the
theme/UI work: comments, test names, and a handful of local identifiers
(`colours`, `roleColours`, `awaitColoured`) plus one test fixture tag named
'Uncoloured'.
Nothing was required to keep the other spelling. Checked before replacing: no
CSS custom property or class name contains it, no library prop or API key does,
and every string holding it is a test name or our own copy. The renamed
identifiers were checked for collisions with an existing `color`/`colors` in the
same file first -- there were none.
Verified as a pure rename: 262 lines changed, and normalising the spelling on
every removed line reproduces the added line exactly, for all 262. So the diff
contains no other edit hiding in it.
1134 jest / 64 suites, 271 cypress component tests with the same 12 pre-existing
Semantic-era failures in Tags/Channels/Download/Inventory, clean npm run build.
2026-08-02 18:02:44 -06:00
|
|
|
describe('render keeps the theme and the color scheme together', () => {
|
test: the theme drives the colour scheme, and mockModule takes the module
Both of Greptile's findings on #591 were real, and the first was a plain miss:
mockModule shipped with no caller, so its documented usage had never once been
executed and could not have worked. It called jest.requireActual on a path
passed in by the spec, which resolves relative to test-utils.js rather than to
the caller -- for any spec in a subdirectory the documented
'../hooks/customHooks' pointed outside src altogether. It now takes the module
the spec has already resolved, and throws on a string rather than quietly
resolving to the wrong one, which was the original failure.
It also has a caller now. FileBrowser.test.js listed six hooks in a hand-written
factory and returned only those, so every other export of customHooks was
undefined for anything it rendered -- the exact landmine the helper exists to
remove.
The second: `inverted` drove Mantine's colour scheme on its own, so asking for
night or amber through the new theme option produced a tree that reported a dark
theme while Mantine rendered its light one. Production cannot reach that
combination, and a harness that invents states the app never has is worse than
one that is merely incomplete -- what a test proves about such a tree is true of
nothing. The scheme is now derived from the theme name via isDarkTheme, and
data-theme is stamped on <html>, without which a component test cannot exercise
any token table or the night-mode treatment at all. isDark remains overridable
so a spec can still make the two disagree deliberately.
test-utils.test.js covers the harness itself, which had none. Eight of its
twelve assertions were red against the code above.
986 jest, 46 e2e, clean cache-busted build, tsc clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:39:30 -06:00
|
|
|
// The dark-background themes, which is what Mantine has to be told about. night and amber
|
|
|
|
|
// are the interesting ones: neither is ever chosen by prefers-color-scheme, so nothing else
|
|
|
|
|
// would put Mantine's own components on a dark scheme for them.
|
|
|
|
|
[darkTheme, nightTheme, amberTheme].forEach((theme) => {
|
|
|
|
|
it(`renders ${theme} as a dark scheme, and reports it as dark`, () => {
|
|
|
|
|
render(<ThemeProbe/>, {theme: {theme}});
|
|
|
|
|
|
|
|
|
|
expect(screen.getByTestId('probe')).toHaveTextContent(`${theme}:true`);
|
|
|
|
|
expect(document.documentElement)
|
|
|
|
|
.toHaveAttribute('data-mantine-color-scheme', 'dark');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it(`stamps data-theme for ${theme}, so CSS keyed on it applies`, () => {
|
|
|
|
|
// Every token table and the whole night-mode treatment key on this attribute; a
|
|
|
|
|
// component test that never sets it cannot exercise any of them.
|
|
|
|
|
render(<ThemeProbe/>, {theme: {theme}});
|
|
|
|
|
|
|
|
|
|
expect(document.documentElement).toHaveAttribute('data-theme', theme);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('renders light as a light scheme', () => {
|
|
|
|
|
render(<ThemeProbe/>, {theme: {theme: lightTheme}});
|
|
|
|
|
|
|
|
|
|
expect(screen.getByTestId('probe')).toHaveTextContent(`${lightTheme}:false`);
|
|
|
|
|
expect(document.documentElement).toHaveAttribute('data-mantine-color-scheme', 'light');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('still honours the older inverted flag', () => {
|
|
|
|
|
render(<ThemeProbe/>, {inverted: true});
|
|
|
|
|
|
|
|
|
|
expect(screen.getByTestId('probe')).toHaveTextContent(`${darkTheme}:true`);
|
|
|
|
|
expect(document.documentElement).toHaveAttribute('data-mantine-color-scheme', 'dark');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('lets a test contradict the theme deliberately', () => {
|
|
|
|
|
// isDark is derived, not fixed: a spec checking what a component does when the two
|
|
|
|
|
// disagree must still be able to say so.
|
|
|
|
|
render(<ThemeProbe/>, {theme: {theme: nightTheme, isDark: false}});
|
|
|
|
|
|
|
|
|
|
expect(screen.getByTestId('probe')).toHaveTextContent(`${nightTheme}:false`);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('renderUI stamps the theme it is given', () => {
|
|
|
|
|
it('sets data-theme so token-driven CSS resolves', () => {
|
|
|
|
|
renderUI(<div data-testid='plain'>hi</div>, {theme: amberTheme});
|
|
|
|
|
|
|
|
|
|
expect(document.documentElement).toHaveAttribute('data-theme', amberTheme);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('mockModule', () => {
|
|
|
|
|
/*
|
|
|
|
|
* It takes the module, not a path to it. Passing a path meant `jest.requireActual` ran
|
|
|
|
|
* from inside test-utils.js and resolved the caller's relative specifier against the wrong
|
|
|
|
|
* directory -- for a spec in components/ the documented `'../hooks/customHooks'` pointed
|
|
|
|
|
* outside src entirely. Handing over the module the spec already resolved cannot go wrong.
|
|
|
|
|
*/
|
|
|
|
|
it('keeps every export the caller did not replace', () => {
|
|
|
|
|
const actual = {useOne: () => 1, useTwo: () => 2, CONSTANT: 'x'};
|
|
|
|
|
const replaced = () => 99;
|
|
|
|
|
|
|
|
|
|
const result = mockModule(actual, {useTwo: replaced});
|
|
|
|
|
|
|
|
|
|
expect(result.useOne()).toBe(1);
|
|
|
|
|
expect(result.useTwo).toBe(replaced);
|
|
|
|
|
expect(result.CONSTANT).toBe('x');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('rejects a path, which cannot resolve from here', () => {
|
|
|
|
|
// Failing loudly beats resolving to the wrong module or to nothing at all.
|
|
|
|
|
expect(() => mockModule('../hooks/customHooks', {})).toThrow(/module.*not a path/i);
|
|
|
|
|
});
|
|
|
|
|
});
|