wrolpi/app/src/App.css

760 lines
24 KiB
CSS
Raw Normal View History

fix: toasts were covering the navigation bar's controls Six keyboard-shortcuts e2e tests started failing on CI: clicking the search glyph was refused because a `mantine-Notification-title` was on top of it. The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px -- while the bar occupies the first 54px of the page. Every toast has therefore been landing on the bar's right-hand corner: the search glyph, the hamburger, Help and Admin. For as long as the toast is up those controls cannot be clicked, and an error toast is precisely the moment a user reaches for Admin. It surfaced now because the previous commit gave the search glyph a proper hit area. At 18px it sat in the gap beneath the toast; grown to the height of the bar, it moved into the overlap. The toast has been covering that corner all along -- there was nothing there to hit. So this is not a test that needs loosening: CI found a real defect that predates the change that exposed it. Toasts now start below the bar. `--navbar-height` is shared between the bar's min-height and the offset so the two cannot drift, and the rule matches `[data-position^='top']` so a future move to bottom-right does not silently inherit a top offset. Mantine's own positioning uses `:where()`, which has zero specificity, so a single class wins. Tested by `elementFromPoint` rather than by comparing rectangles: that is the question Cypress's actionability check asks and the one a mouse asks. A geometry test would miss a toast that overlaps but sits behind, and a z-index test would miss one that is in front but elsewhere on screen. Three cases -- the search control, every control in the corner, and the offset itself, which is stated separately because the first two would also pass on a toast that merely happened to be narrow enough to miss at one viewport. Removing the offset reddens all three. Confirmed on the running app with a real error toast up: toast top 70px, bar bottom 54px, all six corner controls topmost at their own centres. The e2e spec passes locally, 12 of 12. 1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 15:55:26 -06:00
:root {
/* Shared with the toast offset below, so the two cannot drift apart. */
--navbar-height: 3.4em;
}
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
/* Nav bar: a hand-rolled flexbox bar. The user-chosen background and the foreground
measured against it are set inline (see themes/navColors); this stylesheet only
supplies structure and hover affordances. */
.wrolpi-navbar {
display: flex;
align-items: stretch;
ui: the last Semantic UI file, and the stylesheet with it ControllerPage was the final call site; Theme.tsx then had nothing left to wrap, so it drops from 861 lines to 338 -- the provider that resolves the theme, stamps `data-theme` and `data-media-filter`, persists both and hands Mantine our tokens. Everything below that was Semantic wrappers. The dark-mode compatibility props went with them. `i`, `s`, `t` and `inverted` existed so unmigrated components could borrow Semantic's dark treatment, and they carried hardcoded greys -- #1B1C1D, #dddddd, #eeeeee -- which is exactly what the token themes replaced. Three call sites in Common.js were still injecting the #eeeeee one into links. Then `semantic-ui-offline/semantic.min.css` came out of App.js. That took more with it than expected, and looking at the running app is the only reason it was caught: Every link lost its colour and gained the browser's underline and visited purple. The dashboard's load averages and section headings were underlined and purple. Links now take `--blue`, which remaps per theme, and underline only on hover -- many of them wrap cards, posters and icons. `box-sizing: border-box` disappeared, which silently changes the size of every padded element in the app. Semantic's reset had been providing it. The navigation bar overflowed a 1000px viewport with `nowrap` and cut "Admin" off the right edge -- the one link a user needs to reach the settings that fix a broken WROLPi. Semantic's menu wrapped; ours does now too. The gzipped CSS bundle is 47.5 kB, and one call site was still leaning on Semantic's grid classes -- now a flex column, since all three of its callers pass library components. The ratchet stays rather than being deleted. At zero it asserts four things: no file imports Semantic UI, none calls its toast library, none leans on its stylesheet, and no file reaches back through Theme.tsx. It can go when the packages are uninstalled. Theme.test.js is deleted, but not before porting the two behaviours it protected: that Button forwards a ref to the real DOM element (a class-component ref once crashed the Control page, because portals call `node.contains`), and that the progress percentage stays readable on every bar colour.
2026-07-30 13:41:05 -06:00
/*
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
* Wraps rather than clipping. With this many items the bar overflows a 1000px
* viewport, and `nowrap` cut "Admin" off the right edge -- the one link a user needs
* to reach the settings that fix a broken WROLPi.
ui: the last Semantic UI file, and the stylesheet with it ControllerPage was the final call site; Theme.tsx then had nothing left to wrap, so it drops from 861 lines to 338 -- the provider that resolves the theme, stamps `data-theme` and `data-media-filter`, persists both and hands Mantine our tokens. Everything below that was Semantic wrappers. The dark-mode compatibility props went with them. `i`, `s`, `t` and `inverted` existed so unmigrated components could borrow Semantic's dark treatment, and they carried hardcoded greys -- #1B1C1D, #dddddd, #eeeeee -- which is exactly what the token themes replaced. Three call sites in Common.js were still injecting the #eeeeee one into links. Then `semantic-ui-offline/semantic.min.css` came out of App.js. That took more with it than expected, and looking at the running app is the only reason it was caught: Every link lost its colour and gained the browser's underline and visited purple. The dashboard's load averages and section headings were underlined and purple. Links now take `--blue`, which remaps per theme, and underline only on hover -- many of them wrap cards, posters and icons. `box-sizing: border-box` disappeared, which silently changes the size of every padded element in the app. Semantic's reset had been providing it. The navigation bar overflowed a 1000px viewport with `nowrap` and cut "Admin" off the right edge -- the one link a user needs to reach the settings that fix a broken WROLPi. Semantic's menu wrapped; ours does now too. The gzipped CSS bundle is 47.5 kB, and one call site was still leaning on Semantic's grid classes -- now a flex column, since all three of its callers pass library components. The ratchet stays rather than being deleted. At zero it asserts four things: no file imports Semantic UI, none calls its toast library, none leans on its stylesheet, and no file reaches back through Theme.tsx. It can go when the packages are uninstalled. Theme.test.js is deleted, but not before porting the two behaviours it protected: that Button forwards a ref to the real DOM element (a class-component ref once crashed the Control page, because portals call `node.contains`), and that the progress percentage stays readable on every bar colour.
2026-07-30 13:41:05 -06:00
*/
flex-wrap: wrap;
fix: toasts were covering the navigation bar's controls Six keyboard-shortcuts e2e tests started failing on CI: clicking the search glyph was refused because a `mantine-Notification-title` was on top of it. The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px -- while the bar occupies the first 54px of the page. Every toast has therefore been landing on the bar's right-hand corner: the search glyph, the hamburger, Help and Admin. For as long as the toast is up those controls cannot be clicked, and an error toast is precisely the moment a user reaches for Admin. It surfaced now because the previous commit gave the search glyph a proper hit area. At 18px it sat in the gap beneath the toast; grown to the height of the bar, it moved into the overlap. The toast has been covering that corner all along -- there was nothing there to hit. So this is not a test that needs loosening: CI found a real defect that predates the change that exposed it. Toasts now start below the bar. `--navbar-height` is shared between the bar's min-height and the offset so the two cannot drift, and the rule matches `[data-position^='top']` so a future move to bottom-right does not silently inherit a top offset. Mantine's own positioning uses `:where()`, which has zero specificity, so a single class wins. Tested by `elementFromPoint` rather than by comparing rectangles: that is the question Cypress's actionability check asks and the one a mouse asks. A geometry test would miss a toast that overlaps but sits behind, and a z-index test would miss one that is in front but elsewhere on screen. Three cases -- the search control, every control in the corner, and the offset itself, which is stated separately because the first two would also pass on a toast that merely happened to be narrow enough to miss at one viewport. Removing the offset reddens all three. Confirmed on the running app with a real error toast up: toast top 70px, bar bottom 54px, all six corner controls topmost at their own centres. The e2e spec passes locally, 12 of 12. 1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 15:55:26 -06:00
min-height: var(--navbar-height);
padding: 0 0.25em;
}
fix: toasts were covering the navigation bar's controls Six keyboard-shortcuts e2e tests started failing on CI: clicking the search glyph was refused because a `mantine-Notification-title` was on top of it. The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px -- while the bar occupies the first 54px of the page. Every toast has therefore been landing on the bar's right-hand corner: the search glyph, the hamburger, Help and Admin. For as long as the toast is up those controls cannot be clicked, and an error toast is precisely the moment a user reaches for Admin. It surfaced now because the previous commit gave the search glyph a proper hit area. At 18px it sat in the gap beneath the toast; grown to the height of the bar, it moved into the overlap. The toast has been covering that corner all along -- there was nothing there to hit. So this is not a test that needs loosening: CI found a real defect that predates the change that exposed it. Toasts now start below the bar. `--navbar-height` is shared between the bar's min-height and the offset so the two cannot drift, and the rule matches `[data-position^='top']` so a future move to bottom-right does not silently inherit a top offset. Mantine's own positioning uses `:where()`, which has zero specificity, so a single class wins. Tested by `elementFromPoint` rather than by comparing rectangles: that is the question Cypress's actionability check asks and the one a mouse asks. A geometry test would miss a toast that overlaps but sits behind, and a z-index test would miss one that is in front but elsewhere on screen. Three cases -- the search control, every control in the corner, and the offset itself, which is stated separately because the first two would also pass on a toast that merely happened to be narrow enough to miss at one viewport. Removing the offset reddens all three. Confirmed on the running app with a real error toast up: toast top 70px, bar bottom 54px, all six corner controls topmost at their own centres. The e2e spec passes locally, 12 of 12. 1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 15:55:26 -06:00
/*
* Toasts start below the navigation bar instead of on top of it.
*
* They are fixed at `top: var(--mantine-spacing-md)` -- 16px -- while the bar occupies the
* first 54px of the page, so every toast landed over the bar's right-hand corner: the search
* glyph, the hamburger, Help and Admin. For as long as the toast was up those controls could
* not be clicked, and an error toast is exactly when a user reaches for Admin.
*
* It went unnoticed until the search glyph was given a proper hit area: at 18px it sat in the
* gap under the toast, and growing it to the height of the bar moved it into the overlap.
* The toast was always covering that corner; there was just nothing there to hit.
*
* `:where()` gives Mantine's own rule zero specificity, so one class is enough to win, but
* the attribute is matched too -- only the top-anchored positions need moving, and a future
* switch to `bottom-right` should not silently inherit a top offset.
*/
html .mantine-Notifications-root[data-position^='top'] {
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
top: calc(var(--navbar-height) + var(--mantine-spacing-md, 1rem));
fix: toasts were covering the navigation bar's controls Six keyboard-shortcuts e2e tests started failing on CI: clicking the search glyph was refused because a `mantine-Notification-title` was on top of it. The toast container is fixed at `top: var(--mantine-spacing-md)` -- 16px -- while the bar occupies the first 54px of the page. Every toast has therefore been landing on the bar's right-hand corner: the search glyph, the hamburger, Help and Admin. For as long as the toast is up those controls cannot be clicked, and an error toast is precisely the moment a user reaches for Admin. It surfaced now because the previous commit gave the search glyph a proper hit area. At 18px it sat in the gap beneath the toast; grown to the height of the bar, it moved into the overlap. The toast has been covering that corner all along -- there was nothing there to hit. So this is not a test that needs loosening: CI found a real defect that predates the change that exposed it. Toasts now start below the bar. `--navbar-height` is shared between the bar's min-height and the offset so the two cannot drift, and the rule matches `[data-position^='top']` so a future move to bottom-right does not silently inherit a top offset. Mantine's own positioning uses `:where()`, which has zero specificity, so a single class wins. Tested by `elementFromPoint` rather than by comparing rectangles: that is the question Cypress's actionability check asks and the one a mouse asks. A geometry test would miss a toast that overlaps but sits behind, and a z-index test would miss one that is in front but elsewhere on screen. Three cases -- the search control, every control in the corner, and the offset itself, which is stated separately because the first two would also pass on a toast that merely happened to be narrow enough to miss at one viewport. Removing the offset reddens all three. Confirmed on the running app with a real error toast up: toast top 70px, bar bottom 54px, all six corner controls topmost at their own centres. The e2e spec passes locally, 12 of 12. 1124 jest / 62 suites, 199 in ui-layout.cy.js, clean npm run build.
2026-08-02 15:55:26 -06:00
}
.wrolpi-navbar-right {
display: flex;
align-items: center;
margin-left: auto;
gap: 0.2em;
}
.wrolpi-navbar-link,
.wrolpi-navbar-link-button {
display: flex;
align-items: center;
ui: the last Semantic UI file, and the stylesheet with it ControllerPage was the final call site; Theme.tsx then had nothing left to wrap, so it drops from 861 lines to 338 -- the provider that resolves the theme, stamps `data-theme` and `data-media-filter`, persists both and hands Mantine our tokens. Everything below that was Semantic wrappers. The dark-mode compatibility props went with them. `i`, `s`, `t` and `inverted` existed so unmigrated components could borrow Semantic's dark treatment, and they carried hardcoded greys -- #1B1C1D, #dddddd, #eeeeee -- which is exactly what the token themes replaced. Three call sites in Common.js were still injecting the #eeeeee one into links. Then `semantic-ui-offline/semantic.min.css` came out of App.js. That took more with it than expected, and looking at the running app is the only reason it was caught: Every link lost its colour and gained the browser's underline and visited purple. The dashboard's load averages and section headings were underlined and purple. Links now take `--blue`, which remaps per theme, and underline only on hover -- many of them wrap cards, posters and icons. `box-sizing: border-box` disappeared, which silently changes the size of every padded element in the app. Semantic's reset had been providing it. The navigation bar overflowed a 1000px viewport with `nowrap` and cut "Admin" off the right edge -- the one link a user needs to reach the settings that fix a broken WROLPi. Semantic's menu wrapped; ours does now too. The gzipped CSS bundle is 47.5 kB, and one call site was still leaning on Semantic's grid classes -- now a flex column, since all three of its callers pass library components. The ratchet stays rather than being deleted. At zero it asserts four things: no file imports Semantic UI, none calls its toast library, none leans on its stylesheet, and no file reaches back through Theme.tsx. It can go when the packages are uninstalled. Theme.test.js is deleted, but not before porting the two behaviours it protected: that Button forwards a ref to the real DOM element (a class-component ref once crashed the Control page, because portals call `node.contains`), and that the progress percentage stays readable on every bar colour.
2026-07-30 13:41:05 -06:00
/* Tightened from 1.1em: the bar has eleven links plus nine indicators. */
padding: 0 0.8em;
color: inherit;
text-decoration: none;
white-space: nowrap;
background: none;
border: none;
font: inherit;
cursor: pointer;
}
.wrolpi-navbar-link:hover,
.wrolpi-navbar-link-button:hover {
/* A translucent black works on every navbar color, light or dark. */
ui: the last Semantic UI file, and the stylesheet with it ControllerPage was the final call site; Theme.tsx then had nothing left to wrap, so it drops from 861 lines to 338 -- the provider that resolves the theme, stamps `data-theme` and `data-media-filter`, persists both and hands Mantine our tokens. Everything below that was Semantic wrappers. The dark-mode compatibility props went with them. `i`, `s`, `t` and `inverted` existed so unmigrated components could borrow Semantic's dark treatment, and they carried hardcoded greys -- #1B1C1D, #dddddd, #eeeeee -- which is exactly what the token themes replaced. Three call sites in Common.js were still injecting the #eeeeee one into links. Then `semantic-ui-offline/semantic.min.css` came out of App.js. That took more with it than expected, and looking at the running app is the only reason it was caught: Every link lost its colour and gained the browser's underline and visited purple. The dashboard's load averages and section headings were underlined and purple. Links now take `--blue`, which remaps per theme, and underline only on hover -- many of them wrap cards, posters and icons. `box-sizing: border-box` disappeared, which silently changes the size of every padded element in the app. Semantic's reset had been providing it. The navigation bar overflowed a 1000px viewport with `nowrap` and cut "Admin" off the right edge -- the one link a user needs to reach the settings that fix a broken WROLPi. Semantic's menu wrapped; ours does now too. The gzipped CSS bundle is 47.5 kB, and one call site was still leaning on Semantic's grid classes -- now a flex column, since all three of its callers pass library components. The ratchet stays rather than being deleted. At zero it asserts four things: no file imports Semantic UI, none calls its toast library, none leans on its stylesheet, and no file reaches back through Theme.tsx. It can go when the packages are uninstalled. Theme.test.js is deleted, but not before porting the two behaviours it protected: that Button forwards a ref to the real DOM element (a class-component ref once crashed the Control page, because portals call `node.contains`), and that the progress percentage stays readable on every bar colour.
2026-07-30 13:41:05 -06:00
background: rgba(0, 0, 0, 0.12);
}
ui: the navbar shows which section you are in (#649) * ui: the navbar shows which section you are in Clicking Videos opened the videos page and left the bar looking untouched. react-router was doing its part the whole time -- the tab carried `active` and `aria-current="page"` on every one of those pages. Nothing in the stylesheet drew that class, so all eleven tabs rendered identically and the mark was visible only to a screen reader. The current tab now takes a deepened version of the hover wash plus an underline. The underline is a pseudo-element in `currentColor` rather than a border, for two reasons: `currentColor` is the foreground the bar already computed for whichever of the fourteen navbar colors the user picked, so one rule covers every color in every theme without naming one; and a pseudo-element adds no height, where a border would jog the whole row as the mark moved between tabs. The overflow "More" menu and the mobile hamburger mark their copy of the tab too -- on a phone that menu is where most tabs live. Calculators and Statistics also lose `end: true`. A tab is meant to stay current for the pages beneath it, and `end` restricts the match to the exact path, so either one would have dropped its mark the moment it grew a sub-page. The other nine links never had it, which is why /videos/1234 already kept Videos marked. The test renders the real bar, which needed two pieces of browser jsdom does not have: fresnel renders no navbar at all unless a breakpoint query matches, and every width is 0, which convinces the overflow logic that nothing fits and sweeps all eleven tabs into the closed "More" menu -- where every assertion about them would have passed vacuously. Both are stubbed, and the styling itself is asserted against the stylesheet, since jsdom applies none. * review: the mark follows the tab into the overflow menu Six review points, no bugs among them. The substantive one: when the window narrows enough to fold the current tab into "More", the bar went blank again -- the trigger is a plain button, not a NavLink, so nothing was marked until the user opened the menu to look, which is exactly when they least need telling. "More" now takes the mark when it holds the current section. That needs the matching rule outside a NavLink, where the hooks that answer it cannot be called in a loop, so `isLinkActive` states it once: a link owns the pages beneath it unless it asks for an exact match. The trigger gets the class only -- the real NavLink inside the menu already carries `aria-current`, and a second one on the button that opens the menu announces the same page twice. The other five, all fair: * The mobile hamburger and the overflow menu had no test at all, so `.mantine-Menu-item.active` -- the whole of the mark on a phone -- was never exercised. Both now are, which meant splitting the viewport and the bar width out of the fixture so a test can ask for a narrow bar or a phone. The mobile case also needs the real getBoundingClientRect back: floating-ui positions the menu's portal and crashes the worker on a stub DOMRect. * The CSS guard matched the selector as a substring, which still passed with the rule body emptied or the underline deleted -- and the underline is the half that survives on a dark bar. It now reads the declarations. * The table cases used `toContain`, which a regression leaving Home permanently marked would satisfy on every row. `toEqual([text])`. * A comment claimed the tab "only matched its own exact path", which is the root cause the PR description explicitly rules out -- Videos never carried `end`. Corrected to what those cases actually guard. * The navbar offers twelve colors, not fourteen. I had carried over Semantic's palette count, which includes black and white. Writing the tightened height assertion I reached for `(?!0)`, which calls 0.1875rem zero. It reads the number instead.
2026-08-08 17:10:53 -06:00
/*
* The tab for the section the user is in.
*
* react-router marks it with `active` and `aria-current` on its own, and always did -- the
* mark reached the DOM and nothing here drew it, so every tab looked identical and clicking
* Videos appeared to leave the bar untouched.
*
* The underline is a pseudo-element in `currentColor`, not a border: `currentColor` follows
* the foreground the bar computed for whatever navbar color the user picked, so this works
* on all twelve of them (see `navColorNames`) and in all four themes without naming a color;
* and a pseudo-element adds no height, where a border would jog the whole row as the mark
* moved between tabs. The darker wash is the hover treatment deepened, so the two read as
* the same idea.
*/
.wrolpi-navbar-link.active {
position: relative;
background: rgba(0, 0, 0, 0.2);
}
.wrolpi-navbar-link.active::after {
content: '';
position: absolute;
left: 0;
right: 0;
bottom: 0;
/* rem, not px, so the mark grows with the --ui-scale setting like the text above it. */
height: 0.1875rem;
background: currentColor;
}
/*
* The same tabs inside the overflow "More" menu and the mobile hamburger, which are the
* only place most of them appear on a phone. Those render in a portal, outside the bar,
* so they take theme tokens rather than the bar's foreground.
*/
.mantine-Menu-item.active {
background: var(--head);
font-weight: 600;
}
2026-08-02 14:12:39 -06:00
/*
* Everything in the bar takes the bar's foreground.
*
* `color: inherit` on the links alone was not enough, because two of the things in the
* corner do not inherit at all and both came out blue on every bar in every theme:
*
* - An anchor takes `a {color: var(--blue)}` from tokens.css, which outranks an inherited
* value however the bar sets it. The search glyph is an anchor, and so is every status
* icon that links to /admin -- those only looked right because they carry an inline
* color of their own, which still wins here and is meant to.
2026-08-02 14:12:39 -06:00
* - A Mantine ActionIcon paints `--ai-color`, its own themed blue. The hamburger and the
* theme toggle are ActionIcons. The variable is no use as a hook: Mantine writes it
* INLINE on the element, so a stylesheet declaring it loses every time (the same trap
* as `--group-justify` on Pagination). The painted property has to be set instead, and
* `html` lifts this over Mantine's own single-class rule.
*
* Measuring the foreground against the bar is worth nothing if the icons opt out of it.
*/
.wrolpi-navbar a,
html .wrolpi-navbar .mantine-ActionIcon-root {
color: inherit;
}
/* The bar's own hover, rather than a blue tint from Mantine's palette. */
html .wrolpi-navbar .mantine-ActionIcon-root:hover {
background: rgba(0, 0, 0, 0.12);
color: inherit;
}
ui: the navbar corner was nudged rather than laid out, and it showed Three faults in the bar, all reproduced by measurement before being fixed. The indicators sat low. The slot carried `marginTop: 0.8em`, a nudge left over from Semantic's menu; the corner centres its children, and a top margin is part of the margin box being centred, so it applied as a ~6px downward shift. It read as an error on the hotspot and the theme picker but not on share or search, which is why it survived: an IconButton is a square ActionIcon that centres its glyph exactly, while a bare-icon anchor sits high inside a line box that reserves descender space for text that is not there. The nudge cancelled that out on one shape and was pure error on the other. Both are laid out now -- flex, centred, no nudge -- and the anchors get `display: flex` so they hug their glyph instead of a text line. Help and Admin highlighted only a box around their text while Videos and Statistics highlighted the full height. Same class, same rules, different parent: the bar stretches its children, but the corner is a nested flex container that centres its own, so a link inside it was sized to its content. The hover background is painted on the link box, so that box IS the affordance. The bar broke onto a second line at certain widths. Two measurement errors that only overlap in a narrow band, which is why it appeared while resizing rather than always. useOverflowNav measured the WRAPPER's offsetWidth and subtracted only the home link and the corner, missing the bar's own `padding: 0 0.25em` -- about 8px it believed it had. And the hidden "More" placeholder it measured was a plain button with no dropdown caret, about 21px narrower than the button that eventually rendered. The placeholder is now the same component as the real trigger, so the two cannot drift again. Tested in ui-layout.cy.js against the real <DesktopNav/>, which takes its colours, home link and indicators as props and so needs none of NavBar's polling hooks. Indicator centres are measured against the bar's centre rather than each other, because three things can be equally and consistently wrong and were. The wrap case sweeps 1180px down to 640px in 6px steps -- a spot check steps over a band that narrow. All three failed first: share 3.4px high, Help 24.8px against a 54.4px bar, and two rows at 1156px. Confirmed on the running app: every indicator at 0.0px from the bar's centre, Help and Admin at the full 54.4px, and no wrap anywhere from 1500px to 780px. 1115 jest / 62 suites, 182 in ui-layout.cy.js, clean npm run build.
2026-08-02 14:25:04 -06:00
/*
* One status indicator's slot. Laid out rather than nudged: see NavIconWrapper in Nav.js
* for the 0.8em top margin this replaces and why it looked correct on half the indicators.
*/
.wrolpi-navbar-icon {
display: flex;
align-items: center;
/* A sliver only: the corner's gap and the slots' own padding already separate the
icons, and anything more has to fit a 320px phone times the number of slots. */
margin-left: 0.25em;
ui: the corner triggers, the More button, and the search modal Four faults, each measured in the running app before and after. The search glyph carried Semantic's `item` class, which has had no rules at all since Semantic was removed: no pointer cursor, no hover, and an 18.6px hit area against a 54.4px bar. It is the same kind of thing as Help and Admin and now takes the same class. The share glyph did compute `cursor: pointer` -- it is an `<a href>` -- but its target was the 24px box the icon occupies, so the pointer appeared only if you found it exactly. Corner anchors now stretch and pad like a link. The More button rendered with NO class at all: a bare grey UA button while the rest of the bar took the user's colour. Menu.Target clones its child and hands it a className of its own, and the trigger spread those cloned props after its own `className` attribute, so the clone replaced ours. It is merged now. This was mine, from extracting NavDropdownTrigger last commit -- and it also made the previous commit's "measured and drawn are the same component" claim only half true, because the hidden placeholder is not cloned and so kept its class. The bar still wrapped, for a reason the padding fix could not reach: the corner does not keep a constant width. The Cmd-K hint renders only once useKeyboardDetected has seen a keypress, so it appears at an arbitrary later moment and widens the corner by ~30px; the load, memory, temperature and drive warnings come and go with the machine's state. None of that resizes the container, which was the only thing observed -- so nothing recalculated. That is the other half of "at certain widths": the same viewport wrapped or not depending on whether the user had touched a key. The corner and the home link are observed too now. The search modal showed an input and the first line of the first group. The suggestion list is absolutely positioned, which is right everywhere else -- a list that reflows the page while you type is unusable -- but in a modal it fails twice: an absolute list adds no height, so the panel sized itself to the search box alone at 114px, and the panel's own `overflow: auto` then clipped the list at that edge. In the modal the list sits in flow; the inverse is asserted so the rule cannot leak to the pages where overlaying is correct. Two of the new tests were wrong first and reverting the fix left them green: they asserted hand-written markup carrying the classes I expected the components to have, rather than the real SearchIconButton and ShareButton. They use the real components now. Every fix was then planted against: 5 red for the More class, 2 for the search class, 2 for the corner hit area, 1 for the observer, 2 for the modal. 1115 jest / 62 suites, 196 in ui-layout.cy.js, clean npm run build. Confirmed live: share and search both pointer at 54.4px, More white on the bar colour with a transparent face, and the modal's list in flow and unclipped.
2026-08-02 14:45:49 -06:00
/* Full bar height, so the anchor inside has somewhere to stretch to. */
align-self: stretch;
}
/*
* An icon-only trigger in the corner gets a link's hit area, not its glyph's.
*
* The share glyph already computed `cursor: pointer` -- it is an `<a href>` -- but the
* target was the 24px box the icon occupies, so the pointer appeared only if you found it
* exactly, and there was no hover highlight to aim at. Stretched and padded, it behaves
* like Help and Admin beside it.
*
* `align-self` rather than `align-items: stretch` on the wrapper: the IconButtons in the
* corner have an explicit height, and a stretch container places an item it cannot stretch
* at the start -- which would push the hotspot and theme glyphs back off centre.
*/
.wrolpi-navbar-icon > a {
align-self: stretch;
padding: 0 0.5em;
cursor: pointer;
}
.wrolpi-navbar-icon > a:hover {
background: rgba(0, 0, 0, 0.12);
ui: the navbar corner was nudged rather than laid out, and it showed Three faults in the bar, all reproduced by measurement before being fixed. The indicators sat low. The slot carried `marginTop: 0.8em`, a nudge left over from Semantic's menu; the corner centres its children, and a top margin is part of the margin box being centred, so it applied as a ~6px downward shift. It read as an error on the hotspot and the theme picker but not on share or search, which is why it survived: an IconButton is a square ActionIcon that centres its glyph exactly, while a bare-icon anchor sits high inside a line box that reserves descender space for text that is not there. The nudge cancelled that out on one shape and was pure error on the other. Both are laid out now -- flex, centred, no nudge -- and the anchors get `display: flex` so they hug their glyph instead of a text line. Help and Admin highlighted only a box around their text while Videos and Statistics highlighted the full height. Same class, same rules, different parent: the bar stretches its children, but the corner is a nested flex container that centres its own, so a link inside it was sized to its content. The hover background is painted on the link box, so that box IS the affordance. The bar broke onto a second line at certain widths. Two measurement errors that only overlap in a narrow band, which is why it appeared while resizing rather than always. useOverflowNav measured the WRAPPER's offsetWidth and subtracted only the home link and the corner, missing the bar's own `padding: 0 0.25em` -- about 8px it believed it had. And the hidden "More" placeholder it measured was a plain button with no dropdown caret, about 21px narrower than the button that eventually rendered. The placeholder is now the same component as the real trigger, so the two cannot drift again. Tested in ui-layout.cy.js against the real <DesktopNav/>, which takes its colours, home link and indicators as props and so needs none of NavBar's polling hooks. Indicator centres are measured against the bar's centre rather than each other, because three things can be equally and consistently wrong and were. The wrap case sweeps 1180px down to 640px in 6px steps -- a spot check steps over a band that narrow. All three failed first: share 3.4px high, Help 24.8px against a 54.4px bar, and two rows at 1156px. Confirmed on the running app: every indicator at 0.0px from the bar's centre, Help and Admin at the full 54.4px, and no wrap anywhere from 1500px to 780px. 1115 jest / 62 suites, 182 in ui-layout.cy.js, clean npm run build.
2026-08-02 14:25:04 -06:00
}
/*
* An anchor in the corner hugs its glyph instead of a text line box.
*
* A line box reserves descender space for text that is not there, which leaves an icon
* sitting about 3px above the centre of the box being centred -- the share and search
* glyphs, but not the hotspot or theme picker, which are square ActionIcons that centre
* their own glyph. That difference is what made a single top margin look right on some
* indicators and wrong on others.
*/
.wrolpi-navbar-right a {
display: flex;
align-items: center;
}
/*
* A link in the corner fills the bar's height, as one outside it does.
*
* Help and Admin highlighted only a box around their text while Videos and Statistics
* highlighted the full height. Same class and same rules; the difference is the parent.
* The bar stretches its children, but the corner is a nested flex container that centres
* its own, so a link inside it was sized to its content. The hover background is painted
* on the link box, so this is the hover affordance itself and not just its outline.
*/
.wrolpi-navbar-right .wrolpi-navbar-link,
.wrolpi-navbar-right .wrolpi-navbar-link-button {
align-self: stretch;
}
::-ms-clear {
display: none;
}
pre.wrap-text {
white-space: pre-wrap; /* Since CSS 2.1 */
white-space: -moz-pre-wrap; /* Mozilla, since 1999 */
word-wrap: break-word; /* Internet Explorer 5.5+ */
}
ui: three from the dashboard and the video pages The Download/Or/Upload panel. Semantic drew it as a `Segment placeholder` with a vertical `Divider`: two equal fields, a rule down the true middle, a button centred in each. The migrated version was a `Group` with a divider between two buttons, so the halves were sized to their labels -- the pair huddled in the middle with the rule wherever they left it. `.wrolpi-or-split` is a grid, so the halves stay equal whatever the labels say, and the rule is the second column's border rather than an element between them (an element would be a third grid item and push the middle off centre by its own width). Below the tablet breakpoint the halves stack and the rule turns horizontal, as Semantic's `stackable` grid did. The video page's panels touched the left edge. Its route is deliberately outside `VideosTabLayout`'s `PageContainer` so the player can run to both edges -- which is the most viewing area a phone can give it, and worth keeping -- but everything below the player inherited that too. `.wrolpi-page-inset` gives the stack under the player the same inset `PageContainer` gives a page, at the same breakpoint, so a phone still has no side padding anywhere. A video's duration chip was a literal `#ffffff` with black text. The poster under it IS filtered by night mode, being a `.media` leaf, but the chip is drawn beside the image rather than inside it, so the filter never reached it: a white tile on a card whose picture had gone dim red, and the brightest thing on the videos page in the theme whose whole point is that nothing is bright. Tokens now, opaque because it sits on an arbitrary poster. Nine guards, all verified to fail against the old code. One thing they turned up: cypress component tests default to a 500x500 viewport, which is BELOW the 699px breakpoint, so viewport-keyed CSS is exercised in its phone branch unless a test says otherwise. The desktop assertions set the viewport explicitly and say why; the stacked branch has a test of its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 17:38:19 -06:00
/*
* A video's length, pinned to the corner of its poster.
*
* Tokens, not a literal white-on-black. The poster under it is filtered by night mode -- it is a
* `.media` leaf -- but this chip is drawn beside the image rather than inside it, so it was never
* filtered: a white tile on a card whose picture had gone dim red, which is the brightest thing on
* the videos page in the theme meant to have nothing bright on it.
*
* Opaque, because it sits on an arbitrary poster and has to be legible over any of them.
*/
.duration-overlay {
position: absolute;
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
top: 0.25rem;
right: 0.25rem;
ui: three from the dashboard and the video pages The Download/Or/Upload panel. Semantic drew it as a `Segment placeholder` with a vertical `Divider`: two equal fields, a rule down the true middle, a button centred in each. The migrated version was a `Group` with a divider between two buttons, so the halves were sized to their labels -- the pair huddled in the middle with the rule wherever they left it. `.wrolpi-or-split` is a grid, so the halves stay equal whatever the labels say, and the rule is the second column's border rather than an element between them (an element would be a third grid item and push the middle off centre by its own width). Below the tablet breakpoint the halves stack and the rule turns horizontal, as Semantic's `stackable` grid did. The video page's panels touched the left edge. Its route is deliberately outside `VideosTabLayout`'s `PageContainer` so the player can run to both edges -- which is the most viewing area a phone can give it, and worth keeping -- but everything below the player inherited that too. `.wrolpi-page-inset` gives the stack under the player the same inset `PageContainer` gives a page, at the same breakpoint, so a phone still has no side padding anywhere. A video's duration chip was a literal `#ffffff` with black text. The poster under it IS filtered by night mode, being a `.media` leaf, but the chip is drawn beside the image rather than inside it, so the filter never reached it: a white tile on a card whose picture had gone dim red, and the brightest thing on the videos page in the theme whose whole point is that nothing is bright. Tokens now, opaque because it sits on an arbitrary poster. Nine guards, all verified to fail against the old code. One thing they turned up: cypress component tests default to a 500x500 viewport, which is BELOW the 699px breakpoint, so viewport-keyed CSS is exercised in its phone branch unless a test says otherwise. The desktop assertions set the viewport explicitly and say why; the stacked branch has a test of its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 17:38:19 -06:00
color: var(--text);
background: var(--panel);
border: 1px solid var(--border);
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
padding: 0px 0.25rem;
border-radius: 0.1875rem;
}
.no-link-underscore {
text-decoration: none !important;
}
ui: cards get legible titles, contained posters, and meta beside the title Four defects on /videos, /docs and /archives. Titles were invisible outside light. `.card-link` carried a literal `color: black` from before the themes existed -- about 1.1:1 on the dark, night and amber panels. It applies to every card title and to the channel/author/domain line beside it. The date was fine, since it takes `--muted` from the card body, which is what made this look like a card bug rather than a link bug. Titles now take `--text`: they are links, but they are the card's text, not a wall of blue. Posters were cropped, not mis-proportioned. The image carried a fixed 290x163 box; a card in the default grid is about 233px wide and Mantine's Card sets `overflow: hidden`, so the browser painted the middle 233px of a 290px image. The ratio was right in the layout tree and wrong on screen. Replaced with caps on both axes -- the card's width and `--card-poster-max-height: 200px` -- with `width`/`height` left `auto` so the pair behaves as "contain". Bounding the width alone was tried first and is not enough: a square thumbnail then stands as tall as the card is wide, and a portrait book cover taller still. The meta line was foot-anchored, so on /docs a PDF with no author had its date shoved up to 55px below the title, at the bottom of a card that was tall only because of its neighbour in the row. It now sits directly under the title. Archive cards read buttons-then-domain, because the buttons were children and the meta was what got pushed to the foot. Card gains an `actions` slot, rendered last and anchored to the foot, so a row lines its buttons up however many lines each title took. Gallery gains a poster row covering all five ratios and a row showing meta/actions against unequal titles. 1076 jest tests, 145 in ui-layout.cy.js, clean build. Every new guard was checked against a planted regression: dropping the height cap reddens the square and portrait cases and leaves 16:9 green; `width: 100%` reddens containment; restoring `color: black` reddens dark/night/amber and leaves light green; re-anchoring the meta and swapping the slot order redden both the jest order test and the cypress geometry tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-02 09:16:31 -06:00
/*
* A card's title and its author/channel/domain line are links, but they are the card's
* text -- they take the body color rather than the link color, so a grid of cards reads
ui: cards get legible titles, contained posters, and meta beside the title Four defects on /videos, /docs and /archives. Titles were invisible outside light. `.card-link` carried a literal `color: black` from before the themes existed -- about 1.1:1 on the dark, night and amber panels. It applies to every card title and to the channel/author/domain line beside it. The date was fine, since it takes `--muted` from the card body, which is what made this look like a card bug rather than a link bug. Titles now take `--text`: they are links, but they are the card's text, not a wall of blue. Posters were cropped, not mis-proportioned. The image carried a fixed 290x163 box; a card in the default grid is about 233px wide and Mantine's Card sets `overflow: hidden`, so the browser painted the middle 233px of a 290px image. The ratio was right in the layout tree and wrong on screen. Replaced with caps on both axes -- the card's width and `--card-poster-max-height: 200px` -- with `width`/`height` left `auto` so the pair behaves as "contain". Bounding the width alone was tried first and is not enough: a square thumbnail then stands as tall as the card is wide, and a portrait book cover taller still. The meta line was foot-anchored, so on /docs a PDF with no author had its date shoved up to 55px below the title, at the bottom of a card that was tall only because of its neighbour in the row. It now sits directly under the title. Archive cards read buttons-then-domain, because the buttons were children and the meta was what got pushed to the foot. Card gains an `actions` slot, rendered last and anchored to the foot, so a row lines its buttons up however many lines each title took. Gallery gains a poster row covering all five ratios and a row showing meta/actions against unequal titles. 1076 jest tests, 145 in ui-layout.cy.js, clean build. Every new guard was checked against a planted regression: dropping the height cap reddens the square and portrait cases and leaves 16:9 green; `width: 100%` reddens containment; restoring `color: black` reddens dark/night/amber and leaves light green; re-anchoring the meta and swapping the slot order redden both the jest order test and the cypress geometry tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-02 09:16:31 -06:00
* as titles and not as a wall of blue. This was a literal `black` until the themes
* arrived, which left every title at about 1.1:1 on the dark, night and amber panels.
*/
.card-link {
ui: cards get legible titles, contained posters, and meta beside the title Four defects on /videos, /docs and /archives. Titles were invisible outside light. `.card-link` carried a literal `color: black` from before the themes existed -- about 1.1:1 on the dark, night and amber panels. It applies to every card title and to the channel/author/domain line beside it. The date was fine, since it takes `--muted` from the card body, which is what made this look like a card bug rather than a link bug. Titles now take `--text`: they are links, but they are the card's text, not a wall of blue. Posters were cropped, not mis-proportioned. The image carried a fixed 290x163 box; a card in the default grid is about 233px wide and Mantine's Card sets `overflow: hidden`, so the browser painted the middle 233px of a 290px image. The ratio was right in the layout tree and wrong on screen. Replaced with caps on both axes -- the card's width and `--card-poster-max-height: 200px` -- with `width`/`height` left `auto` so the pair behaves as "contain". Bounding the width alone was tried first and is not enough: a square thumbnail then stands as tall as the card is wide, and a portrait book cover taller still. The meta line was foot-anchored, so on /docs a PDF with no author had its date shoved up to 55px below the title, at the bottom of a card that was tall only because of its neighbour in the row. It now sits directly under the title. Archive cards read buttons-then-domain, because the buttons were children and the meta was what got pushed to the foot. Card gains an `actions` slot, rendered last and anchored to the foot, so a row lines its buttons up however many lines each title took. Gallery gains a poster row covering all five ratios and a row showing meta/actions against unequal titles. 1076 jest tests, 145 in ui-layout.cy.js, clean build. Every new guard was checked against a planted regression: dropping the height cap reddens the square and portrait cases and leaves 16:9 green; `width: 100%` reddens containment; restoring `color: black` reddens dark/night/amber and leaves light green; re-anchoring the meta and swapping the slot order redden both the jest order test and the cypress geometry tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-02 09:16:31 -06:00
color: var(--text);
}
review: close the mixed-unit gaps the scale left behind Seven review comments, all valid. The common thread is the one the guard was supposed to catch and did not: geometry converted to rem beside geometry that stayed px. The guard was narrower than its name. It missed: - `transform`, `flex` and `flex-basis`, so `translateX(26px)` and `flex: 1 1 200px` were invisible on properties nobody thought to list; - every NEGATIVE length, because the lookbehind treated the minus sign as part of the preceding token -- `left: -7px` and `margin-top: -2.5px` position the eyelet on a tag whose diamond HAD been converted, and `right: -3px` / `bottom: -3px` place the corner badge on a converted icon. Each is a piece of geometry that stopped tracking the piece it belongs to. With both fixed it found nine values, including one no comment mentioned (`flex: 1 1 200px`). All nine converted, except the three in a dead `.toggle` / `.slider` block: nothing has referenced those classes since Toggle became a Mantine Switch, and it was ALREADY broken -- track and knob in rem, travel still `translateX(26px)`, so the thumb stopped ~4px short of a 54px track. Dead CSS that is also wrong is a trap for whoever revives it, so it is deleted. The tag eyelet is centred with `translateY(-50%)` rather than a negative margin of half its own height, so the two pieces cannot drift again whatever the scale. Also from the review: - A runtime check, which is what the source guards were missing. Three cases in ui-layout.cy.js measure the real thing: the root font-size is the declared multiple of 16, our text AND a Mantine control both grow by the same factor when the scale changes, and a hairline does not. The second is the one that catches `theme.scale` being set and silently cancelling the root. - `max-height: max(..., 56.25cqw)` now follows a plain rem declaration. An engine without container query units throws out the whole declaration, which would have left the poster with NO cap -- a portrait cover standing as tall as the card is wide. Older engines clamp; newer ones take the second. - `pxToRem` in components/ui/scale.ts, replacing the `/ 16` written out in CardGroup and Placeholder. - The map overlays: 20 values across the layer panel, add-pin dialog, search panel and context menu, whose type had grown 10% while their padding had not. Left in px on purpose: the context menu's `left`/`top` (a real click coordinate), maplibre's own `ScaleControl` maxWidth, and the `calc(100% - 100px)` reserve for maplibre's px-sized controls. The `100vh - 120px` reserve DID become rem, since the chrome it reserves for is ours. - The keyboard-shortcuts spec no longer deletes `.mantine-Notifications-root` from the DOM. The reviewer was right that it is brittle; the endpoints are mocked instead, now that the probe named them: `/api/tag`, `/api/events/feed`, `/api/files/search` and `/api/files/worker_status`. Two of those were already "mocked" as `/api/tags` and `/api/events`, which nothing calls -- the wrong paths were the reason a toast appeared at all. Verified under CI's condition (`forceNetworkError` on everything unmocked): 12 passing with no DOM surgery. What is NOT done, deliberately: about 176 numeric geometry values remain in 23 feature files. The map overlays were the visible ones. Sweeping the rest is a change to 23 files nobody has reviewed, so instead the guard's name now says "in our stylesheets" rather than implying the whole app, and a new ratchet keeps numeric geometry out of the component library so the eleventh inline `gap: 10` cannot be added there. Both new guards planted against. Verified: 1142 jest / 65 suites, 251 ui-layout + 10 modal-stack component tests, all 50 e2e specs, clean build, map overlays measured to track the scale (panel minWidth 200 -> 220, search 320 -> 352) and screenshotted.
2026-08-03 19:37:25 -06:00
/*
* The hand-rolled `.toggle` / `.slider` switch is gone.
*
* Nothing referenced either class: `Toggle` is a Mantine Switch, and the only remaining
* matches for the words were the `classList.toggle` DOM method and the controller's own
* templates, which do not load this stylesheet.
*
* It is deleted rather than finished because it was already half-converted and broken: the
* track and knob became rem while the checked-state travel stayed `translateX(26px)`, so on a
* 54px track the thumb would have stopped ~4px short. Dead CSS that is also wrong is a trap
* for whoever revives it, and it also hardcoded #6435C9 and white, which no theme can reach.
*/
Fixing changes before merge. Moving FilesRefreshButton and DirectoryRefreshButton out of browser file. Moving file fetching tino FileBrowser. Removing sub-folders from Files display when any parent folder is clicked. Using closed captioning for vtt/srt file icon. Using my own react-semantic-toasts-2 to use toasts in Node 18. Fixing bug where more than the last page was displayed. Upgrading yt-dlp. Fixing sub-folder file selection. Adding rowKey to SortableTable to give React a key for each row. Renaming key to path. Removing duplicate urls. Unifying file modals. Displaying modals for image and text files. Handling refresh loading in FileBrowser. Creating refreshing_directory flag. Removing accidental commit. Sorting by url_count. Using SortableTable on Domains page. Using SortableTable for Channels page. Created new FileBrowser which allows browsing of files in the media directory. Using Node 18 in pi-gen. Creating new FileBrowser to replace outdated react-keyed-file-browser. Returning mimetype with file list. Do not display 'Do not download' on Channel download in Dashboard. Allowing null channel download frequency so user can stop downloading a channel. Bumping version for Node 18. Using my own semantic-ui-offline to avoid pulling Google fonts. Upgrading app docker container to use Node 18. This requires the removal of several npm packages. File browser will require re-write. It now pulls fonts from Google, this will need to be fixed. Testing DownloadsToggle click. Testing trinary states of DownloadsToggle. Installing @testing-library/user-event for testing App.
2023-01-31 18:08:07 -07:00
/* File preview Modal.Actions toolbar.
Single layout that works at every viewport — buttons keep their order at any width.
On narrow screens, the tags selector wraps to its own line while the button groups stay together. */
.preview-toolbar {
display: flex;
flex-wrap: wrap;
align-items: center;
gap: 0.5em;
/* Fill the actions row: `.wrolpi-modal-actions` packs its children to the right, which
is where a confirming button belongs but strands this toolbar. At full width the
toolbar's own layout wins and everything reads from the left. */
flex: 1 1 100%;
}
.preview-toolbar-group {
display: flex;
align-items: center;
gap: 0.25em;
flex: 0 0 auto;
}
.preview-toolbar-tags {
review: close the mixed-unit gaps the scale left behind Seven review comments, all valid. The common thread is the one the guard was supposed to catch and did not: geometry converted to rem beside geometry that stayed px. The guard was narrower than its name. It missed: - `transform`, `flex` and `flex-basis`, so `translateX(26px)` and `flex: 1 1 200px` were invisible on properties nobody thought to list; - every NEGATIVE length, because the lookbehind treated the minus sign as part of the preceding token -- `left: -7px` and `margin-top: -2.5px` position the eyelet on a tag whose diamond HAD been converted, and `right: -3px` / `bottom: -3px` place the corner badge on a converted icon. Each is a piece of geometry that stopped tracking the piece it belongs to. With both fixed it found nine values, including one no comment mentioned (`flex: 1 1 200px`). All nine converted, except the three in a dead `.toggle` / `.slider` block: nothing has referenced those classes since Toggle became a Mantine Switch, and it was ALREADY broken -- track and knob in rem, travel still `translateX(26px)`, so the thumb stopped ~4px short of a 54px track. Dead CSS that is also wrong is a trap for whoever revives it, so it is deleted. The tag eyelet is centred with `translateY(-50%)` rather than a negative margin of half its own height, so the two pieces cannot drift again whatever the scale. Also from the review: - A runtime check, which is what the source guards were missing. Three cases in ui-layout.cy.js measure the real thing: the root font-size is the declared multiple of 16, our text AND a Mantine control both grow by the same factor when the scale changes, and a hairline does not. The second is the one that catches `theme.scale` being set and silently cancelling the root. - `max-height: max(..., 56.25cqw)` now follows a plain rem declaration. An engine without container query units throws out the whole declaration, which would have left the poster with NO cap -- a portrait cover standing as tall as the card is wide. Older engines clamp; newer ones take the second. - `pxToRem` in components/ui/scale.ts, replacing the `/ 16` written out in CardGroup and Placeholder. - The map overlays: 20 values across the layer panel, add-pin dialog, search panel and context menu, whose type had grown 10% while their padding had not. Left in px on purpose: the context menu's `left`/`top` (a real click coordinate), maplibre's own `ScaleControl` maxWidth, and the `calc(100% - 100px)` reserve for maplibre's px-sized controls. The `100vh - 120px` reserve DID become rem, since the chrome it reserves for is ours. - The keyboard-shortcuts spec no longer deletes `.mantine-Notifications-root` from the DOM. The reviewer was right that it is brittle; the endpoints are mocked instead, now that the probe named them: `/api/tag`, `/api/events/feed`, `/api/files/search` and `/api/files/worker_status`. Two of those were already "mocked" as `/api/tags` and `/api/events`, which nothing calls -- the wrong paths were the reason a toast appeared at all. Verified under CI's condition (`forceNetworkError` on everything unmocked): 12 passing with no DOM surgery. What is NOT done, deliberately: about 176 numeric geometry values remain in 23 feature files. The map overlays were the visible ones. Sweeping the rest is a change to 23 files nobody has reviewed, so instead the guard's name now says "in our stylesheets" rather than implying the whole app, and a new ratchet keeps numeric geometry out of the component library so the eleventh inline `gap: 10` cannot be added there. Both new guards planted against. Verified: 1142 jest / 65 suites, 251 ui-layout + 10 modal-stack component tests, all 50 e2e specs, clean build, map overlays measured to track the scale (panel minWidth 200 -> 220, search 320 -> 352) and screenshotted.
2026-08-03 19:37:25 -06:00
/* rem so the basis grows with the tags it holds. */
flex: 1 1 12.5rem;
min-width: 0;
}
/* On a phone the tags selector always gets its own line rather than squeezing in beside
the buttons. 700px is the app's `tablet` breakpoint (`AppMedia` in contexts.js). */
@media (max-width: 699px) {
.preview-toolbar-tags {
flex-basis: 100%;
}
}
/* Caps preview content to fit inside the file-preview Modal.
300px reserves room for pathContent <pre>, Modal.Header, Modal.Actions row,
inner content (e.g. STL dimensions banner), and modal padding.
Use 100dvh so mobile browser chrome (URL bar) is accounted for. */
.preview-fit {
width: 100%;
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
height: calc(100dvh - 18.75rem);
max-height: calc(100dvh - 18.75rem);
min-height: 15rem;
Fixing changes before merge. Moving FilesRefreshButton and DirectoryRefreshButton out of browser file. Moving file fetching tino FileBrowser. Removing sub-folders from Files display when any parent folder is clicked. Using closed captioning for vtt/srt file icon. Using my own react-semantic-toasts-2 to use toasts in Node 18. Fixing bug where more than the last page was displayed. Upgrading yt-dlp. Fixing sub-folder file selection. Adding rowKey to SortableTable to give React a key for each row. Renaming key to path. Removing duplicate urls. Unifying file modals. Displaying modals for image and text files. Handling refresh loading in FileBrowser. Creating refreshing_directory flag. Removing accidental commit. Sorting by url_count. Using SortableTable on Domains page. Using SortableTable for Channels page. Created new FileBrowser which allows browsing of files in the media directory. Using Node 18 in pi-gen. Creating new FileBrowser to replace outdated react-keyed-file-browser. Returning mimetype with file list. Do not display 'Do not download' on Channel download in Dashboard. Allowing null channel download frequency so user can stop downloading a channel. Bumping version for Node 18. Using my own semantic-ui-offline to avoid pulling Google fonts. Upgrading app docker container to use Node 18. This requires the removal of several npm packages. File browser will require re-write. It now pulls fonts from Google, this will need to be fixed. Testing DownloadsToggle click. Testing trinary states of DownloadsToggle. Installing @testing-library/user-event for testing App.
2023-01-31 18:08:07 -07:00
overflow: hidden;
position: relative;
display: flex;
align-items: center;
justify-content: center;
Fixing changes before merge. Moving FilesRefreshButton and DirectoryRefreshButton out of browser file. Moving file fetching tino FileBrowser. Removing sub-folders from Files display when any parent folder is clicked. Using closed captioning for vtt/srt file icon. Using my own react-semantic-toasts-2 to use toasts in Node 18. Fixing bug where more than the last page was displayed. Upgrading yt-dlp. Fixing sub-folder file selection. Adding rowKey to SortableTable to give React a key for each row. Renaming key to path. Removing duplicate urls. Unifying file modals. Displaying modals for image and text files. Handling refresh loading in FileBrowser. Creating refreshing_directory flag. Removing accidental commit. Sorting by url_count. Using SortableTable on Domains page. Using SortableTable for Channels page. Created new FileBrowser which allows browsing of files in the media directory. Using Node 18 in pi-gen. Creating new FileBrowser to replace outdated react-keyed-file-browser. Returning mimetype with file list. Do not display 'Do not download' on Channel download in Dashboard. Allowing null channel download frequency so user can stop downloading a channel. Bumping version for Node 18. Using my own semantic-ui-offline to avoid pulling Google fonts. Upgrading app docker container to use Node 18. This requires the removal of several npm packages. File browser will require re-write. It now pulls fonts from Google, this will need to be fixed. Testing DownloadsToggle click. Testing trinary states of DownloadsToggle. Installing @testing-library/user-event for testing App.
2023-01-31 18:08:07 -07:00
}
/* Fresnel (Media) wraps iframes in a div which would otherwise shrink to the
default iframe size; make it fill the preview so the iframe's 100% works. */
.preview-fit .fresnel-container {
width: 100%;
height: 100%;
}
Fixing changes before merge. Moving FilesRefreshButton and DirectoryRefreshButton out of browser file. Moving file fetching tino FileBrowser. Removing sub-folders from Files display when any parent folder is clicked. Using closed captioning for vtt/srt file icon. Using my own react-semantic-toasts-2 to use toasts in Node 18. Fixing bug where more than the last page was displayed. Upgrading yt-dlp. Fixing sub-folder file selection. Adding rowKey to SortableTable to give React a key for each row. Renaming key to path. Removing duplicate urls. Unifying file modals. Displaying modals for image and text files. Handling refresh loading in FileBrowser. Creating refreshing_directory flag. Removing accidental commit. Sorting by url_count. Using SortableTable on Domains page. Using SortableTable for Channels page. Created new FileBrowser which allows browsing of files in the media directory. Using Node 18 in pi-gen. Creating new FileBrowser to replace outdated react-keyed-file-browser. Returning mimetype with file list. Do not display 'Do not download' on Channel download in Dashboard. Allowing null channel download frequency so user can stop downloading a channel. Bumping version for Node 18. Using my own semantic-ui-offline to avoid pulling Google fonts. Upgrading app docker container to use Node 18. This requires the removal of several npm packages. File browser will require re-write. It now pulls fonts from Google, this will need to be fixed. Testing DownloadsToggle click. Testing trinary states of DownloadsToggle. Installing @testing-library/user-event for testing App.
2023-01-31 18:08:07 -07:00
td.file-path {
cursor: pointer;
}
ui: give tables a real header, drop the column grid, quiet the row rules Three things the file browser made obvious. The header was not a surface. Mantine gives thead no background at all, so the header painted whatever was behind the table -- which is exactly what an unstriped body row paints. Against a striped body it read as one more stripe, and bold type was the only thing distinguishing it. It now carries `--head`, the token that already means "recessed surface", with a full-strength 2px rule under it: the header/body division is the one line in a table that carries meaning, so it is the one allowed to be loud. Column borders are gone. A line around every cell is a lot of ink to repeat what the column headings already say, and it was half of why the header disappeared -- a bordered header cell looks like a cell in a grid. Row rules were `--border`, the same weight as the outline around the table, so a long table read as a stack of boxes. They now use `--table-line`, a new token per theme sitting between the surface and `--border`. The table outline is not a row rule and keeps `--border`; Mantine draws both from `--table-border-color`, so that had to be restated. In the file browser an icon and a filename are inline siblings in one cell. An inline SVG sits on the text baseline, so a 24px glyph beside 13px text hung above it -- the icon looked centred in the row and the name looked like it was resting on the icon's floor. `vertical-align: middle` centres it, and the margin is a gap that was never there at all: the folder icon touched the first letter of its own name. Cypress now loads App.css, as the app does. Without it a spec covering the file browser rows measures a component the app never renders. One jest test and eleven browser tests, each checked red against a planted regression. Two notes for the next person: - `html .mantine-Table-table` is specificity, not decoration. Mantine declares --table-border-color on its own hashed class, which ties with `.mantine-Table-table` and wins on source order. - the "quieter than the outline" test measures both lines against `--panel`. Nothing paints <html> under a mounted component, so measuring against the root background compares them to black, which ranks the *paler* line as the louder one -- the assertion passed backwards until it was pointed at the surface the rules actually sit on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-01 16:46:50 -06:00
/*
* The row is an icon followed by a filename, as inline siblings. An inline SVG
* sits on the text baseline by default, so a 24px glyph next to 13px text hangs
* well above it and the name looks like it is resting on the icon's floor.
* `middle` centres the glyph against the text instead.
*
* The margin is the gap that was never there: the folder icon touched the first
* letter of its own name, and two icons (a folder and its ignored marker) touched
* each other.
*/
td.file-path > svg {
vertical-align: middle;
margin-right: 0.35em;
}
2023-02-15 20:58:07 -07:00
textarea.otp {
width: 100%;
color: #333;
}
.card-icon {
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
min-height: 10.1875rem;
2023-02-15 20:58:07 -07:00
text-align: center;
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
padding-top: 3.3125rem;
2023-02-15 20:58:07 -07:00
}
.clickable {
cursor: pointer;
}
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
/*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* A table that truncates to the width it has rather than growing past it: the columns divide
* the table's width, and `column-ellipsis` gives up what it cannot show. A column that must
* fit something exact states a width on its header cell; the rest is the ellipsis column's.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* `table.`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`
* at the same specificity and later in the cascade, so the bare class loses -- silently, with
* every other property here still applying.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*/
table.table-ellipsis {
width: 100%;
table-layout: fixed;
}
2023-11-02 10:07:49 -06:00
.table-ellipsis td.column-ellipsis {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
}
/*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* Column widths for the downloads tables. Phone first, and the phone is 375px: below the
* breakpoint each column is cut to what it must hold -- its header's longest word, the label
* wrapping, or its buttons -- and the URL takes what is left, which is little. Above it the
* labels get their own line back and the URL gets the rest.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* 700px is the app's `tablet` breakpoint (`AppMedia` in contexts.js). `em` here is the
* table's own font (~15.4px), not the root's.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*/
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
/*
* A header too long for a phone carries both forms and shows one. The short word is what the
* mobile column widths below are sized for; the full words return at the breakpoint.
*/
.table-ellipsis th .label-long {
display: none;
}
@media (min-width: 700px) {
.table-ellipsis th .label-long {
display: inline;
}
.table-ellipsis th .label-short {
display: none;
}
}
.table-ellipsis th.col-select {
/* 22px of checkbox plus 11px of cell padding either side. */
width: 3em;
}
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
.table-ellipsis th.col-frequency {
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
width: 4.2em;
}
.table-ellipsis th.col-completed {
width: 5.5em;
}
.table-ellipsis th.col-completed-plain {
width: 4.2em;
}
.table-ellipsis th.col-next {
width: 3.9em;
}
/* A `ButtonGroup` cannot wrap -- its buttons are joined -- so this holds all three of them
(delete, edit, retry on a failed download) at every width. */
.table-ellipsis th.col-control-group {
width: 9.5em;
}
/* A `.wrolpi-button-row` wraps, so on a phone this holds one button and the second drops
beneath it. It is sized by the word "Control" rather than by the button, which is wider. */
.table-ellipsis th.col-control-row {
width: 5.2em;
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
}
@media (min-width: 700px) {
.table-ellipsis th.col-frequency {
width: 12em;
}
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
.table-ellipsis th.col-completed {
width: 9.5em;
}
.table-ellipsis th.col-completed-plain {
width: 8.5em;
}
.table-ellipsis th.col-next {
width: 4em;
}
.table-ellipsis th.col-control-row {
width: 7.5em;
}
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
}
/*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* A header wraps instead of running into the next column: `.wrolpi-th-sort` is nowrap, which a
* fixed column cannot widen for, so a long label printed over its neighbour.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* `min-width: 0` as well as the wrap -- the label is an anonymous flex item whose automatic
* minimum is its longest word, and without this it still refuses to go below that word. A
* column narrower than its longest word is a width to fix at the call site.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*/
.table-ellipsis th .wrolpi-th-sort {
display: flex;
white-space: normal;
min-width: 0;
text-align: left;
}
/*
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
* A header is clipped rather than painted over its neighbour. Wrapping cannot save a
* single-word label in the elastic column, which may be narrower than the word itself.
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
*/
review: the 375px phone this fix had not been measured on (#662) * review: the 375px phone this fix had not been measured on Answers the five findings on #660. * Recurring's four fixed columns wanted 416px between them, so at 375px the URL column got exactly 0 and the table overflowed again -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s" -- 169-188px measured, against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The Cypress fixtures were a raw <table>, so tableLayout would read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now, and the header check measures the text rather than skipping cells with no element child. * Comments trimmed to what cannot be recovered from the code. Fixing the first surfaced one more: once URL became the small column, its own header overran -- "URL" and its arrow need 72px against 58 -- and a single word cannot wrap. A header is clipped by its column as a last resort. Measured at 375px: once 46/58/123/146, recurring 44/100/104/57/69, nothing overflowing. 69 suites / 1214 jest tests pass. The Cypress tests here are NOT verified: the component runner does not start in this repo (see the separate cypress investigation), so every layout claim above rests on direct measurement in Chrome, not on that suite. * review: the 375px phone this fix had not been measured on Answers the five findings on #660, and now runs against a component suite that can actually execute (#661). * Recurring's four fixed columns wanted 416px between them, so at 375px the URL got exactly 0 and the table overflowed -- the same bug as before, moved down from 540px. Widths are phone-first now, in col-* classes, widening at the tablet breakpoint. * The in-progress button in Completed At carried "5 MBps / 3m44s", 169-188px against 124px of column. It shows the percent; the modal it opens already lists speed, ETA and bytes, and the full text is on the button's title. * The select column was 2.5em: 16.5px of content for a 22px checkbox, which hung into the URL column. 3em holds the checkbox and its padding. * The fixtures were a raw <table>, so tableLayout read 'fixed' even with the selector that loses to Mantine -- the test could not fail for the reason it claimed. They mount SortableTable, Table.HeaderCell onSort and a real Checkbox now. * Comments trimmed to what cannot be recovered from the code. Two defects the restored suite caught, neither of them findable before it ran: * The elastic URL column ends up narrower than its own header -- "URL" and its arrow need 72px against 58 -- and one word cannot wrap, so the column clips. A sized column must fit its label; only the elastic one may clip. That is what the header test asserts, per kind of column, rather than measuring text and calling it the label: the first version measured the text alone, missed the sort arrow, and passed while the button overran by 14px. * Recurring's Control column was 4.5em, 70px of content for a 78px "Control". Sized for the word rather than the button it holds: 5.2em. At 375px: once 46/58/123/146, recurring 33/100/104/57/80, nothing overflowing and no sized header clipped. The URL column there is 33px -- the accepted trade for keeping every column on a phone. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean. * review: a header assertion that stopped at the padding box Three findings on #662. * The sized-header check compared scrollWidth to clientWidth, which is the padding box, so a label could overflow its content box into the padding and pass -- the same class of miss the 4.5em Control failure was meant to close. It measures the label's longest word (plus the sort arrow, where there is one) against the content box now. That found two more columns tuned to their exact limit and clipping by a pixel: Download Frequency wanted 79.4px of a 78.1px box, Completed At 82.3 of 81.9. Every sized column now has margin over its own label. * SortableTable stopped applying `width`, leaving dead keys at the Tags and Zim call sites. Removed, so a column is sized one way. CollectionTable's `width` is NOT dead -- it converts sixteenths to percentages -- so Channels, Docs, Playlists and Archive keep theirs. * Comments trimmed again: the percent button, the header clip, the ButtonGroup rule and the Cypress helper. 336 component tests pass, 69 suites / 1214 jest tests pass. * ui: a phone header short enough to leave room for the URL Five full-length headers do not fit a phone. Sized so each held its own label, the recurring URL column came out 20px -- narrower than one character and its ellipsis, a column present but carrying nothing. A long header carries both forms and `.label-*` shows one: Freq and Done below the tablet breakpoint, Download Frequency and Completed At above it, where there is room. The mobile widths are sized for the short word. At 375px the URL column goes from 20px to 105px on the recurring table and 54px to 97px on the once table. Nothing overflows, nothing clips, and every column stays. 336 component tests pass, 69 suites / 1214 jest tests pass, npm run build is clean.
2026-08-13 11:38:49 -06:00
.table-ellipsis th {
overflow: hidden;
}
/* `ButtonGroup` is a nowrap flex row whose children shrink; `col-control-group` is sized for
the whole group, so the buttons in it must not. */
ui: a downloads table wider than the phone showing it (#660) The two downloads tables came out 676px and 727px in a 540px window, so Completed At and Control sat off the right edge and their buttons could not be reached without scrolling sideways. `.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as wide as its columns want to be and the container simply overflows. The rule leaned on `max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable -- but 25em is 385px, and a floor wider than the screen makes the overflow certain. Fixed layout inverts it: the columns divide the table's width and the column marked `column-ellipsis` gives up what it cannot show. Neither the max-width trick nor the floor is needed then. Columns that must fit something exact -- a checkbox, a group of buttons -- state a width; the rest is the truncating column's. `table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own `.mantine-Table-table`, the same specificity and later in the cascade, so the first version of this lost silently. Every other property in the rule applied, which made the table look fixed while it stayed auto -- the recurring table got *wider* than before, not narrower. Three things the rework then had to answer for, each of them measured in the browser: * A header overran its column: "Completed At" printed on top of "Control", because `.wrolpi-th-sort` is nowrap so a label never splits from its arrow. It wraps here, and needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic minimum is its longest word, so without it the label still refuses to go below "Completed" and still overruns. * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink, and the Stop button on a pending download came out 23px against its neighbour's 40 -- clipped, and too small to hit. The columns are sized for the widest group a row can have, so the buttons no longer give. * Status's Top Processes table had the same bug. It already asked for `.table-ellipsis` and already marked its Command cell, so it overflowed a phone too (548px into 503px). The same rule fixes it, with widths for the three short readings. A wrapped header is the fallback, not the layout, so every column is sized to hold its own label on one line -- including on a phone. "Download Frequency" is the exception at 11.7em, which a phone cannot spare beside four other columns, so it takes a class that widens at the tablet breakpoint and wraps below it. Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button: 540px once 40 / 208 / 146 / 146 recurring 123 / 108 / 131 / 62 / 116 1400px once 40 / 1033 / 146 / 146 recurring 871 / 185 / 131 / 62 / 116 Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At from 291 to 146, so the URL column picks up about 255px. Covered by five tests in the Cypress layout suite. None of this is checkable in jsdom -- it is all resolved widths, and the central question is whether our `table-layout` beats the one Mantine sets, which is exactly the part that failed silently. 69 suites / 1214 jest tests pass.
2026-08-12 10:08:55 -06:00
.table-ellipsis td .mantine-ButtonGroup-group > * {
flex-shrink: 0;
2023-11-02 10:07:49 -06:00
}
.card-title-ellipsis {
display: -webkit-box;
-webkit-line-clamp: 3;
-webkit-box-orient: vertical;
overflow: hidden;
text-overflow: ellipsis;
}
.search-container {
display: flex;
justify-content: flex-start;
}
.search-input {
flex-grow: 1;
}
2024-08-02 11:56:06 -06:00
.video-player {
display: block;
margin: 0 auto; /* Center the video horizontally */
}
.audio-poster-container {
position: relative;
display: block;
text-align: center;
}
.audio-poster-overlay {
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
color: rgba(255, 255, 255, 0.85);
text-shadow: 0 0 20px rgba(0, 0, 0, 0.6);
pointer-events: none;
}
table.ratio-table td.equal-width {
width: 48%;
}
table.ratio-table td.min-width {
width: auto;
}
test: one place for fixtures, real providers instead of mocked context modules Specs had no shared vocabulary for the app's data or its contexts, so each one rebuilt both. A settings object was written out by hand wherever one was needed, twenty-odd keys at a time, and nothing held those copies to each other or to the API. Contexts were worse: to render a consumer a spec mocked the whole context module, which replaces every export including the providers, so each spec reinvented the pieces it still needed. One supplies a `Media` that always reports desktop -- quietly leaving that component's mobile branch untested -- and one hand-writes a context as a bare `_currentValue` with no provider, working only because useContext reads that React internal. test-fixtures.js is now the single definition of both, shared by jest, the Cypress component specs, and e2e intercept bodies, so the three cannot disagree about what the API returns. Every fixture is a function taking overrides; a shared mutable object lets one test change what the next one sees. The drift this prevents was already real. The theme fixture supplied `i`, `s` and `t` holding hardcoded Semantic greys for months after ThemeProvider stopped supplying them, and ThemeContext still declared all four. So the fixture agreed with the tests, and with nothing else: FileBrowser was reading `inverted` off the context and pasting the resulting `undefined` into a className, which is why the file browser's footer -- near-white #f9fafb, with a `.inverted` dark variant that nothing could select any more -- stayed light in dark, night and amber. A white bar pinned to the bottom of the screen in night mode costs the user exactly the dark adaptation the theme exists to protect. It takes tokens now. test-fixtures.test.js holds each fixture to its context's declared shape in both directions, so a property added to one and forgotten in the other fails a test. Two failed attempts are recorded in test-utils.js because both were instructive. Importing Tags.js and FileWorkerStatusContext.js so the harness could supply those providers broke eight suites: it put both into the module graph of every spec ahead of that spec's own mocks, and components bound to a second instance of a mocked module -- a different jest.fn() than the test had configured, so a hook mocked to return a value returned undefined, in a file no test mentions. Requiring them lazily fixed that and not its mirror image: useContext read a different TagsContext than the harness had required, so the provider was ignored and the context default won. A harness must not change what a spec imports, so it owns only contexts/contexts.js and a spec passes any other context itself. DomainTagging is converted off the `_currentValue` fake as proof, and now asserts the tag name a user sees rather than a test id its own mock invented. The five remaining specs are listed in a ratchet so the count can only fall. 974 jest, 15 browser component, 46 e2e, clean cache-busted build, tsc clean. Fixtures are confirmed absent from the shipped bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:30:49 -06:00
/*
* Sticky footer for the file browser.
*
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
* The surface is a token. It was two hardcoded greys with `.inverted` selecting the dark
* one, and once nothing set `.inverted` any more the footer stayed at near-white `#f9fafb`
* in dark, night and amber. In night mode a white bar pinned to the bottom of the screen
* costs the user the dark adaptation the whole theme exists to protect. A token has no
* such failure mode: there is one rule and each theme fills it in.
test: one place for fixtures, real providers instead of mocked context modules Specs had no shared vocabulary for the app's data or its contexts, so each one rebuilt both. A settings object was written out by hand wherever one was needed, twenty-odd keys at a time, and nothing held those copies to each other or to the API. Contexts were worse: to render a consumer a spec mocked the whole context module, which replaces every export including the providers, so each spec reinvented the pieces it still needed. One supplies a `Media` that always reports desktop -- quietly leaving that component's mobile branch untested -- and one hand-writes a context as a bare `_currentValue` with no provider, working only because useContext reads that React internal. test-fixtures.js is now the single definition of both, shared by jest, the Cypress component specs, and e2e intercept bodies, so the three cannot disagree about what the API returns. Every fixture is a function taking overrides; a shared mutable object lets one test change what the next one sees. The drift this prevents was already real. The theme fixture supplied `i`, `s` and `t` holding hardcoded Semantic greys for months after ThemeProvider stopped supplying them, and ThemeContext still declared all four. So the fixture agreed with the tests, and with nothing else: FileBrowser was reading `inverted` off the context and pasting the resulting `undefined` into a className, which is why the file browser's footer -- near-white #f9fafb, with a `.inverted` dark variant that nothing could select any more -- stayed light in dark, night and amber. A white bar pinned to the bottom of the screen in night mode costs the user exactly the dark adaptation the theme exists to protect. It takes tokens now. test-fixtures.test.js holds each fixture to its context's declared shape in both directions, so a property added to one and forgotten in the other fails a test. Two failed attempts are recorded in test-utils.js because both were instructive. Importing Tags.js and FileWorkerStatusContext.js so the harness could supply those providers broke eight suites: it put both into the module graph of every spec ahead of that spec's own mocks, and components bound to a second instance of a mocked module -- a different jest.fn() than the test had configured, so a hook mocked to return a value returned undefined, in a file no test mentions. Requiring them lazily fixed that and not its mirror image: useContext read a different TagsContext than the harness had required, so the provider was ignored and the context default won. A harness must not change what a spec imports, so it owns only contexts/contexts.js and a spec passes any other context itself. DomainTagging is converted off the `_currentValue` fake as proof, and now asserts the tag name a user sees rather than a test id its own mock invented. The five remaining specs are listed in a ratchet so the count can only fall. 974 jest, 15 browser component, 46 e2e, clean cache-busted build, tsc clean. Fixtures are confirmed absent from the shipped bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:30:49 -06:00
*/
.sticky-footer {
position: fixed;
bottom: 0;
left: 0;
right: 0;
padding: 0.5em 1em;
test: one place for fixtures, real providers instead of mocked context modules Specs had no shared vocabulary for the app's data or its contexts, so each one rebuilt both. A settings object was written out by hand wherever one was needed, twenty-odd keys at a time, and nothing held those copies to each other or to the API. Contexts were worse: to render a consumer a spec mocked the whole context module, which replaces every export including the providers, so each spec reinvented the pieces it still needed. One supplies a `Media` that always reports desktop -- quietly leaving that component's mobile branch untested -- and one hand-writes a context as a bare `_currentValue` with no provider, working only because useContext reads that React internal. test-fixtures.js is now the single definition of both, shared by jest, the Cypress component specs, and e2e intercept bodies, so the three cannot disagree about what the API returns. Every fixture is a function taking overrides; a shared mutable object lets one test change what the next one sees. The drift this prevents was already real. The theme fixture supplied `i`, `s` and `t` holding hardcoded Semantic greys for months after ThemeProvider stopped supplying them, and ThemeContext still declared all four. So the fixture agreed with the tests, and with nothing else: FileBrowser was reading `inverted` off the context and pasting the resulting `undefined` into a className, which is why the file browser's footer -- near-white #f9fafb, with a `.inverted` dark variant that nothing could select any more -- stayed light in dark, night and amber. A white bar pinned to the bottom of the screen in night mode costs the user exactly the dark adaptation the theme exists to protect. It takes tokens now. test-fixtures.test.js holds each fixture to its context's declared shape in both directions, so a property added to one and forgotten in the other fails a test. Two failed attempts are recorded in test-utils.js because both were instructive. Importing Tags.js and FileWorkerStatusContext.js so the harness could supply those providers broke eight suites: it put both into the module graph of every spec ahead of that spec's own mocks, and components bound to a second instance of a mocked module -- a different jest.fn() than the test had configured, so a hook mocked to return a value returned undefined, in a file no test mentions. Requiring them lazily fixed that and not its mirror image: useContext read a different TagsContext than the harness had required, so the provider was ignored and the context default won. A harness must not change what a spec imports, so it owns only contexts/contexts.js and a spec passes any other context itself. DomainTagging is converted off the `_currentValue` fake as proof, and now asserts the tag name a user sees rather than a test id its own mock invented. The five remaining specs are listed in a ratchet so the count can only fall. 974 jest, 15 browser component, 46 e2e, clean cache-busted build, tsc clean. Fixtures are confirmed absent from the shipped bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 16:30:49 -06:00
background-color: var(--panel);
border-top: 1px solid var(--border);
z-index: 100;
ui: three button-layout defects, each with a different cause Reported together as "button groups", but they turned out to be three unrelated things. The file browser's footer buttons touched while the Channel Edit page's had gaps. Channel Edit lays its buttons out with Mantine's `Group`, which is a flex row with a gap; the footer is hand-rolled and was a plain block, so its inline-block buttons sat flush -- JSX drops whitespace-only lines, so there was not even a space character between them. The footer is now the flex row every other button group already is, wrapping because it carries eight controls. The Settings config table's Import and Save buttons had off-centre icons while Restore in the same row looked right. Restore is an IconButton -- an ActionIcon, which centres a lone glyph by construction. Import and Save are icon-only Buttons, and an icon on a Button goes into Mantine's `leftSection`, which carries a `margin-inline-end` to hold it off the label. With no label that margin is pure offset: measured at 8px left of centre. An icon with no label is now rendered as the button's content instead, so it centres. `Children.toArray` decides that, because it drops nulls and the file browser passes `{label('Delete')}` -- null whenever the bar is too narrow for words, which is exactly where the offset showed most. The search field's clear button sat inside the field rather than attached to it: the control is a bordered box with `padding: 0 8px`, leaving the button 9px short of the edge and 2px short of the height. Semantic welded it to the field -- measured on the QA Pi at zero gap and full height -- so it now stretches and negative margins cancel the padding and the flex gap. Negative margins rather than dropping the control's padding, because that padding is what holds the search icon and the text off the border; only this one child should escape it. The `html` prefix on that rule is load-bearing: Mantine sets ActionIcon's height from `--ai-size` on its own single class, and at equal specificity the winner is whichever stylesheet loaded last. Fourteen new cases. One correction worth recording: the height assertion first compared against the control's border box and failed on correct behaviour -- the button fills the CONTENT box, and the 1px above and below it is the field's own border, which it should sit inside rather than paint over. Each fix planted separately; the icon change reddens three, the footer one, the clear button one. Every case is paired with an inverse -- a labelled button must keep its icon on the left, and the field must still be padded around its other children. 1128 jest / 63 suites, 226 in ui-layout.cy.js, clean npm run build. Confirmed live: footer gaps 8px on one row, config glyphs at 0.0px from centre, clear button 1px from the field edge at the field's full inner height.
2026-08-02 17:13:28 -06:00
/*
* A row with gaps, like every other group of buttons in the app.
*
* This was a plain block, so the buttons -- inline-block elements with no whitespace
* between them, because JSX drops whitespace-only lines -- sat flush against each other
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
* in one unbroken slab. Everywhere else a group of buttons is a flex row with a gap;
* the file browser's footer is hand-rolled and never got one. It wraps because the bar
* carries eight controls and a phone cannot hold them.
ui: three button-layout defects, each with a different cause Reported together as "button groups", but they turned out to be three unrelated things. The file browser's footer buttons touched while the Channel Edit page's had gaps. Channel Edit lays its buttons out with Mantine's `Group`, which is a flex row with a gap; the footer is hand-rolled and was a plain block, so its inline-block buttons sat flush -- JSX drops whitespace-only lines, so there was not even a space character between them. The footer is now the flex row every other button group already is, wrapping because it carries eight controls. The Settings config table's Import and Save buttons had off-centre icons while Restore in the same row looked right. Restore is an IconButton -- an ActionIcon, which centres a lone glyph by construction. Import and Save are icon-only Buttons, and an icon on a Button goes into Mantine's `leftSection`, which carries a `margin-inline-end` to hold it off the label. With no label that margin is pure offset: measured at 8px left of centre. An icon with no label is now rendered as the button's content instead, so it centres. `Children.toArray` decides that, because it drops nulls and the file browser passes `{label('Delete')}` -- null whenever the bar is too narrow for words, which is exactly where the offset showed most. The search field's clear button sat inside the field rather than attached to it: the control is a bordered box with `padding: 0 8px`, leaving the button 9px short of the edge and 2px short of the height. Semantic welded it to the field -- measured on the QA Pi at zero gap and full height -- so it now stretches and negative margins cancel the padding and the flex gap. Negative margins rather than dropping the control's padding, because that padding is what holds the search icon and the text off the border; only this one child should escape it. The `html` prefix on that rule is load-bearing: Mantine sets ActionIcon's height from `--ai-size` on its own single class, and at equal specificity the winner is whichever stylesheet loaded last. Fourteen new cases. One correction worth recording: the height assertion first compared against the control's border box and failed on correct behaviour -- the button fills the CONTENT box, and the 1px above and below it is the field's own border, which it should sit inside rather than paint over. Each fix planted separately; the icon change reddens three, the footer one, the clear button one. Every case is paired with an inverse -- a labelled button must keep its icon on the left, and the field must still be padded around its other children. 1128 jest / 63 suites, 226 in ui-layout.cy.js, clean npm run build. Confirmed live: footer gaps 8px on one row, config glyphs at 0.0px from centre, clear button 1px from the field edge at the field's full inner height.
2026-08-02 17:13:28 -06:00
*/
display: flex;
align-items: center;
flex-wrap: wrap;
gap: 0.5em;
}
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
/*
* Drag selection visual feedback for FileBrowser: a blue tint over the rows being taken,
* red over the rows being dropped.
*
* Each had a second, stronger rule under `.inverted` for the dark themes. Nothing has set
* that class since ThemeProvider stopped supplying it, so only the light tint has been
* drawn for some time -- and 15% of a fixed blue over a dark row is close to invisible,
* which is the one moment the user needs to see what they have hold of.
*
* A token mixed with transparent instead: the hue follows the theme, and the strength can
* go up without pinning it to a literal that only suits one background.
*/
tr.drag-selecting td {
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
background-color: color-mix(in srgb, var(--blue) 22%, transparent) !important;
}
tr.drag-deselecting td {
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
background-color: color-mix(in srgb, var(--red) 22%, transparent) !important;
}
/* Prevent text selection during drag */
.file-browser-dragging {
user-select: none;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
}
/* Filter input and collapse-all button: right-aligned on desktop, full width on mobile (below). */
.file-browser-filter-container {
display: flex;
justify-content: flex-end;
review: the scan the first two commits needed Five findings, all valid. The substantive one: the video page's Download / Delete / Refresh / AddToPlaylist strip was still four bare buttons in a `<p>` -- the direct analogue of the archive row this PR started with -- and the scan that was supposed to catch exactly that reported the app clean. It only ever saw `{fooButton}` interpolations, and most of the app writes its buttons out in place. Scanning for adjacent button ELEMENTS finds twelve more rows in the same state: reorder icons in the playlist and field-schema tables, both service tables on the controller page, its hotspot Save/QR pair and its Restart/Shutdown pair, the downloads footer, the one-time pad's Generate/Cheat Sheet, and the ration calculator's CSV/Print. All rowed. Two holes had to be closed before that scan could be trusted, because a scan that reports noise is worse than one with a stated limit: - `tagsIn` never captured the tag NAME, so `ROW_COMPONENTS.has(undefined)` was false for every tag and the list of components that lay out their own children -- Group, ButtonGroup, Modal.Actions -- silently accepted none of them. 56 false positives, every modal footer in the app among them. - A row whose style is a const (`style={seasonRowStyle}`) says nothing in its own attributes. Resolved now; the dates selector's seasons row is a four-column grid with a gap and was reported three times. Also from review: the row body is found by walking to the MATCHING close rather than the first `</div>`, which one nested div would have truncated -- and the collection form now nests one, so this was about to matter. Cancel and Save travel together in a row of their own pushed to the end; `margin-left: auto` on Save alone was right for a row that could not wrap, and would now drop Save onto a second line by itself with Cancel left among the action buttons. The doc page's comment no longer implies the picker's 1em separation was not a change. One more found on the way: the file browser's filter row is flex with no gap, and its collapse-all button carried `margin-left: 0.5em` for it. The gap is the container's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 17:06:56 -06:00
/* The gap is the container's. The collapse-all button carried `margin-left: 0.5em` for it,
which is the same thing one element to the right of where it belongs. */
gap: 0.5em;
ui: pages own the space between their blocks Panels shared edges: two 1px borders meeting, which reads as one tall surface with a rule across it rather than a seam between two. Done as `margin-bottom` on the panel first, which is the anti-pattern, and it failed in both of the ways that rule is known to fail before the reading was done. It compounded with the gap of every Stack that already held panels -- four of them, spacing those lists at 35.2px against the app's 17.6px -- and the `:last-child` reset meant to keep trailing space off the bottom of a container silently did nothing, because Media wrapping makes a panel the only child of its own wrapper. On Status that separated four pairs out of five and left the first touching. So the space belongs to whatever stacks the blocks. `.wrolpi-stack` is on PageContainer, which every page uses, and on the three wrappers that stack blocks somewhere the page's own stack cannot reach: Settings' panel wrapper, the block below the video player, and the Zim and Map route wrappers, which hold their tab bar outside PageContainer. A gap rather than `> * + * { margin-top }`, which was tried and is quietly broken here: Media injects `.fresnel-container { margin: 0; padding: 0 }` at runtime, same specificity, later source order, so every wrapped block threw the margin away. A child cannot zero its parent's gap. It also means Media's hidden half contributes nothing, where the owl selector spaced around something invisible. With the page owning the spacing, the blocks that owned some of it had to give it up, or their margin was added to the gap: the tab bar (33px against 17.6 everywhere else), the shared search control bar and paginator on Videos/Archives/Docs/Files, the card grid, the file browser's filter row and the inventory search. Two margins deliberately stay -- the file browser's 4em, which reserves room for the sticky buttons (62645831), and heading margins, which bind a heading to the content below it. Tests plant each of the three failures: the wrapped block, a child that zeroes its own margin, and a hidden Media half. Verified in the browser on sixteen routes and in all four themes -- every stacked pair 17.6px, the map's 85vh box and the video player unchanged, no horizontal overflow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 15:40:27 -06:00
/* No `margin-bottom`: this is a top-level block of the Files page, and the page's stack
spaces it (see `.wrolpi-stack`). Its own 0.5em was added to that. */
}
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
/*
* Double the default input width on desktop.
*
* The selector was `.ui.input.file-browser-filter`, naming a wrapper the old input
* component rendered around the field. Nothing carries `ui input` any more, so this rule
* and the mobile one below it had been matching nothing at all: the filter was rendering
* at the browser's default width on a bar laid out to give it 34em.
*
* The class lands on ActionInput's wrapper, which is the field and its clear button
* together -- that pair is the control being sized, not the text box alone.
*
* Qualified by the container so it carries two classes. `.wrolpi-action-input` sets
* `width: 100%` in ui.css, which is one class like `.file-browser-filter` is, and ui.css
* is loaded after this file -- so a bare class selector here loses the tie and the field
* fills the row anyway. Specificity, not source order, is what should decide it.
*/
.file-browser-filter-container .file-browser-filter {
width: 34em;
max-width: 100%;
}
@media only screen and (max-width: 700px) {
.hide-on-mobile {
display: none !important;
}
.file-browser-filter-container {
justify-content: flex-start;
}
/* Fill the row, but stay on one line with the collapse-all button. */
ui: the last of Semantic UI, in name and in dead CSS The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:15:57 -06:00
.file-browser-filter-container .file-browser-filter {
flex: 1 1 auto;
width: auto;
}
}
Add CSV/PDF export and a search filter to Inventory New Export tab with two client-side formats (no new dependencies): - CSV: the raw items table (RFC-4180 quoting, UTF-8 BOM for Excel), generated entirely in the browser. The download anchor is attached to the DOM and the object URL is revoked on the next tick for cross-browser robustness. - PDF: a printable full-inventory table followed by a group-by summary table, via the browser's print dialog ("Save as PDF"). The summary's grouping is chosen in the Export tab. Search filter: a box on its own line under the inventory selector filters the active inventory across every column's displayed value (case-insensitive; whitespace-separated terms are AND-ed). It narrows the whole view — Items table, Summary aggregation, and Export/PDF — while edits/adds in the table still operate on the full inventory, so filtering never drops data. Summary/export grouping: - The group-by aggregation is extracted into a shared summarize.js (field-role detection + count-aware totals via units.js + calories), now the single source of truth for the Summary tab, the PDF summary, and the ration calculator. findCaloriesKey/findCountKey moved here from RationCalculator (re-exported for back-compat). - The Sum selector now offers number and calories fields in addition to quantity: number/calories are summed as a plain column total, while quantity stays count-aware and unit-compacted and the dedicated Calories column stays count-aware. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 11:00:01 -06:00
/* Inventory "PDF" export: the printable table is hidden on screen and becomes the only
visible content when printing, so a user can use the browser dialog to Save as PDF. */
.inventory-print {
display: none;
}
@media print {
body * {
visibility: hidden;
}
.inventory-print,
.inventory-print * {
visibility: visible;
}
.inventory-print {
display: block;
position: absolute;
top: 0;
left: 0;
width: 100%;
color: #000;
}
.inventory-print h1 {
font-size: 18pt;
margin: 0 0 0.25em;
}
.inventory-print h2 {
font-size: 13pt;
margin: 1.25em 0 0.5em;
}
.inventory-print-meta {
font-size: 9pt;
color: #444;
margin: 0 0 0.75em;
}
.inventory-print table {
width: 100%;
border-collapse: collapse;
font-size: 10pt;
}
.inventory-print th,
.inventory-print td {
border: 1px solid #999;
ui: scale the whole interface by 10%, off the root font-size The interface reads about 10% smaller than the pre-migration Semantic build, and the drift is not one number. Measured on the QA Pi at 1280px, Semantic's headings were h1 28 / h2 24 / h3 18 / h4 15 / h5 14 against our 26 / 21 / 17 / 14 / 13, and its video card a fixed 290px with an 18px title against our 238px with a 13px one -- while our BODY text and chrome went the other way, a 16px base against Semantic's 14 and 42px buttons against 36. No per-component nudge reproduces what a user comparing the two sees, which is the whole page at once. Ten percent is not a fudge factor: our heading scale times 1.1 is 28.6 / 23.1 / 18.7 / 15.4 / 14.3, which is Semantic's scale to within a pixel at every step. Verified in the browser -- those are the numbers it now renders. `--ui-scale: 1.1` and `html { font-size: calc(100% * var(--ui-scale)) }`, with everything that should grow written in rem: - 102 lengths in ui.css, App.css and tokens.css converted, restricted by property: font-size, padding, margin, gap, width/height, border-radius, offsets. - Borders, outlines and shadows deliberately NOT converted. A hairline is a hairline at any text size. - 46 inline `fontSize` px values across 8 files. `em` values were left alone: they already resolve against the parent. - Ten inline-styled blocks in the library (Card's text block, Loading, Placeholder, ColoredInput, Confirm's action row, CardGroup's gap) moved into ui.css, because an inline px size cannot be reached by a scale or seen by a test. - CardGroup converts its `minWidth` prop to rem, which is what returns a phone to one card per row: as px the track ignored the scale, so a 430px screen fitted two 200px cards where the old build fitted one 290px card. Mantine needs nothing: its 644 size declarations are `calc(Xrem * var(--mantine-scale))` and scale with the root. `theme.scale` must stay at 1 -- it exists to CANCEL a customised root font-size, so setting it to 1.1 as well would leave Mantine's half of the interface at the old size beside our larger text. A test pins that. `zoom: 1.1` on the root was tried first and rejected. It works and it is one line, but it scales at paint: every 1px hairline becomes 1.1px and softens on a 1x display, and viewport units do not shrink to compensate, so `100vh` paints 110% of the screen -- a 95vw modal overflowed sideways and the CBZ viewer's fullscreen overflowed down. Rem scales real lengths, keeps borders crisp, leaves viewport units alone, and preserves a user's own browser font-size preference instead of overriding it. A percentage rather than a px root size, for that last reason. Five guards in themes/ui-scale.test.js, each planted against: the scale itself, that every scalable declaration is rem, that borders are NOT, that no inline px font-size survives anywhere including the gallery, and that Mantine's scale stays 1. Also removes `.ui.modal.themed-confirm`, a dead Semantic-era rule and the source of the one `95vw` that would have overflowed: `.ui.modal` no longer exists and nothing sets that class. Verified: 1141 tests / 65 suites; clean build; browser-checked at 1280px and at a 430px phone; navbar single-row from 780 to 1800px; hairlines still 1px and no horizontal overflow in all four themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-03 14:45:08 -06:00
padding: 0.25rem 0.375rem;
Add CSV/PDF export and a search filter to Inventory New Export tab with two client-side formats (no new dependencies): - CSV: the raw items table (RFC-4180 quoting, UTF-8 BOM for Excel), generated entirely in the browser. The download anchor is attached to the DOM and the object URL is revoked on the next tick for cross-browser robustness. - PDF: a printable full-inventory table followed by a group-by summary table, via the browser's print dialog ("Save as PDF"). The summary's grouping is chosen in the Export tab. Search filter: a box on its own line under the inventory selector filters the active inventory across every column's displayed value (case-insensitive; whitespace-separated terms are AND-ed). It narrows the whole view — Items table, Summary aggregation, and Export/PDF — while edits/adds in the table still operate on the full inventory, so filtering never drops data. Summary/export grouping: - The group-by aggregation is extracted into a shared summarize.js (field-role detection + count-aware totals via units.js + calories), now the single source of truth for the Summary tab, the PDF summary, and the ration calculator. findCaloriesKey/findCountKey moved here from RationCalculator (re-exported for back-compat). - The Sum selector now offers number and calories fields in addition to quantity: number/calories are summed as a plain column total, while quantity stays count-aware and unit-compacted and the dedicated Calories column stays count-aware. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 11:00:01 -06:00
text-align: left;
vertical-align: top;
}
/* Repeat the header row at the top of each printed page. */
.inventory-print thead {
display: table-header-group;
}
.inventory-print tr {
page-break-inside: avoid;
}
Add a recommended Food Storage example, a Ration tab, and a supply planner Build on the rebuilt config-only Inventory with three related additions. Recommended example inventory: - A fresh install now seeds the "Food Storage" example with the recommended one-adult / one-year (~3,000 kcal/day) emergency food supply (60 items, ~1.12M kcal), instead of an empty inventory. - The counts are layered on top of the shipped food catalog (single source of per-package nutrition) via RECOMMENDED_ONE_YEAR_FOOD_COUNTS, joined at seed time by recommended_food_storage_items(). - Genericized the two remaining brand names in the catalog defaults (Velveeta -> Processed Cheese, Spam -> Canned Lunch Meat) so both the catalog and the seeded inventory stay brand-free. Ration tab (split out of Summary): - Moved the Ration Estimate (People / Daily Calories / estimate table) out of the increasingly long Summary tab into its own "Ration" tab, shown only for inventories that have a calories field. Supply planner ("Plan More Supply"): - A slider picks a target duration longer than the current estimate; the whole inventory is scaled up proportionally (every item by the same factor, mix kept balanced) into a sortable shopping list of what to buy. - Any split package rounds UP to a whole one (ceil), matching the "1.6 buckets -> buy 1 more" rule. - The shopping list is exportable as CSV (reusing toCSV) and PDF (reusing the print-to-PDF path, scoped via body.printing-shopping so only the list prints -- no inventory or summary). Search filter: - Moved the items search out of the top toolbar (which implied it filtered every tab) into the Items tab, so it clearly narrows Items only; Summary/Ration/Export/print always use the full inventory. Aggregation/role helpers (findNameKey, planSupplyPurchase) live in summarize.js, the single source of truth shared by Summary, export, and the ration views. All new pure functions and UI flows are covered by tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 12:39:58 -06:00
/* The supply-plan shopping list reuses the .inventory-print element styling (h1/table/etc.) but is a separate
printable block. By default (e.g. the Export tab's whole-inventory PDF) it is hidden; it becomes the ONLY
printed block when the supply plan toggles `body.printing-shopping` just before window.print(). */
.shopping-print,
.shopping-print * {
visibility: hidden;
}
.shopping-print {
display: none;
}
body.printing-shopping .inventory-print:not(.shopping-print),
body.printing-shopping .inventory-print:not(.shopping-print) * {
visibility: hidden;
}
body.printing-shopping .inventory-print:not(.shopping-print) {
display: none;
}
body.printing-shopping .shopping-print,
body.printing-shopping .shopping-print * {
visibility: visible;
}
body.printing-shopping .shopping-print {
display: block;
}
Add CSV/PDF export and a search filter to Inventory New Export tab with two client-side formats (no new dependencies): - CSV: the raw items table (RFC-4180 quoting, UTF-8 BOM for Excel), generated entirely in the browser. The download anchor is attached to the DOM and the object URL is revoked on the next tick for cross-browser robustness. - PDF: a printable full-inventory table followed by a group-by summary table, via the browser's print dialog ("Save as PDF"). The summary's grouping is chosen in the Export tab. Search filter: a box on its own line under the inventory selector filters the active inventory across every column's displayed value (case-insensitive; whitespace-separated terms are AND-ed). It narrows the whole view — Items table, Summary aggregation, and Export/PDF — while edits/adds in the table still operate on the full inventory, so filtering never drops data. Summary/export grouping: - The group-by aggregation is extracted into a shared summarize.js (field-role detection + count-aware totals via units.js + calories), now the single source of truth for the Summary tab, the PDF summary, and the ration calculator. findCaloriesKey/findCountKey moved here from RationCalculator (re-exported for back-compat). - The Sum selector now offers number and calories fields in addition to quantity: number/calories are summed as a plain column total, while quantity stays count-aware and unit-compacted and the dedicated Calories column stays count-aware. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 11:00:01 -06:00
}
/* Map popups (POI details and pins) follow the active theme's tokens. */
/* Scoped under .maplibregl-popup to outrank maplibre-gl.css, which loads after this file. */
.maplibregl-popup .maplibregl-popup-content {
background: var(--panel);
color: var(--text);
border: 1px solid var(--border);
border-radius: 0.25rem;
}
.maplibregl-popup .maplibregl-popup-close-button {
color: var(--muted);
}
.maplibregl-popup .maplibregl-popup-close-button:hover {
background: var(--head);
color: var(--text);
}
.maplibregl-popup.maplibregl-popup-anchor-top .maplibregl-popup-tip,
.maplibregl-popup.maplibregl-popup-anchor-top-left .maplibregl-popup-tip,
.maplibregl-popup.maplibregl-popup-anchor-top-right .maplibregl-popup-tip {
border-bottom-color: var(--panel);
}
.maplibregl-popup.maplibregl-popup-anchor-bottom .maplibregl-popup-tip,
.maplibregl-popup.maplibregl-popup-anchor-bottom-left .maplibregl-popup-tip,
.maplibregl-popup.maplibregl-popup-anchor-bottom-right .maplibregl-popup-tip {
border-top-color: var(--panel);
}
.maplibregl-popup.maplibregl-popup-anchor-left .maplibregl-popup-tip {
border-right-color: var(--panel);
}
.maplibregl-popup.maplibregl-popup-anchor-right .maplibregl-popup-tip {
border-left-color: var(--panel);
}