mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-22 07:56:18 -05:00
79 lines
3.6 KiB
JavaScript
79 lines
3.6 KiB
JavaScript
|
|
import fs from 'fs';
|
||
|
|
import path from 'path';
|
||
|
|
|
||
|
|
/*
|
||
|
|
* The map pin table's action cells.
|
||
|
|
*
|
||
|
|
* Each row offers edit, add-to-playlist and delete, and they were laid out as bare siblings in
|
||
|
|
* a table cell. That makes them inline-block boxes aligned on their text BASELINES, and a
|
||
|
|
* Button's baseline is not an ActionIcon's -- measured on the running app, the middle control
|
||
|
|
* sat 4.3px above the other two -- and they touched, because JSX leaves no whitespace between
|
||
|
|
* elements. `Group` is what every other row of buttons in the app uses.
|
||
|
|
*
|
||
|
|
* Checked in the source because neither row is reachable from a test that could measure it:
|
||
|
|
* `MapPins` fetches its pins from the API and builds its rows through SortableTable, and the
|
||
|
|
* row builders are internal to the module. ui-layout.cy.js measures the pattern itself --
|
||
|
|
* that bare siblings really are misaligned and that a Group really does fix it -- so what is
|
||
|
|
* left to guard is that these cells use one.
|
||
|
|
*/
|
||
|
|
|
||
|
|
const source = fs.readFileSync(path.join(__dirname, 'Map.js'), 'utf8');
|
||
|
|
|
||
|
|
/** The contents of every `<Table.Cell>` in the file. */
|
||
|
|
const cells = () => {
|
||
|
|
const found = [];
|
||
|
|
const open = '<Table.Cell';
|
||
|
|
for (let at = source.indexOf(open); at !== -1; at = source.indexOf(open, at + 1)) {
|
||
|
|
const end = source.indexOf('</Table.Cell>', at);
|
||
|
|
if (end !== -1) found.push(source.slice(at, end));
|
||
|
|
}
|
||
|
|
return found;
|
||
|
|
};
|
||
|
|
|
||
|
|
describe('the map pin action cells', () => {
|
||
|
|
it('finds the cells at all', () => {
|
||
|
|
// The premise. A parser that matched nothing would report no offenders and read
|
||
|
|
// exactly like a file that was already correct.
|
||
|
|
expect(cells().length).toBeGreaterThan(5);
|
||
|
|
});
|
||
|
|
|
||
|
|
/*
|
||
|
|
* Named cells, not a count of control tags.
|
||
|
|
*
|
||
|
|
* Counting was tried first and does not work: a cell whose buttons are the two arms of a
|
||
|
|
* ternary renders exactly one of them and needs no Group -- the "Built" / "Build" cell on
|
||
|
|
* the map files table is that shape -- and excluding ternaries to allow for it also
|
||
|
|
* excluded the subscribe cell, whose `role={isSubscribed ? ... : ...}` has nothing to do
|
||
|
|
* with how many controls it holds. A guard that quietly stops covering a cell is worse
|
||
|
|
* than one with a stated scope.
|
||
|
|
*
|
||
|
|
* So each cell is named by something only it contains, and the general claim -- that bare
|
||
|
|
* inline controls really are misaligned and that a Group really does fix it -- is measured
|
||
|
|
* in ui-layout.cy.js instead.
|
||
|
|
*/
|
||
|
|
const rows = [
|
||
|
|
{name: 'pin actions', marker: 'setEditingId(pin.id)'},
|
||
|
|
/*
|
||
|
|
* `role='cancel'`, not `onSave(...)`: the edit row's TextInput calls onSave from its
|
||
|
|
* own onKeyDown, in a different cell, so that marker matched the input's cell and this
|
||
|
|
* quietly checked the wrong one. A marker has to be unique to the cell it names.
|
||
|
|
*/
|
||
|
|
{name: 'pin edit save/cancel', marker: "role='cancel'"},
|
||
|
|
{name: 'map file subscribe', marker: 'setPreviewOpen(true)'},
|
||
|
|
];
|
||
|
|
|
||
|
|
rows.forEach(({name, marker}) => {
|
||
|
|
it(`groups the ${name} cell`, () => {
|
||
|
|
const cell = cells().find(candidate => candidate.includes(marker));
|
||
|
|
|
||
|
|
/*
|
||
|
|
* The premise and the claim in one object, because jest's `expect` takes no
|
||
|
|
* message argument -- that is chai, and passing one throws rather than annotating.
|
||
|
|
* A rename of the marker would otherwise turn this into a test of nothing.
|
||
|
|
*/
|
||
|
|
expect({marker, found: cell !== undefined, grouped: !!cell?.includes('<Group')})
|
||
|
|
.toEqual({marker, found: true, grouped: true});
|
||
|
|
});
|
||
|
|
});
|
||
|
|
});
|