2025-10-29 22:16:33 -06:00
|
|
|
import React from 'react';
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
import {act, render, screen, waitFor} from '../test-utils';
|
2025-10-29 22:16:33 -06:00
|
|
|
import userEvent from '@testing-library/user-event';
|
ui: fix search suggestion selection, rendering, and clipping
Three findings from review and CI on the Common.js migration, all real.
Selecting a suggestion navigated nowhere. Semantic handed its callers
`{result}` and every caller destructures that shape, so passing the bare result
left `result.location` undefined -- the search suggestions and the Ctrl+K modal
both stopped navigating. The shape stays until the call sites can change
together. (Greptile P1.)
Suggestions lost their custom markup. Callers pass `resultRenderer` to draw a
tag as a chip rather than a line of text, and the migrated wrapper forwarded it
into a div's props instead of to SearchBox, so every suggestion fell back to the
generic title and description. SearchBox takes it now. (Greptile P2.)
The suggestion list clipped its last group. A cypress spec caught it: with
directories, channels and domains all present, the content runs past the 320px
cap and the final row was cut off. Eight grouped suggestions is an ordinary
result set, so the cap was simply too low; it is viewport-relative now and
still bounded.
Both regressions are pinned by tests -- one asserting the callback shape a
caller actually destructures, one asserting the custom renderer replaces the
default markup rather than wrapping it.
2026-07-30 11:28:17 -06:00
|
|
|
import {DirectorySearch, SearchResultsInput} from './Common';
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
// Mock debounce to make tests run faster
|
|
|
|
|
jest.mock('lodash/debounce', () => jest.fn(fn => {
|
|
|
|
|
fn.cancel = jest.fn();
|
|
|
|
|
return fn;
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
// Mock useSearchDirectories hook to avoid async state updates that cause act() warnings
|
|
|
|
|
const mockSetDirectoryName = jest.fn();
|
|
|
|
|
let mockHookState = {
|
|
|
|
|
directoryName: '',
|
|
|
|
|
directories: [],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: false,
|
|
|
|
|
loading: false,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
jest.mock('../hooks/customHooks', () => ({
|
|
|
|
|
...jest.requireActual('../hooks/customHooks'),
|
|
|
|
|
useSearchDirectories: (value) => {
|
|
|
|
|
// Return current mock state - tests control state via setMockHookState
|
|
|
|
|
return {
|
|
|
|
|
...mockHookState,
|
|
|
|
|
setDirectoryName: (newValue) => {
|
|
|
|
|
mockHookState.directoryName = newValue;
|
|
|
|
|
mockSetDirectoryName(newValue);
|
|
|
|
|
},
|
|
|
|
|
};
|
|
|
|
|
},
|
|
|
|
|
}));
|
|
|
|
|
|
|
|
|
|
describe('DirectorySearch', () => {
|
|
|
|
|
const mockOnSelect = jest.fn();
|
|
|
|
|
|
|
|
|
|
const mockSearchResults = {
|
|
|
|
|
directories: [
|
|
|
|
|
{path: 'videos/nature'},
|
|
|
|
|
{path: 'videos/tech'}
|
|
|
|
|
],
|
|
|
|
|
channelDirectories: [
|
|
|
|
|
{path: 'videos/channels/news', name: 'News Channel'}
|
|
|
|
|
],
|
|
|
|
|
domainDirectories: [
|
|
|
|
|
{path: 'archive/example.com', domain: 'example.com'}
|
|
|
|
|
],
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Helper to reset mock hook state with specific values
|
|
|
|
|
const setMockHookState = (overrides = {}) => {
|
|
|
|
|
mockHookState = {
|
|
|
|
|
directoryName: '',
|
|
|
|
|
directories: [],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: false,
|
|
|
|
|
loading: false,
|
|
|
|
|
...overrides,
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
jest.clearAllMocks();
|
|
|
|
|
// Reset mock hook state with default search results
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
isDir: false,
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('Rendering', () => {
|
|
|
|
|
it('renders with placeholder text', () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
expect(input).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('shows initial value when provided', () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
directoryName: 'videos/test',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value="videos/test"/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByDisplayValue('videos/test');
|
|
|
|
|
expect(input).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('applies disabled state correctly', () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value="" disabled/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
expect(input).toBeDisabled();
|
|
|
|
|
});
|
|
|
|
|
|
2026-06-24 15:23:32 -06:00
|
|
|
it('renders the dropdown without crashing when directoryName is null', async () => {
|
|
|
|
|
// An unset form field (e.g. the new Channel page) passes a null value. With
|
|
|
|
|
// isDir=false a "New Directory" result is built from directoryName; if that title is
|
|
|
|
|
// null, Semantic UI's Search crashes reading null.length when the menu opens.
|
|
|
|
|
setMockHookState({
|
|
|
|
|
directories: [],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: false,
|
|
|
|
|
directoryName: null,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value={null}/>);
|
|
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
// Opening the menu (as Tab/focus does in the browser) must not throw.
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
expect(screen.getByText(/New Directory/i)).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2025-10-29 22:16:33 -06:00
|
|
|
it('displays with required indicator', () => {
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
render(
|
2025-12-06 14:49:46 -07:00
|
|
|
<DirectorySearch onSelect={mockOnSelect} value="" required/>
|
2025-10-29 22:16:33 -06:00
|
|
|
);
|
|
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
// Unlike Semantic UI's Search, the SearchBox forwards `required` straight
|
|
|
|
|
// onto the input.
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
expect(input).toBeRequired();
|
2025-10-29 22:16:33 -06:00
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('Search Functionality', () => {
|
|
|
|
|
it('triggers setDirectoryName on value change', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.type(input, 'videos');
|
|
|
|
|
|
|
|
|
|
// Verify setDirectoryName was called (via mocked hook)
|
|
|
|
|
expect(mockSetDirectoryName).toHaveBeenCalled();
|
|
|
|
|
// Debounce is mocked, so each character triggers a call
|
|
|
|
|
// Verify it was called 6 times (one per character in "videos")
|
|
|
|
|
expect(mockSetDirectoryName.mock.calls.length).toBe(6);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('shows loading indicator when loading state is true', () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
loading: true,
|
|
|
|
|
});
|
|
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
const {container} = render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
// SearchBox renders a Loader alongside the input while `loading` is true.
|
|
|
|
|
expect(container.querySelector('.wrolpi-searchbox-loading')).toBeInTheDocument();
|
2025-10-29 22:16:33 -06:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('hides loading indicator when loading state is false', () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
loading: false,
|
|
|
|
|
});
|
|
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
const {container} = render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
expect(container.querySelector('.wrolpi-searchbox-loading')).not.toBeInTheDocument();
|
2025-10-29 22:16:33 -06:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('displays categorized results', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
// Click to open dropdown
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
// Should show category names
|
|
|
|
|
expect(screen.getAllByText(/Directories/i).length).toBeGreaterThan(0);
|
|
|
|
|
expect(screen.getAllByText(/Channels/i).length).toBeGreaterThan(0);
|
|
|
|
|
expect(screen.getAllByText(/Domains/i).length).toBeGreaterThan(0);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('shows "New Directory" when path doesn\'t exist (isDir=false)', async () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
directories: [],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: false,
|
|
|
|
|
directoryName: 'new/path',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
expect(screen.getByText(/New Directory/i)).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('hides "New Directory" when path exists (isDir=true)', async () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
directories: [{path: 'videos/nature/wildlife'}],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: true,
|
|
|
|
|
directoryName: 'videos/nature',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
// "New Directory" should not appear when is_dir=true
|
|
|
|
|
expect(screen.queryByText(/New Directory/i)).not.toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('debounces rapid typing (verifies setDirectoryName is called)', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
|
|
|
|
|
// Type rapidly
|
|
|
|
|
await userEvent.type(input, 'abc', {delay: 10});
|
|
|
|
|
|
|
|
|
|
// Verify setDirectoryName was called
|
|
|
|
|
expect(mockSetDirectoryName).toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('User Interactions', () => {
|
|
|
|
|
it('calls onSelect when result is clicked', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
expect(screen.getByText('videos/nature')).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Click on a result
|
|
|
|
|
const result = screen.getByText('videos/nature');
|
|
|
|
|
await userEvent.click(result);
|
|
|
|
|
|
|
|
|
|
expect(mockOnSelect).toHaveBeenCalledWith('videos/nature');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('commits typed value on blur when directoryName differs from value', async () => {
|
|
|
|
|
// Set up mock state where directoryName differs from the prop value
|
|
|
|
|
// This simulates what happens after user types in the input
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
directoryName: 'typed/path', // User has typed this
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Render with empty value prop (different from directoryName)
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
// The SearchBox wires `onBlur` straight to the input (there is no longer a
|
|
|
|
|
// wrapping Search component to blur instead).
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
// Blur the input - should trigger onBlur which calls onSelect
|
2025-10-29 22:16:33 -06:00
|
|
|
await act(async () => {
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
const {fireEvent} = require('../test-utils');
|
|
|
|
|
fireEvent.blur(input);
|
2025-10-29 22:16:33 -06:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Should call onSelect with directoryName from hook state
|
|
|
|
|
expect(mockOnSelect).toHaveBeenCalledWith('typed/path');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('does not call onSelect on blur if value unchanged', async () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
directoryName: 'existing/path',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value="existing/path"/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByDisplayValue('existing/path');
|
|
|
|
|
|
|
|
|
|
// Blur without changing value
|
|
|
|
|
await act(async () => {
|
|
|
|
|
input.blur();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Should not call onSelect since value didn't change
|
|
|
|
|
expect(mockOnSelect).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('disabled state prevents interactions', () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value="" disabled/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
|
|
|
|
|
// Input should be disabled
|
|
|
|
|
expect(input).toBeDisabled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('handles rapid selection changes', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
expect(screen.getByText('videos/nature')).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
// Click multiple results in succession. Choosing a result closes the
|
|
|
|
|
// dropdown (as any combobox would) without moving focus off the input
|
|
|
|
|
// (the option is chosen on mousedown, with the default prevented), so
|
|
|
|
|
// pressing a key that reopens the list -- same as a real user -- is
|
|
|
|
|
// needed before the next selection.
|
2025-10-29 22:16:33 -06:00
|
|
|
await userEvent.click(screen.getByText('videos/nature'));
|
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
2026-07-30 10:00:48 -06:00
|
|
|
await userEvent.keyboard('{ArrowDown}');
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
expect(screen.getByText('videos/tech')).toBeInTheDocument();
|
|
|
|
|
});
|
2025-10-29 22:16:33 -06:00
|
|
|
await userEvent.click(screen.getByText('videos/tech'));
|
|
|
|
|
|
|
|
|
|
// Should call onSelect for each selection
|
|
|
|
|
expect(mockOnSelect).toHaveBeenCalledWith('videos/nature');
|
|
|
|
|
expect(mockOnSelect).toHaveBeenCalledWith('videos/tech');
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('Hook Integration', () => {
|
|
|
|
|
it('calls setDirectoryName from hook on search change', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.type(input, 'archive');
|
|
|
|
|
|
|
|
|
|
expect(mockSetDirectoryName).toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('displays results from hook state', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
await waitFor(() => {
|
|
|
|
|
// Should display results from mock hook state
|
|
|
|
|
expect(screen.getByText('videos/nature')).toBeInTheDocument();
|
|
|
|
|
expect(screen.getByText('videos/tech')).toBeInTheDocument();
|
|
|
|
|
expect(screen.getByText('News Channel')).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe('Edge Cases', () => {
|
2025-12-05 18:26:36 -07:00
|
|
|
it('renders without error when directories are null (initial state)', async () => {
|
|
|
|
|
// Simulate the initial state before API call completes
|
|
|
|
|
setMockHookState({
|
|
|
|
|
directories: null,
|
|
|
|
|
channelDirectories: null,
|
|
|
|
|
domainDirectories: null,
|
|
|
|
|
isDir: false,
|
|
|
|
|
directoryName: '',
|
|
|
|
|
loading: true,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// This should not throw an error
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-12-05 18:26:36 -07:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
|
|
|
|
|
// Clicking input should not throw "Cannot read properties of null"
|
|
|
|
|
await userEvent.click(input);
|
|
|
|
|
|
|
|
|
|
// Component should still be rendered
|
|
|
|
|
expect(input).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
2025-10-29 22:16:33 -06:00
|
|
|
it('handles null/undefined initial value', () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
directoryName: '',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value={null}/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
expect(input).toHaveValue('');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('clears results display when empty', async () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
directories: [],
|
|
|
|
|
channelDirectories: [],
|
|
|
|
|
domainDirectories: [],
|
|
|
|
|
isDir: false,
|
|
|
|
|
directoryName: '',
|
|
|
|
|
});
|
|
|
|
|
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
expect(input).toHaveValue('');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('maintains value when component remounts', () => {
|
|
|
|
|
setMockHookState({
|
|
|
|
|
...mockSearchResults,
|
|
|
|
|
directoryName: 'videos/test',
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const {rerender} = render(
|
2025-12-06 14:49:46 -07:00
|
|
|
<DirectorySearch onSelect={mockOnSelect} value="videos/test"/>
|
2025-10-29 22:16:33 -06:00
|
|
|
);
|
|
|
|
|
|
|
|
|
|
expect(screen.getByDisplayValue('videos/test')).toBeInTheDocument();
|
|
|
|
|
|
|
|
|
|
// Remount with same value
|
2025-12-06 14:49:46 -07:00
|
|
|
rerender(<DirectorySearch onSelect={mockOnSelect} value="videos/test"/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
expect(screen.getByDisplayValue('videos/test')).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('handles special characters in path', async () => {
|
2025-12-06 14:49:46 -07:00
|
|
|
render(<DirectorySearch onSelect={mockOnSelect} value=""/>);
|
2025-10-29 22:16:33 -06:00
|
|
|
|
|
|
|
|
const input = screen.getByPlaceholderText(/search directory names/i);
|
|
|
|
|
|
|
|
|
|
// Type path with special characters
|
|
|
|
|
const specialPath = 'videos/test-folder_2024/v1.0';
|
|
|
|
|
await userEvent.type(input, specialPath);
|
|
|
|
|
|
|
|
|
|
expect(mockSetDirectoryName).toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
});
|
ui: fix search suggestion selection, rendering, and clipping
Three findings from review and CI on the Common.js migration, all real.
Selecting a suggestion navigated nowhere. Semantic handed its callers
`{result}` and every caller destructures that shape, so passing the bare result
left `result.location` undefined -- the search suggestions and the Ctrl+K modal
both stopped navigating. The shape stays until the call sites can change
together. (Greptile P1.)
Suggestions lost their custom markup. Callers pass `resultRenderer` to draw a
tag as a chip rather than a line of text, and the migrated wrapper forwarded it
into a div's props instead of to SearchBox, so every suggestion fell back to the
generic title and description. SearchBox takes it now. (Greptile P2.)
The suggestion list clipped its last group. A cypress spec caught it: with
directories, channels and domains all present, the content runs past the 320px
cap and the final row was cut off. Eight grouped suggestions is an ordinary
result set, so the cap was simply too low; it is viewport-relative now and
still bounded.
Both regressions are pinned by tests -- one asserting the callback shape a
caller actually destructures, one asserting the custom renderer replaces the
default markup rather than wrapping it.
2026-07-30 11:28:17 -06:00
|
|
|
|
|
|
|
|
describe('SearchResultsInput', () => {
|
|
|
|
|
const results = {
|
|
|
|
|
tags: {name: 'Tags', results: [{type: 'tag', title: 'Cooking'}]},
|
|
|
|
|
videos: {name: 'Videos', results: [
|
|
|
|
|
{title: 'How To Sharpen An Axe', description: 'Wranglerstar', location: '/videos/1'},
|
|
|
|
|
]},
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
it('hands the selected suggestion to its caller as {result}', async () => {
|
|
|
|
|
/*
|
|
|
|
|
* Regression: the migration passed the bare result, but every caller destructures
|
|
|
|
|
* `{result}` (see Search.js), so `result.location` was undefined and clicking a
|
|
|
|
|
* search suggestion navigated nowhere.
|
|
|
|
|
*/
|
|
|
|
|
const handleResultSelect = jest.fn();
|
|
|
|
|
render(<SearchResultsInput searchStr='axe' onSubmit={jest.fn()} results={results}
|
|
|
|
|
handleResultSelect={handleResultSelect}/>);
|
|
|
|
|
|
|
|
|
|
await userEvent.click(screen.getByRole('combobox'));
|
|
|
|
|
await userEvent.click(screen.getByText('How To Sharpen An Axe'));
|
|
|
|
|
|
|
|
|
|
expect(handleResultSelect).toHaveBeenCalledWith(
|
|
|
|
|
{result: expect.objectContaining({location: '/videos/1'})});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('forwards resultRenderer so a caller keeps its own suggestion markup', async () => {
|
|
|
|
|
// Search.js renders a tag suggestion as a tag chip, not a line of text.
|
|
|
|
|
const resultRenderer = (result) => <span>rendered:{result.title}</span>;
|
|
|
|
|
render(<SearchResultsInput searchStr='cook' onSubmit={jest.fn()} results={results}
|
|
|
|
|
handleResultSelect={jest.fn()} resultRenderer={resultRenderer}/>);
|
|
|
|
|
|
|
|
|
|
await userEvent.click(screen.getByRole('combobox'));
|
|
|
|
|
|
|
|
|
|
expect(screen.getByText('rendered:Cooking')).toBeInTheDocument();
|
|
|
|
|
});
|
|
|
|
|
});
|