mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-20 23:16:17 -05:00
ui: the last of Semantic UI, in name and in dead CSS
The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
e18752825f
commit
048fea07ca
58 changed files with 387 additions and 618 deletions
|
|
@ -110,7 +110,7 @@ describe('DirectorySearch', () => {
|
|||
it('renders the dropdown without crashing when directoryName is null', async () => {
|
||||
// An unset form field (e.g. the new Channel page) passes a null value. With
|
||||
// isDir=false a "New Directory" result is built from directoryName; if that title is
|
||||
// null, Semantic UI's Search crashes reading null.length when the menu opens.
|
||||
// null, the old Search crashed reading null.length when the menu opened.
|
||||
setMockHookState({
|
||||
directories: [],
|
||||
channelDirectories: [],
|
||||
|
|
@ -135,7 +135,7 @@ describe('DirectorySearch', () => {
|
|||
<DirectorySearch onSelect={mockOnSelect} value="" required/>
|
||||
);
|
||||
|
||||
// Unlike Semantic UI's Search, the SearchBox forwards `required` straight
|
||||
// Unlike the old Search, the SearchBox forwards `required` straight
|
||||
// onto the input.
|
||||
const input = screen.getByPlaceholderText(/search directory names/i);
|
||||
expect(input).toBeRequired();
|
||||
|
|
@ -495,7 +495,7 @@ describe('contrastingColor', () => {
|
|||
*/
|
||||
|
||||
it('picks whichever of the two options actually reads better', () => {
|
||||
// Semantic's blue. The old threshold check chose light text here, at 2.9:1, when dark
|
||||
// The palette blue. The old threshold check chose light text here, at 2.9:1, when dark
|
||||
// text on the same fill gives 5.3:1 -- the worse of the only two available answers.
|
||||
// Every mid-tone blue, teal and purple a user might choose sat in that band.
|
||||
const blue = '#2185d0';
|
||||
|
|
@ -781,7 +781,7 @@ describe('PageContainer', () => {
|
|||
|
||||
describe('a row of buttons', () => {
|
||||
/*
|
||||
* Semantic's Button brought `margin: 0 .25em .25em 0` with it, so a page could list buttons as
|
||||
* Buttons used to bring `margin: 0 .25em .25em 0` with them, so a page could list buttons as
|
||||
* bare siblings and they arrived both spaced and, when the row wrapped, separated. Nothing
|
||||
* replaced that margin. The archive page's six actions shared edges, and two of them carried
|
||||
* `marginTop: 0.5em` -- put there to keep a wrapped row from touching vertically, which instead
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue