mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
ui: the last of Semantic UI, in name and in dead CSS
The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
e18752825f
commit
048fea07ca
58 changed files with 387 additions and 618 deletions
|
|
@ -5,10 +5,9 @@ import {Icon} from './Icon';
|
|||
/*
|
||||
* Buttons.
|
||||
*
|
||||
* Roles carry meaning (Semantic UI heritage): blue = primary/download,
|
||||
* green = save/confirm, red = destructive, amber = retry/warning, neutral
|
||||
* outline = cancel. Prefer `role` over naming a color, so a theme that remaps
|
||||
* a color keeps the meaning.
|
||||
* Roles carry meaning: blue = primary/download, green = save/confirm,
|
||||
* red = destructive, amber = retry/warning, neutral outline = cancel. Prefer
|
||||
* `role` over naming a color, so a theme that remaps a color keeps the meaning.
|
||||
*/
|
||||
|
||||
export type ButtonRole = 'primary' | 'save' | 'retry' | 'danger' | 'cancel';
|
||||
|
|
@ -25,7 +24,7 @@ const roleProps: Record<ButtonRole, {color?: string; variant: string; className?
|
|||
|
||||
export interface ButtonProps extends Omit<MButtonProps, 'leftSection' | 'rightSection'> {
|
||||
role?: ButtonRole;
|
||||
/** Semantic icon name or a Tabler component, rendered before the label. */
|
||||
/** An icon name (see Icon.tsx) or a Tabler component, rendered before the label. */
|
||||
icon?: string | React.ComponentType<any>;
|
||||
iconAfter?: string | React.ComponentType<any>;
|
||||
onClick?: React.MouseEventHandler<HTMLButtonElement>;
|
||||
|
|
@ -41,14 +40,15 @@ const renderIcon = (icon?: string | React.ComponentType<any>) => {
|
|||
}
|
||||
|
||||
/*
|
||||
* Semantic's size names, mapped onto Mantine's scale.
|
||||
* WROLPi's size names, mapped onto Mantine's scale.
|
||||
*
|
||||
* Unmigrated call sites still pass `size='tiny'`, and Mantine silently ignores a
|
||||
* size it does not know — the button renders at the default size and nobody sees
|
||||
* a warning. Translating here keeps those call sites looking right until they
|
||||
* migrate, and costs nothing once they have.
|
||||
* Call sites across the app say `size='tiny'` or `size='huge'`, and Mantine silently
|
||||
* ignores a size it does not know — the button renders at the default size, with no
|
||||
* warning and nothing on screen to say a size was asked for at all. One table here
|
||||
* is cheaper and safer than rewriting the size on several hundred call sites, and it
|
||||
* keeps the vocabulary the rest of the app already reads in.
|
||||
*/
|
||||
const semanticSizes: Record<string, string> = {
|
||||
const sizeAliases: Record<string, string> = {
|
||||
mini: 'xs',
|
||||
tiny: 'xs',
|
||||
small: 'sm',
|
||||
|
|
@ -60,9 +60,9 @@ const semanticSizes: Record<string, string> = {
|
|||
};
|
||||
|
||||
// Generic so it passes each component's own size type straight through; only a
|
||||
// string that Semantic knew about is rewritten.
|
||||
// string in the table above is rewritten.
|
||||
export const resolveSize = <T, >(size: T): T =>
|
||||
typeof size === 'string' ? ((semanticSizes[size] ?? size) as T) : size;
|
||||
typeof size === 'string' ? ((sizeAliases[size] ?? size) as T) : size;
|
||||
|
||||
export const Button = forwardRef<HTMLButtonElement, ButtonProps>((
|
||||
{role, icon, iconAfter, className, children, ...props}, ref
|
||||
|
|
@ -105,9 +105,8 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>((
|
|||
ref={ref}
|
||||
/*
|
||||
* An `href` makes this an anchor. Mantine needs `component='a'` to render one, and
|
||||
* without it the href is accepted and silently dropped — the control looks like a
|
||||
* link and navigates nowhere. Semantic used `as='a'` for this, so every migrated
|
||||
* call site that carried `href` alone was quietly broken.
|
||||
* without it the href is accepted and silently dropped, so a call site carrying
|
||||
* `href` alone renders a control that looks like a link and navigates nowhere.
|
||||
*/
|
||||
component={props.component ?? (props.href ? 'a' : undefined)}
|
||||
// An explicit color/variant still wins, so a call site can deviate when it must.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue