ui: a downloads table wider than the phone showing it (#660)
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Controller Tests / controller-tests (push) Waiting to run
Jest Tests / jest-tests (push) Waiting to run

The two downloads tables came out 676px and 727px in a 540px window, so Completed At and
Control sat off the right edge and their buttons could not be reached without scrolling
sideways.

`.table-ellipsis` was trying to truncate under `table-layout: auto`, where a table is as
wide as its columns want to be and the container simply overflows.  The rule leaned on
`max-width: 0` to force an ellipsis and `min-width: 25em` to keep the text column readable
-- but 25em is 385px, and a floor wider than the screen makes the overflow certain.

Fixed layout inverts it: the columns divide the table's width and the column marked
`column-ellipsis` gives up what it cannot show.  Neither the max-width trick nor the floor
is needed then.  Columns that must fit something exact -- a checkbox, a group of buttons --
state a width; the rest is the truncating column's.

`table.table-ellipsis`, not the bare class: Mantine sets `table-layout` on its own
`.mantine-Table-table`, the same specificity and later in the cascade, so the first version
of this lost silently.  Every other property in the rule applied, which made the table look
fixed while it stayed auto -- the recurring table got *wider* than before, not narrower.

Three things the rework then had to answer for, each of them measured in the browser:

  * A header overran its column: "Completed At" printed on top of "Control", because
    `.wrolpi-th-sort` is nowrap so a label never splits from its arrow.  It wraps here, and
    needs `min-width: 0` as well -- the label is an anonymous flex item whose automatic
    minimum is its longest word, so without it the label still refuses to go below
    "Completed" and still overruns.

  * A grouped button was squeezed: `ButtonGroup` is a nowrap flex row whose children shrink,
    and the Stop button on a pending download came out 23px against its neighbour's 40 --
    clipped, and too small to hit.  The columns are sized for the widest group a row can
    have, so the buttons no longer give.

  * Status's Top Processes table had the same bug.  It already asked for `.table-ellipsis`
    and already marked its Command cell, so it overflowed a phone too (548px into 503px).
    The same rule fixes it, with widths for the three short readings.

A wrapped header is the fallback, not the layout, so every column is sized to hold its own
label on one line -- including on a phone.  "Download Frequency" is the exception at 11.7em,
which a phone cannot spare beside four other columns, so it takes a class that widens at the
tablet breakpoint and wraps below it.

Measured, nothing overflowing, no header overrun, no clipped cell, no shrunken button:

  540px   once   40 / 208 / 146 / 146      recurring  123 / 108 / 131 / 62 / 116
  1400px  once   40 / 1033 / 146 / 146     recurring  871 / 185 / 131 / 62 / 116

Desktop gains from it as well: the checkbox column drops from 90px to 40 and Completed At
from 291 to 146, so the URL column picks up about 255px.

Covered by five tests in the Cypress layout suite.  None of this is checkable in jsdom --
it is all resolved widths, and the central question is whether our `table-layout` beats the
one Mantine sets, which is exactly the part that failed silently.

69 suites / 1214 jest tests pass.
This commit is contained in:
lrnselfreliance 2026-08-12 10:08:55 -06:00 • committed by GitHub
parent ebdf9dcc4b
commit 0ae8bd5442
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 283 additions and 16 deletions

View file

@ -44,18 +44,24 @@ export class SortableTable extends React.Component {
const data = this.props['data'] ? this.sortData(this.props['data']) : null;
const tableHeader = (spec) => {
const {key, text, sortBy} = spec;
// `width` is how a column that must fit something exact -- a checkbox, a group of
// buttons -- states its size. Under `table-layout: fixed` (see `.table-ellipsis`)
// the header cell is where a column's width is declared; columns that name none
// divide what is left, which is what the truncating column wants.
const {key, text, sortBy, width} = spec;
const style = width ? {width} : undefined;
if (sortBy) {
const active = sortColumn === key;
return <Table.HeaderCell
key={key}
style={style}
sorted={active ? direction : null}
onSort={() => this.changeSort(key)}
>
{text}
</Table.HeaderCell>;
} else {
return <Table.HeaderCell key={key}>{text}</Table.HeaderCell>
return <Table.HeaderCell key={key} style={style}>{text}</Table.HeaderCell>
}
}