mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-21 23:46:18 -05:00
videos: address review — tighten auto-caption detection
- Require `line === 'auto'` in the auto-caption signature so a cue that is deliberately placed (e.g. `line:0` for top-edge) is left alone even if it is also `align:start position:0%`. YouTube auto-captions never set `line`. - For lazily-loaded language tracks, only detach the cuechange listener after the cue list is actually populated, in case a cuechange fires before cues load. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
16c457ebcb
commit
15787104fd
2 changed files with 23 additions and 7 deletions
|
|
@ -37,17 +37,18 @@ const MEDIA_PATH = '/media';
|
|||
// which pins the text to the bottom-left of the player and makes it hard to read. Detect that signature and
|
||||
// reset those cues to the browser's centered default. This mutates only the in-memory VTTCue objects the
|
||||
// browser parsed; the .vtt file on disk is never modified. Cues that were deliberately positioned (anything
|
||||
// other than the auto-caption signature) are left untouched.
|
||||
// other than the auto-caption signature) are left untouched. YouTube auto-captions never set `line`, so we
|
||||
// require `line === 'auto'` too; that leaves a deliberately placed cue (e.g. `line:0` for top-edge) alone even
|
||||
// if it happens to also be `align:start position:0%`.
|
||||
export function centerAutoCaptions(track) {
|
||||
if (!track || !track.cues) {
|
||||
return 0;
|
||||
}
|
||||
let changed = 0;
|
||||
for (const cue of track.cues) {
|
||||
if (cue.align === 'start' && cue.position === 0) {
|
||||
if (cue.align === 'start' && cue.position === 0 && cue.line === 'auto') {
|
||||
cue.align = 'center';
|
||||
cue.position = 'auto';
|
||||
cue.line = 'auto';
|
||||
changed++;
|
||||
}
|
||||
}
|
||||
|
|
@ -63,11 +64,13 @@ function handleCaptionTrackLoad(event) {
|
|||
centerAutoCaptions(track);
|
||||
} else {
|
||||
// A non-default track has mode 'disabled' at load time, so its cues are not parsed yet. Normalize
|
||||
// them the first time the browser populates them (when the user selects the track and playback
|
||||
// advances into a cue).
|
||||
// them once the browser populates the cue list (when the user selects the track and playback advances
|
||||
// into a cue). Only detach after cues actually exist, in case a cuechange fires before they load.
|
||||
const onCueChange = () => {
|
||||
centerAutoCaptions(track);
|
||||
track.removeEventListener('cuechange', onCueChange);
|
||||
if (track.cues && track.cues.length > 0) {
|
||||
centerAutoCaptions(track);
|
||||
track.removeEventListener('cuechange', onCueChange);
|
||||
}
|
||||
};
|
||||
track.addEventListener('cuechange', onCueChange);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -37,6 +37,19 @@ describe('centerAutoCaptions', () => {
|
|||
expect(track.cues[1].line).toBe(0);
|
||||
});
|
||||
|
||||
test('does not touch a left/bottom cue that was deliberately given a line', () => {
|
||||
// align:start + position:0 but an explicit line -> intentional placement, not the auto-caption
|
||||
// signature (YouTube never sets line). Must be left alone.
|
||||
const track = makeTrack([
|
||||
{align: 'start', position: 0, line: 0},
|
||||
]);
|
||||
|
||||
const changed = centerAutoCaptions(track);
|
||||
|
||||
expect(changed).toBe(0);
|
||||
expect(track.cues[0]).toEqual({align: 'start', position: 0, line: 0});
|
||||
});
|
||||
|
||||
test('handles a track with no cues yet (mode disabled)', () => {
|
||||
expect(centerAutoCaptions({cues: null})).toBe(0);
|
||||
expect(centerAutoCaptions(null)).toBe(0);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue