mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
ui: the navbar corner was nudged rather than laid out, and it showed
Three faults in the bar, all reproduced by measurement before being fixed. The indicators sat low. The slot carried `marginTop: 0.8em`, a nudge left over from Semantic's menu; the corner centres its children, and a top margin is part of the margin box being centred, so it applied as a ~6px downward shift. It read as an error on the hotspot and the theme picker but not on share or search, which is why it survived: an IconButton is a square ActionIcon that centres its glyph exactly, while a bare-icon anchor sits high inside a line box that reserves descender space for text that is not there. The nudge cancelled that out on one shape and was pure error on the other. Both are laid out now -- flex, centred, no nudge -- and the anchors get `display: flex` so they hug their glyph instead of a text line. Help and Admin highlighted only a box around their text while Videos and Statistics highlighted the full height. Same class, same rules, different parent: the bar stretches its children, but the corner is a nested flex container that centres its own, so a link inside it was sized to its content. The hover background is painted on the link box, so that box IS the affordance. The bar broke onto a second line at certain widths. Two measurement errors that only overlap in a narrow band, which is why it appeared while resizing rather than always. useOverflowNav measured the WRAPPER's offsetWidth and subtracted only the home link and the corner, missing the bar's own `padding: 0 0.25em` -- about 8px it believed it had. And the hidden "More" placeholder it measured was a plain button with no dropdown caret, about 21px narrower than the button that eventually rendered. The placeholder is now the same component as the real trigger, so the two cannot drift again. Tested in ui-layout.cy.js against the real <DesktopNav/>, which takes its colours, home link and indicators as props and so needs none of NavBar's polling hooks. Indicator centres are measured against the bar's centre rather than each other, because three things can be equally and consistently wrong and were. The wrap case sweeps 1180px down to 640px in 6px steps -- a spot check steps over a band that narrow. All three failed first: share 3.4px high, Help 24.8px against a 54.4px bar, and two rows at 1156px. Confirmed on the running app: every indicator at 0.0px from the bar's centre, Help and Admin at the full 54.4px, and no wrap anywhere from 1500px to 780px. 1115 jest / 62 suites, 182 in ui-layout.cy.js, clean npm run build.
This commit is contained in:
parent
149b40acbd
commit
2058246ef0
4 changed files with 279 additions and 9 deletions
|
|
@ -71,6 +71,44 @@ html .wrolpi-navbar .mantine-ActionIcon-root:hover {
|
|||
color: inherit;
|
||||
}
|
||||
|
||||
/*
|
||||
* One status indicator's slot. Laid out rather than nudged: see NavIconWrapper in Nav.js
|
||||
* for the 0.8em top margin this replaces and why it looked correct on half the indicators.
|
||||
*/
|
||||
.wrolpi-navbar-icon {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
margin-left: 1.5em;
|
||||
}
|
||||
|
||||
/*
|
||||
* An anchor in the corner hugs its glyph instead of a text line box.
|
||||
*
|
||||
* A line box reserves descender space for text that is not there, which leaves an icon
|
||||
* sitting about 3px above the centre of the box being centred -- the share and search
|
||||
* glyphs, but not the hotspot or theme picker, which are square ActionIcons that centre
|
||||
* their own glyph. That difference is what made a single top margin look right on some
|
||||
* indicators and wrong on others.
|
||||
*/
|
||||
.wrolpi-navbar-right a {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
}
|
||||
|
||||
/*
|
||||
* A link in the corner fills the bar's height, as one outside it does.
|
||||
*
|
||||
* Help and Admin highlighted only a box around their text while Videos and Statistics
|
||||
* highlighted the full height. Same class and same rules; the difference is the parent.
|
||||
* The bar stretches its children, but the corner is a nested flex container that centres
|
||||
* its own, so a link inside it was sized to its content. The hover background is painted
|
||||
* on the link box, so this is the hover affordance itself and not just its outline.
|
||||
*/
|
||||
.wrolpi-navbar-right .wrolpi-navbar-link,
|
||||
.wrolpi-navbar-right .wrolpi-navbar-link-button {
|
||||
align-self: stretch;
|
||||
}
|
||||
|
||||
.channel-edit {
|
||||
border-radius: 3px;
|
||||
padding: 0.75em;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue