mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-22 07:56:18 -05:00
ui: toasts move to the top right, get readable titles, and get tests
The title was unreadable in dark, night and amber. Mantine paints a dark-scheme notification title with `--mantine-color-white`, and the bridge aliases that to `--btn-text` -- deliberately, because it is the text drawn on a filled button, near-black in those three themes. So the title came out rgb(28, 31, 33) on a rgb(38, 41, 43) surface: about 1.1:1, present and invisible. Fixing the alias is not an option, it is correct for the buttons it exists for, so notifications now take their surface, border and text from our tokens instead. Measured after: 14.9, 11.9, 5.0 and 8.6 to one. The description follows the same route, and night and amber drop its muting. `--muted` on a panel is 2.0:1 in night and 3.1:1 in amber -- the description is the message itself, so those two let the title's weight carry the hierarchy instead. (`--muted` being that dim in night is not only a toast problem; statistic labels and inactive tabs use it too. Left alone here.) Position moves from bottom right to top right. Bottom right put toasts over the file browser's sticky footer and a video's player controls, which are the two places a background task is most likely to report while the user is doing something else. Gallery gets a Toasts section: one button per type, one that stacks a numbered toast per press, one that fills the container to its limit of five, one that never expires, one with no title, one with text long enough to wrap, and clear-all. A toast is the one component that cannot be seen by loading a page, so it needs buttons rather than a sample. Tests ----- Thirteen, where there were none for thirteen call sites -- and `toast` has already failed once app-wide, when App.js dropped Semantic's container while seven pages still imported the old helper and every notification silently went nowhere. Six were verified red against planted defects (a shared `id`, which makes Mantine replace instead of stack; one colour for every type; `autoClose` taking the 0 literally). The duration tests use real timers with short durations, which matters. With fake timers the element is never removed from the DOM -- hiding a notification runs an exit transition, and advancing the clock, even awaited inside `act`, does not complete it. Both the assertion and its control then read the same whatever the code does. The test for `time: 0` passed against a planted `autoClose: 0` twice before this was rewritten: once asserting synchronously, once with a control that could not fail either. It now waits for a normally-expiring toast to disappear first, so dismissal is demonstrably working before the survivor is asserted.
This commit is contained in:
parent
db3889589f
commit
213b940a1b
4 changed files with 334 additions and 1 deletions
|
|
@ -33,6 +33,7 @@ import {
|
|||
ThemePicker,
|
||||
Toggle,
|
||||
Tooltip,
|
||||
clearToasts,
|
||||
toast,
|
||||
} from './ui';
|
||||
import {semanticColorNames} from '../themes/mantine';
|
||||
|
|
@ -61,6 +62,10 @@ const Row = ({children}) => <div style={{display: 'flex', gap: 10, flexWrap: 'wr
|
|||
{children}
|
||||
</div>;
|
||||
|
||||
// Numbers the stacked toasts so it is obvious which press produced which, and that a second
|
||||
// press adds a toast rather than replacing the first. Module scope, so it survives re-renders.
|
||||
let toastCounter = 0;
|
||||
|
||||
export function ThemeSamplePage() {
|
||||
const {theme} = useContext(ThemeContext);
|
||||
const [confirmOpen, setConfirmOpen] = useState(false);
|
||||
|
|
@ -212,6 +217,77 @@ export function ThemeSamplePage() {
|
|||
</Panel>
|
||||
</Section>
|
||||
|
||||
<Section label='Toasts'>
|
||||
<Panel>
|
||||
{/*
|
||||
* `toast` has thirteen call sites and no test, and it has already failed once
|
||||
* app-wide: App.js dropped Semantic's toast container while seven pages were
|
||||
* still importing the old helper, and every notification silently vanished.
|
||||
* A toast is also the one component you cannot see by loading a page -- it has
|
||||
* to be provoked -- which is why it needs buttons here rather than a sample.
|
||||
*/}
|
||||
<Row>
|
||||
<Button role='primary' onClick={() => toast({
|
||||
type: 'info', title: 'Refresh started',
|
||||
description: 'Indexing the media directory.',
|
||||
})}>Info</Button>
|
||||
<Button role='save' onClick={() => toast({
|
||||
type: 'success', title: 'Saved',
|
||||
description: 'Channel settings written to config/channels.yaml.',
|
||||
})}>Success</Button>
|
||||
<Button role='cancel' onClick={() => toast({
|
||||
type: 'warning', title: 'Daily download limit reached',
|
||||
description: 'Downloads will resume tomorrow at 00:00.',
|
||||
})}>Warning</Button>
|
||||
<Button role='danger' onClick={() => toast({
|
||||
type: 'error', title: 'Download failed',
|
||||
description: 'HTTP 403 from the remote server after 3 attempts.',
|
||||
})}>Error</Button>
|
||||
</Row>
|
||||
|
||||
<Row>
|
||||
{/* Click this repeatedly: each press is a separate toast, and the
|
||||
container holds five at once. */}
|
||||
<Button role='cancel' onClick={() => toast({
|
||||
type: 'info', title: `Stacked toast ${++toastCounter}`,
|
||||
description: 'Press again before this one expires.',
|
||||
})}>Stack one more</Button>
|
||||
<Button role='cancel' onClick={() => {
|
||||
// All five at once, to see the container at its limit.
|
||||
for (let i = 1; i <= 5; i += 1) {
|
||||
toast({
|
||||
type: 'info', title: `Toast ${i} of 5`,
|
||||
description: 'Filling the container to its limit.',
|
||||
});
|
||||
}
|
||||
}}>Fill the stack</Button>
|
||||
<Button role='cancel' onClick={() => toast({
|
||||
type: 'error', title: 'This one stays',
|
||||
description: 'time: 0 means it waits to be dismissed. Close it yourself.',
|
||||
time: 0,
|
||||
})}>Never expires</Button>
|
||||
<Button role='cancel' onClick={() => toast({
|
||||
type: 'warning',
|
||||
description: 'No title, only a description — some call sites send just this.',
|
||||
})}>No title</Button>
|
||||
<Button role='cancel' onClick={() => toast({
|
||||
type: 'error', title: 'A long one, to see how it wraps',
|
||||
description: 'Failed to fetch https://example.com/a/very/long/path/that/'
|
||||
+ 'keeps/going/for/a/while.html: the remote server closed the '
|
||||
+ 'connection after sending part of the response body.',
|
||||
})}>Long text</Button>
|
||||
<Button role='danger' onClick={() => clearToasts()}>Clear all</Button>
|
||||
</Row>
|
||||
|
||||
<p style={{fontSize: 12, color: 'var(--muted)', marginBottom: 0}}>
|
||||
Bottom right, five at a time, five seconds each unless the caller says
|
||||
otherwise. Check each type in all four themes: night has no second hue to
|
||||
spend, so info, success, warning and error cannot be told apart by colour
|
||||
there.
|
||||
</p>
|
||||
</Panel>
|
||||
</Section>
|
||||
|
||||
<Section label='Messages'>
|
||||
<div style={{display: 'flex', flexDirection: 'column', gap: 10}}>
|
||||
<Message kind='info' title='Refresh started'>
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue