rt/wrolpi
1
0
Fork 0
mirror of https://github.com/lrnselfreliance/wrolpi.git synced 2026-10-26 19:01:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Getting video location to report errors when getting video metadata again.

Browse source
This commit is contained in:
Roland 2024-02-22 08:47:35 -07:00
parent f179c5cbd9
commit 2aa30e1674
No known key found for this signature in database
GPG key ID: 9D6DBD3ACF11AB93
1 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

27
modules/videos/downloader.py
View file

@ -207,7 +207,25 @@ class VideoDownloader(Downloader, ABC):
raise UnrecoverableDownloadError('Max download attempts reached')
url = normalize_video_url(download.url)
download.info_json = download.info_json or extract_info(url)
# Video may have been downloaded previously, get its location for error reporting.
location = None
with get_db_session() as session:
video = Video.get_by_url(url, session=session)
if video and video.channel_id:
location = f'/videos/channel/{video.channel_id}/video/{video.id}'
elif video:
location = f'/videos/video/{video.id}'
try:
download.info_json = download.info_json or extract_info(url)
except yt_dlp.utils.DownloadError as e:
# Video may be private.
return DownloadResult(
success=False,
location=location,
error='\n'.join(traceback.format_exception(e)),
)
if not download.info_json:
raise ValueError(f'Cannot download video with no info_json.')
@ -325,6 +343,7 @@ class VideoDownloader(Downloader, ABC):
return DownloadResult(
success=False,
error=error,
location=location,
)
preferred_path = video_path.with_suffix(f'.{PREFERRED_VIDEO_EXTENSION}')
@ -340,12 +359,14 @@ class VideoDownloader(Downloader, ABC):
return DownloadResult(
success=False,
error=error,
location=location,
)
if not ffmpeg_video_complete(video_path):
return DownloadResult(
success=False,
error='Video was incomplete',
location=location,
)
with get_db_session(commit=True) as session:
@ -379,11 +400,13 @@ class VideoDownloader(Downloader, ABC):
return DownloadResult(
success=False,
error='Video was downloaded but did not contain video stream',
location=location,
)
if not video.get_streams_by_codec_type('audio'):
return DownloadResult(
success=False,
error='Video was downloaded but did not contain audio stream',
location=location,
)
with get_db_session(commit=True) as session:
@ -413,7 +436,7 @@ class VideoDownloader(Downloader, ABC):
error = f'{stderr}\n\n{traceback.format_exc()}'
else:
error = str(traceback.format_exc())
return DownloadResult(success=False, error=error)
return DownloadResult(success=False, error=error, location=location)
if channel_id:
location = f'/videos/channel/{channel_id}/video/{video_id}'