controller: address hotspot protocol review findings
Some checks are pending
CodeQL / Analyze (push) Waiting to run
Controller Tests / controller-tests (push) Waiting to run
Jest Tests / jest-tests (push) Waiting to run

- Reset a saved protocol the newly probed device does not support
  instead of offering it (both UIs); a successful probe is
  authoritative, the saved value is only kept when probing fails.
- Ignore out-of-order protocol probe responses when switching devices
  quickly (both UIs).
- Verify the WPA2 rollback after a failed WPA3 activation; report that
  the hotspot may be down instead of claiming the revert succeeded.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Roland 2026-07-28 20:59:10 -06:00
parent 8687816b84
commit 2baa9cbd2e
No known key found for this signature in database
GPG key ID: 1BA620CE6C9A4680
5 changed files with 67 additions and 12 deletions

View file

@ -476,18 +476,26 @@ def enable_hotspot() -> dict:
if protocol == "wpa3":
# The driver likely rejected SAE; revert so the hotspot still works.
logger.warning("Failed to enable WPA3 hotspot, reverting to WPA2: %s", error)
subprocess.run(
revert_modify = subprocess.run(
["nmcli", "connection", "modify", "Hotspot",
"802-11-wireless-security.key-mgmt", "wpa-psk",
"802-11-wireless-security.pmf", "0"],
capture_output=True, text=True, timeout=10,
)
subprocess.run(
["nmcli", "connection", "up", "Hotspot"],
capture_output=True, text=True, timeout=30,
)
revert_up = None
if revert_modify.returncode == 0:
revert_up = subprocess.run(
["nmcli", "connection", "up", "Hotspot"],
capture_output=True, text=True, timeout=30,
)
if revert_modify.returncode == 0 and revert_up.returncode == 0:
return {"success": False,
"error": f"WPA3 is not supported by {device}; hotspot reverted to WPA2: {error}"}
revert_error = (revert_modify.stderr if revert_modify.returncode != 0 else revert_up.stderr).strip()
logger.error("Reverting hotspot to WPA2 also failed: %s", revert_error)
return {"success": False,
"error": f"WPA3 is not supported by {device}; hotspot reverted to WPA2: {error}"}
"error": f"WPA3 failed on {device} and falling back to WPA2 also failed;"
f" the hotspot may be down: {error}"}
# WPA2 is what nmcli created the hotspot with anyway; not fatal.
logger.warning("Failed to explicitly set WPA2 on hotspot: %s", error)