mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-20 06:56:18 -05:00
ui: three silent library defects the agents' reports surfaced
Each of these was reported by an agent working around it rather than patched in one file, which is why all three are fixed once, for every call site. Button accepted an `href` and dropped it. Mantine renders an anchor only when it also gets `component='a'`; Semantic spelled that `as='a'`. So a migrated call site that kept just the href produced something that looks like a download link and navigates nowhere -- silently, with no warning. Button and IconButton now infer the anchor from the href. The media filter ran twice on nested media. A `.media` wrapper filters its subtree as one unit -- the audio player needs that, because its control glyphs are SVG and the element-type rule does not reach them -- but the poster image inside also matched that rule. Two passes of a luminance-to-red matrix is not one: the second takes 0.2126 of an already-red pixel, so the poster came out markedly darker than everything around it. Leaf media inside a filtered wrapper is now left alone. Progress had no indeterminate state. Semantic's `indicating` animated a stripe when the size was unknown; without it an upload that has not reported yet sits at 0% and reads as stalled -- and `aria-valuenow="0"` tells a screen reader the same wrong thing. It now animates, reports no value, and falls back to a static fill under prefers-reduced-motion. Also: night and amber now override an inline `--label-color`. A call site may legitimately need many distinguishable colours -- the Flasher's chip badges use a twelve-colour palette no four tokens can express -- but on a night-adapted screen a green or blue chip badge defeats the entire mode. The labels lose their distinctness there, which is the right trade.
This commit is contained in:
parent
d981b2506b
commit
4b7a195220
7 changed files with 136 additions and 5 deletions
|
|
@ -499,6 +499,22 @@ html[data-theme="night"] .wrolpi-label {
|
|||
margin-top: 3px;
|
||||
}
|
||||
|
||||
/*
|
||||
* Night and amber are single-hue by definition, and a call site may legitimately want
|
||||
* many distinguishable colours — the Flasher's chip-family badges set `--label-color`
|
||||
* inline from a twelve-colour palette that no four tokens can express.
|
||||
*
|
||||
* In those themes the palette is overridden back to the theme's own text colour, so a
|
||||
* label cannot put a green or blue pixel on a night-adapted screen. `!important` is
|
||||
* required because the palette arrives as an inline custom property, which a normal
|
||||
* rule cannot outrank. The labels stop being distinguishable by colour, which is the
|
||||
* correct trade: the theme's whole purpose is that no other hue reaches the eye.
|
||||
*/
|
||||
html[data-theme="night"] .wrolpi-label,
|
||||
html[data-theme="amber"] .wrolpi-label {
|
||||
--label-color: var(--text) !important;
|
||||
}
|
||||
|
||||
/* --------------------------------------------------------------- Messages */
|
||||
|
||||
.wrolpi-message {
|
||||
|
|
@ -581,6 +597,34 @@ html[data-theme="night"] .wrolpi-label {
|
|||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* Indeterminate: a sliding band, for work whose size is not known yet. Semantic called
|
||||
* this `indicating`; without it an upload that has not reported its size sits at 0% and
|
||||
* reads as stalled.
|
||||
*/
|
||||
.wrolpi-progress-indeterminate .wrolpi-progress-fill {
|
||||
width: 35%;
|
||||
animation: wrolpi-progress-slide 1.4s ease-in-out infinite;
|
||||
}
|
||||
|
||||
@keyframes wrolpi-progress-slide {
|
||||
from {
|
||||
margin-left: -35%;
|
||||
}
|
||||
to {
|
||||
margin-left: 100%;
|
||||
}
|
||||
}
|
||||
|
||||
/* Motion is the only signal here, so when it is suppressed the bar fills instead. */
|
||||
@media (prefers-reduced-motion: reduce) {
|
||||
.wrolpi-progress-indeterminate .wrolpi-progress-fill {
|
||||
animation: none;
|
||||
width: 100%;
|
||||
opacity: 0.5;
|
||||
}
|
||||
}
|
||||
|
||||
.wrolpi-progress-text {
|
||||
position: absolute;
|
||||
inset: 0;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue