mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-21 23:46:18 -05:00
ui: night mode actually filters media, and fix three picker icons
Addresses the automated review on #583; all three were real. The night filter only applied to elements tagged `.media`, and nothing in the app carried that class - so selecting Night filtered the interface but left every video, thumbnail, PDF and map full-colour, which is precisely the thing the mode exists to prevent. The Settings copy promised otherwise, so it was also wrong. It now targets the element types instead of an opt-in class, because night mode has to fail safe: a library of thousands of files reaches the screen through many components, and one that forgot to opt in would undo half an hour of dark adaptation. `.media` still works for wrappers that must be filtered as a unit, and `.night-unfiltered` opts out. The filter is restated on `:fullscreen`, which a filter on an ancestor stops reaching. Verified on the videos page: all 25 media elements filtered. Three of the five theme choices rendered a fallback glyph and logged errors, because the icon map was built by grepping literal name='...' strings and the navigation picker passes its icon through a variable. Adds sun, moon and lightbulb, plus a test asserting every theme choice resolves to a real icon. The pre-paint script wrapped the `matchMedia` fallback in the same try as the storage read, so a device with storage blocked painted light even when it prefers dark - recreating the flash the script exists to prevent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
ea50ee2f16
commit
65d78cae32
4 changed files with 46 additions and 12 deletions
|
|
@ -5,6 +5,7 @@ import {MantineProvider} from '@mantine/core';
|
|||
import {IconMoodSmile} from '@tabler/icons-react';
|
||||
import {ThemeContext} from '../../contexts/contexts';
|
||||
import {cssVariablesResolver, mantineTheme, semanticColorNames} from '../../themes/mantine';
|
||||
import {themeChoices} from '../../themes/names';
|
||||
import {
|
||||
Button,
|
||||
Confirm,
|
||||
|
|
@ -61,6 +62,15 @@ describe('Icon', () => {
|
|||
expect(labelled).not.toHaveAttribute('aria-hidden');
|
||||
});
|
||||
|
||||
it('maps every icon the theme choices ask for', () => {
|
||||
// Regression: the map was built by grepping literal name='...' strings, so icons
|
||||
// passed through a variable (the nav bar's picker) were missed and three of the
|
||||
// five theme choices rendered a fallback glyph.
|
||||
const unmapped = themeChoices.filter(choice => !resolveIconName(choice.icon));
|
||||
|
||||
expect(unmapped.map(c => `${c.text}: ${c.icon}`)).toEqual([]);
|
||||
});
|
||||
|
||||
it('reports an unknown name instead of failing silently', () => {
|
||||
const error = jest.spyOn(console, 'error').mockImplementation(() => {});
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue