ui: Common.js and thirteen more files off Semantic

Phase 2, part 3.  Baseline 63 -> 50.

Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration.  Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.

Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.

New in the library, all in the gallery and tested:

  SearchBox     Semantic's `<Search category>` with its grouped results shape
                kept, because four call sites already build it.  A real
                combobox rather than a div that listens for clicks.
  Pagination    Semantic's prop names; onPageChange gets the page number.
  TabBar        the strip only -- routing stays with the caller.
  IconStack     Semantic's IconGroup, named once for assistive technology.
  Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
  Button/IconButton translate Semantic's size names.

That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size.  Mapping here keeps the mixed state honest.

Three real bugs found and fixed on the way, none of them cosmetic:

  * `fileSuffixIconName` returned fourteen icon names the map did not have, so
    opening a folder with a PDF, a Word document or an archive in it logged an
    error and drew a fallback glyph.  All fourteen mapped, with a test that
    walks the mapper's own return values, and another asserting every mapped
    name resolves to a Tabler component that exists.
  * `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
    the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
    LOAD15 MIN. LOAD".  It carries its own spacing now.
  * Semantic's inverted stylesheet colors every descendant of an inverted
    segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
    on the Settings page, which is exactly where someone adjusts their WROLPi
    in the dark.  Restated from tokens.

The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet.  There is one such bridge today and it is now declared.
This commit is contained in:
Roland 2026-07-30 10:00:48 -06:00
parent d359eea2d3
commit 6ea9d3645f
No known key found for this signature in database
GPG key ID: 1BA620CE6C9A4680
35 changed files with 978 additions and 1095 deletions

View file

@ -1,8 +1,7 @@
import React from "react";
import {Icon, Loader, Message, Placeholder, PlaceholderLine} from "semantic-ui-react";
import {downloadArchiveMember, getArchiveContents} from "../api";
import {fileSuffixIconName, humanFileSize} from "./Common";
import {Modal, Segment, Table} from "./Theme";
import {Icon, Message, Modal, Panel, Placeholder, Table} from "./ui";
function ArchiveEntry({entry, depth, archivePath}) {
const [expanded, setExpanded] = React.useState(depth === 0);
@ -19,9 +18,9 @@ function ArchiveEntry({entry, depth, archivePath}) {
<Table.Cell className='file-path'>
{indent}
<Icon name={expanded ? 'folder open' : 'folder'}/>
{entry.name}/
{' '}{entry.name}/
</Table.Cell>
<Table.Cell collapsing textAlign='right'>
<Table.Cell numeric>
&mdash;
</Table.Cell>
</Table.Row>
@ -37,11 +36,11 @@ function ArchiveEntry({entry, depth, archivePath}) {
<Table.Cell className='file-path' onClick={handleDownload} style={{cursor: 'pointer'}}>
{indent}
<Icon name={fileSuffixIconName(entry.name)}/>
{entry.name}
{' '}{entry.name}
{' '}
<Icon name='download' size='small' color='grey'/>
<Icon name='download' size='small'/>
</Table.Cell>
<Table.Cell collapsing textAlign='right'>
<Table.Cell numeric>
{humanFileSize(entry.size)}
</Table.Cell>
</Table.Row>
@ -52,7 +51,7 @@ function SkeletonRows() {
{[1, 2, 3].map(i =>
<Table.Row key={i}>
<Table.Cell colSpan={2}>
<Placeholder><PlaceholderLine/></Placeholder>
<Placeholder lines={1}/>
</Table.Cell>
</Table.Row>
)}
@ -88,24 +87,24 @@ export function ArchivePreviewContent({previewFile}) {
if (error) {
return <Modal.Content>
<Message negative>
<Message.Header>Cannot read archive</Message.Header>
<Message kind='error' title='Cannot read archive'>
<p>{error}</p>
</Message>
</Modal.Content>
}
return <Modal.Content scrolling>
{!loading && contents && <Segment>
{!loading && contents && <Panel>
<Icon name='archive'/>
{' '}
<strong>{contents.total_files}</strong> files,{' '}
<strong>{humanFileSize(contents.total_size)}</strong> total
</Segment>}
<Table striped selectable unstackable>
</Panel>}
<Table>
<Table.Header>
<Table.Row>
<Table.HeaderCell>Name</Table.HeaderCell>
<Table.HeaderCell collapsing textAlign='right'>Size</Table.HeaderCell>
<Table.HeaderCell>Size</Table.HeaderCell>
</Table.Row>
</Table.Header>
<Table.Body>