mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-19 22:46:20 -05:00
Address review: clear daily limits via 0; document soft-cap semantics
- Settings.js: send 0 (not null) when a daily-limit field is cleared, so the settings API actually clears a previously-saved limit instead of dropping the null and keeping the old value. - downloader.py: document that the daily limit is a best-effort soft cap; minor bounded overshoot is possible when create_downloads' background dispatch overlaps the perpetual cycle, and self-corrects the next cycle. A strict cross-process cap is intentionally not implemented. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
d95249218b
commit
706e22bd8f
2 changed files with 14 additions and 3 deletions
|
|
@ -367,11 +367,13 @@ export function SettingsPage() {
|
|||
setPendingSave(true);
|
||||
newSettings.download_timeout = parseInt(newSettings.download_timeout);
|
||||
newSettings.download_wait = parseInt(newSettings.download_wait);
|
||||
// Empty daily-limit fields become null (no change / unlimited); a number is sent as-is.
|
||||
// Empty daily-limit fields become 0 (unlimited); a number is sent as-is. Sending 0 rather than
|
||||
// null matters because the settings API drops null fields, which would leave a previously-saved
|
||||
// limit active when the user clears the field.
|
||||
newSettings.download_daily_limit_per_domain = newSettings.download_daily_limit_per_domain === ''
|
||||
? null : parseInt(newSettings.download_daily_limit_per_domain);
|
||||
? 0 : parseInt(newSettings.download_daily_limit_per_domain);
|
||||
newSettings.download_daily_limit_global = newSettings.download_daily_limit_global === ''
|
||||
? null : parseInt(newSettings.download_daily_limit_global);
|
||||
? 0 : parseInt(newSettings.download_daily_limit_global);
|
||||
newSettings.log_level = toApiLogLevel(newSettings.log_level);
|
||||
try {
|
||||
await saveSettings(newSettings);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue