mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
ui: Common.js and thirteen more files off Semantic
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
This commit is contained in:
parent
18dc90b4c2
commit
851485ef1b
35 changed files with 978 additions and 1095 deletions
|
|
@ -368,6 +368,26 @@ html[data-theme="amber"] .wrolpi-searchbox-control:focus-within {
|
|||
* non-red pixel on screen in night mode. Scoped to `:not(:checked)` so the
|
||||
* checked track keeps coming from the `color` prop.
|
||||
*/
|
||||
/*
|
||||
* Semantic's inverted stylesheet colors *every* descendant of `.ui.inverted.segment`
|
||||
* (rgba(255,255,255,.9), and #dddddd on labels). Our components are mounted inside
|
||||
* unmigrated pages that still use those wrappers, so an inherited color puts white
|
||||
* pixels on screen in night mode. Restating from tokens is the fix; the rule can go
|
||||
* when the last Semantic wrapper does.
|
||||
*/
|
||||
.wrolpi-switch .mantine-Switch-label {
|
||||
color: var(--text);
|
||||
}
|
||||
|
||||
.wrolpi-switch .mantine-Switch-description {
|
||||
color: var(--muted);
|
||||
}
|
||||
|
||||
.wrolpi-switch input:disabled + * .mantine-Switch-label,
|
||||
.wrolpi-switch input:disabled ~ * .mantine-Switch-label {
|
||||
color: var(--muted);
|
||||
}
|
||||
|
||||
.wrolpi-switch input:not(:checked) + .mantine-Switch-track {
|
||||
--switch-bg: var(--border);
|
||||
}
|
||||
|
|
@ -599,7 +619,60 @@ html[data-theme="amber"] .wrolpi-progress-fill {
|
|||
border: 1.5px dashed var(--red);
|
||||
}
|
||||
|
||||
/* ----------------------------------------------------------- Card posters */
|
||||
/*
|
||||
* The icon shown when a file has no poster, and the corner mark for a tagged
|
||||
* file. Both live here rather than in Common.js so the card surface and the
|
||||
* poster area agree in every theme.
|
||||
*/
|
||||
|
||||
.wrolpi-card-icon {
|
||||
position: relative;
|
||||
display: flex;
|
||||
align-items: center;
|
||||
justify-content: center;
|
||||
min-height: 120px;
|
||||
background: var(--head);
|
||||
}
|
||||
|
||||
.wrolpi-card-tag {
|
||||
position: absolute;
|
||||
top: 0;
|
||||
left: 0;
|
||||
display: flex;
|
||||
padding: 3px 4px;
|
||||
background: var(--green);
|
||||
color: var(--btn-text);
|
||||
}
|
||||
|
||||
/* Night and amber have no green to spend; the mark reads as an outline instead. */
|
||||
html[data-theme="night"] .wrolpi-card-tag,
|
||||
html[data-theme="amber"] .wrolpi-card-tag {
|
||||
background: var(--panel);
|
||||
color: var(--text);
|
||||
border-right: 1px solid var(--border);
|
||||
border-bottom: 1px solid var(--border);
|
||||
}
|
||||
|
||||
/* ------------------------------------------------------------- Statistics */
|
||||
/*
|
||||
* A statistic carries its own spacing rather than relying on a parent to supply
|
||||
* it: unmigrated pages still drop these inside Semantic's `Statistic.Group`,
|
||||
* whose CSS only spaces elements carrying Semantic's own classes, and without
|
||||
* this the labels run together into one unreadable line.
|
||||
*/
|
||||
|
||||
.wrolpi-statistic {
|
||||
display: inline-block;
|
||||
vertical-align: top;
|
||||
margin: 0 26px 10px 0;
|
||||
}
|
||||
|
||||
/* Inside our own group the grid does the spacing, so the intrinsic margin goes. */
|
||||
.wrolpi-statistic-cell .wrolpi-statistic {
|
||||
display: block;
|
||||
margin: 0;
|
||||
}
|
||||
|
||||
.wrolpi-statistic-value {
|
||||
font-size: 24px;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue