mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-22 07:56:18 -05:00
dev: stop the app container linting on every rebuild
react-scripts lints in-process on every incremental rebuild. Each save pays for it, and the result is buried under a few hundred warnings the repo has carried for years -- `no-useless-computed-key` on the wire-gauge tables, `react-hooks/exhaustive-deps` across most of Common.js. Finding "Compiled successfully" in that takes a scroll. This container only serves; it never builds. Linting still happens where it is acted on: `npm run build` and CI both run it, and both fail on a real error. NOT a memory fix, though that is why I reached for it -- the dev server was OOM-killed three times in an afternoon and I claimed this would be the biggest saving. It is not. Measured both ways with the same procedure (recreate, load a page, wait for the typecheck, read `docker stats`) the container settles at 3.5GB with linting and 3.0GB then 3.7GB without it. The spread between two runs of the SAME configuration is wider than the spread between configurations, so the effect is below what this can measure. Raising Docker Desktop's VM limit from 8GB to 16GB is what actually stopped the kills. Kept anyway, on the time and the noise, which are not in doubt. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
3204fb51ea
commit
c534e4f5d8
1 changed files with 11 additions and 0 deletions
|
|
@ -90,6 +90,17 @@ services:
|
|||
environment:
|
||||
# Force React to use Caddy port to connect to it's websocket.
|
||||
- WDS_SOCKET_PORT=0
|
||||
# react-scripts lints in-process on every incremental rebuild, which costs time on each
|
||||
# save and buries the compile result under a few hundred warnings the repo has carried
|
||||
# for years. This container only serves; linting still happens where it is acted on --
|
||||
# `npm run build` and CI both run it, and both fail on a real error.
|
||||
#
|
||||
# NOT a memory fix, though it was tried as one after the dev server was OOM-killed three
|
||||
# times in an afternoon. Measured either way, the container settles anywhere between
|
||||
# 3.0GB and 3.7GB and the spread between two runs of the SAME configuration is wider
|
||||
# than the spread between configurations. Raising Docker Desktop's VM limit is what
|
||||
# actually stopped the kills.
|
||||
- DISABLE_ESLINT_PLUGIN=true
|
||||
|
||||
web: # Caddy reverse proxy - handles HTTPS for all services.
|
||||
depends_on:
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue