Surface coarse SMART health for USB-bridge drives (#498)
Some checks failed
CodeQL / Analyze (push) Has been cancelled
Controller Tests / controller-tests (push) Has been cancelled
Jest Tests / jest-tests (push) Has been cancelled

* Surface coarse SMART health for USB-bridge drives

USB enclosures that reject ATA pass-through (e.g. Seagate Expansion) are
invisible to pySMART/DeviceList, so the drive shows no SMART at all on the
Controller page. Fall back to smartctl over the SCSI transport, which many
such bridges still answer, to report a coarse PASS/FAIL health plus drive
identity (model/serial/capacity).

The health (-d scsi -H) and identity (-d scsi -i) reads are issued as
separate calls: combining them makes smartctl suppress the health line when
the identity read reports "SMART support is: Unavailable" (which these
bridges do). The entry is marked smart_limited (labelled "(limited)" in both
UIs) so a green PASS is not mistaken for full monitoring — these drives
expose no attributes or temperature, and some bridges report "OK" statically.

* Harden SCSI health fallback (Greptile review)

- _scsi_health: treat any unrecognised status (e.g. "UNKNOWN", "N/A") as
  unreadable (None) instead of a false FAIL. Only "OK" -> PASS and "FAIL*"
  -> FAIL; anything else omits the drive rather than showing a red FAIL that
  contradicts the smart_limited disclaimer.
- get_all_smart_status: isolate the SCSI supplement loop in its own
  try/except so an error there cannot discard the pySMART results already
  collected.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
lrnselfreliance 2026-06-26 07:23:15 -06:00 • committed by Roland
parent 9f0e3fa0aa
commit dac849f9f6
No known key found for this signature in database
GPG key ID: 1BA620CE6C9A4680
4 changed files with 298 additions and 14 deletions

View file

@ -586,7 +586,10 @@ function SmartDetailsModal({drive, open, onClose}) {
<Table.Cell>Assessment</Table.Cell>
<Table.Cell>
<Icon name='circle' color={healthColor}/>
{drive.assessment || 'Unknown'}
{drive.assessment || drive.health || 'Unknown'}
{drive.smart_limited
? ' (limited — USB enclosure reports health only, no attributes)'
: ''}
</Table.Cell>
</Table.Row>
<Table.Row>
@ -1076,6 +1079,7 @@ function DiskSection() {
color={getHealthColor(drive.health || drive.assessment)}
/>
{drive.health || drive.assessment || 'Unknown'}
{drive.smart_limited ? ' (limited)' : ''}
</Table.Cell>
<Table.Cell>
{drive.temperature !== null && drive.temperature !== undefined