rt/wrolpi
1
0
Fork 0
mirror of https://github.com/lrnselfreliance/wrolpi.git synced 2026-10-26 19:01:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: name the real extra connections in the request connection xfails

Browse source 
Channel detail: get_channel already uses the request session; the extra connection is
Channel.get_statistics opening a raw cursor (get_db_curs).  Search: count_file_groups opens a
cursor for the total, then handle_file_group_search_results opens a cursor and a session.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Roland 2026-10-03 15:41:30 -06:00
parent dfa64666ce
commit e8ee077f1a
No known key found for this signature in database
GPG key ID: 1BA620CE6C9A4680
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
wrolpi/test/test_request_db.py
View file

@ -92,7 +92,8 @@ async def test_zim_search_uses_one_connection(async_client, test_session, zim_fa
@pytest.mark.asyncio
@pytest.mark.parametrize('path', ['/api/files/search', '/api/videos/search'])
async def test_search_uses_one_connection(async_client, test_session, simple_channel, video_factory, path):
"""The search helpers in `wrolpi.files.lib` open a cursor, then a separate session."""
"""`count_file_groups` opens a cursor for the total (skipped when the total is cached), then
`handle_file_group_search_results` opens another cursor and a separate session for the page."""
video_factory(title='a video', channel_id=simple_channel.id)
response, count = await count_request_connections(
async_client, test_session, 'post', path, json={'search_str': 'video'})
@ -103,7 +104,8 @@ async def test_search_uses_one_connection(async_client, test_session, simple_cha
@OPENS_OWN_CONNECTION
@pytest.mark.asyncio
async def test_channel_uses_one_connection(async_client, test_session, simple_channel):
"""`get_channel` and the Channel's statistics each open their own session."""
"""`get_channel` uses the request session, but `Channel.get_statistics` opens a raw cursor of its own
(`get_db_curs`)."""
response, count = await count_request_connections(
async_client, test_session, 'get', f'/api/videos/channels/{simple_channel.id}')
assert response.status_code == HTTPStatus.OK, response.body