review: close the mixed-unit gaps the scale left behind

Seven review comments, all valid.  The common thread is the one the guard was supposed to
catch and did not: geometry converted to rem beside geometry that stayed px.

The guard was narrower than its name.  It missed:

- `transform`, `flex` and `flex-basis`, so `translateX(26px)` and `flex: 1 1 200px` were
  invisible on properties nobody thought to list;
- every NEGATIVE length, because the lookbehind treated the minus sign as part of the
  preceding token -- `left: -7px` and `margin-top: -2.5px` position the eyelet on a tag whose
  diamond HAD been converted, and `right: -3px` / `bottom: -3px` place the corner badge on a
  converted icon.  Each is a piece of geometry that stopped tracking the piece it belongs to.

With both fixed it found nine values, including one no comment mentioned (`flex: 1 1 200px`).
All nine converted, except the three in a dead `.toggle` / `.slider` block: nothing has
referenced those classes since Toggle became a Mantine Switch, and it was ALREADY broken --
track and knob in rem, travel still `translateX(26px)`, so the thumb stopped ~4px short of a
54px track.  Dead CSS that is also wrong is a trap for whoever revives it, so it is deleted.

The tag eyelet is centred with `translateY(-50%)` rather than a negative margin of half its
own height, so the two pieces cannot drift again whatever the scale.

Also from the review:

- A runtime check, which is what the source guards were missing.  Three cases in
  ui-layout.cy.js measure the real thing: the root font-size is the declared multiple of 16,
  our text AND a Mantine control both grow by the same factor when the scale changes, and a
  hairline does not.  The second is the one that catches `theme.scale` being set and silently
  cancelling the root.
- `max-height: max(..., 56.25cqw)` now follows a plain rem declaration.  An engine without
  container query units throws out the whole declaration, which would have left the poster
  with NO cap -- a portrait cover standing as tall as the card is wide.  Older engines clamp;
  newer ones take the second.
- `pxToRem` in components/ui/scale.ts, replacing the `/ 16` written out in CardGroup and
  Placeholder.
- The map overlays: 20 values across the layer panel, add-pin dialog, search panel and
  context menu, whose type had grown 10% while their padding had not.  Left in px on purpose:
  the context menu's `left`/`top` (a real click coordinate), maplibre's own `ScaleControl`
  maxWidth, and the `calc(100% - 100px)` reserve for maplibre's px-sized controls.  The
  `100vh - 120px` reserve DID become rem, since the chrome it reserves for is ours.
- The keyboard-shortcuts spec no longer deletes `.mantine-Notifications-root` from the DOM.
  The reviewer was right that it is brittle; the endpoints are mocked instead, now that the
  probe named them: `/api/tag`, `/api/events/feed`, `/api/files/search` and
  `/api/files/worker_status`.  Two of those were already "mocked" as `/api/tags` and
  `/api/events`, which nothing calls -- the wrong paths were the reason a toast appeared at
  all.  Verified under CI's condition (`forceNetworkError` on everything unmocked): 12
  passing with no DOM surgery.

What is NOT done, deliberately: about 176 numeric geometry values remain in 23 feature files.
The map overlays were the visible ones.  Sweeping the rest is a change to 23 files nobody has
reviewed, so instead the guard's name now says "in our stylesheets" rather than implying the
whole app, and a new ratchet keeps numeric geometry out of the component library so the
eleventh inline `gap: 10` cannot be added there.

Both new guards planted against.  Verified: 1142 jest / 65 suites, 251 ui-layout + 10
modal-stack component tests, all 50 e2e specs, clean build, map overlays measured to track the
scale (panel minWidth 200 -> 220, search 320 -> 352) and screenshotted.
This commit is contained in:
Roland 2026-08-03 19:37:25 -06:00
parent 6be7f4b99e
commit eba9bbf7de
No known key found for this signature in database
GPG key ID: 1BA620CE6C9A4680
10 changed files with 269 additions and 125 deletions

View file

@ -43,8 +43,9 @@
*/
.wrolpi-icon-stack-corner {
position: absolute;
right: -3px;
bottom: -3px;
/* rem, so the badge keeps its corner as the glyph it sits on grows. */
right: -0.1875rem;
bottom: -0.1875rem;
display: flex;
background: var(--icon-stack-bg, var(--bg));
border-radius: 50%;
@ -836,10 +837,15 @@ html[data-theme="amber"] .wrolpi-path-input-control:focus-within {
content: '';
position: absolute;
top: 50%;
left: -7px;
left: -0.4375rem;
width: 0.3125rem;
height: 0.3125rem;
margin-top: -2.5px;
/*
* Centred by translation rather than by a negative margin of half its own height.
* The margin was -2.5px against a 0.3125rem dot: once the dot scaled and the margin
* did not, the hole drifted off the point's centre. A percentage cannot drift.
*/
transform: translateY(-50%);
border-radius: 50%;
background: currentColor;
/* A hole, not a dot: it should read as absence rather than as a bullet. */
@ -1092,7 +1098,7 @@ html .mantine-Notification-closeButton:hover {
cursor: pointer;
display: flex;
/* Widen the tap target past the glyph without moving it. */
margin: -6px -6px -6px 0;
margin: -0.375rem -0.375rem -0.375rem 0;
padding: 0.375rem;
}
@ -1378,7 +1384,14 @@ html[data-theme="amber"] .wrolpi-progress-fill {
*
* `max()`, not `min()`: on a narrow card the fraction is the smaller value and the floor
* has to win, or the cap would tighten as cards got smaller and crop a portrait cover.
*
* Declared twice on purpose. `cqw` needs container queries (Chrome 105, Safari 16), and an
* engine that does not know the unit throws out the WHOLE declaration -- which would leave
* the poster with no height cap at all, so a portrait cover would stand as tall as the card
* is wide. The plain cap first means such an engine still clamps, just without the
* card-relative growth; anything newer takes the second and ignores the first.
*/
max-height: var(--card-poster-max-height);
max-height: max(var(--card-poster-max-height), 56.25cqw);
}