mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-21 23:46:18 -05:00
test: act on review — and one of the seven turned out to be undemonstrable
Six real fixes and one honest retraction.
The control is now a SIBLING of the heading inside a flex row, not a child of
it. Inside the `<h3>` it joined the heading's accessible name, so screen reader
heading navigation announced "Root CA Certificate Help". The row is what keeps
them on one line, and it is only rendered when there is something to sit beside,
so the markup for the other 46 call sites is unchanged.
`style` now lands on the wrapper. It used to reach the outer div; going through
Header put it on the inner heading, where a margin sets space INSIDE the wrapper
and only worked at all through margin collapse -- which stops the moment the
wrapper gains padding or a border. Status's "Drive Bandwidth" is the live case:
verified 16px on the block, 0 on the h2. Text properties still arrive, because
colour and text-align inherit; the `color` PROP stays on the heading.
A `<label>` only when `for_` names a field. Several call sites pass an
InfoHeader as the `label` prop of InputForm/ToggleForm, which wraps it in a
label of its own -- an unconditional one nested labels, which is invalid and
makes clicking the text ambiguous. Verified: zero `label label` on
/videos/settings, where "Video Resolutions" keeps its label and "Video File
Format" no longer has one.
The help controls carried `iconStyle: {margin: '0.5em'}`, which separated a
free-floating sibling and, inside the row, added to the gap on every side.
Zeroed; the row's gap is the spacing.
The browser test mounted a plain Button in an `after` slot rather than a real
HelpHeader, so the default icon chrome above was exactly what it could not see.
It mounts the real wrapper now. Two of my assertions were also too weak to
catch what they claimed: the gap was measured to `.wrolpi-header-after`, a flex
container whose own rect does not move when a child gains a margin, so it had to
measure the button; and the squeeze case used a title of ordinary words, which
simply wraps and never puts the row under pressure.
Renamed the suites -- "keeps the icon on its own line" read as the opposite of
the fix.
The retraction: `flex-shrink: 0` is declared but has NO test. Three attempts
could not find a width where removing it changes what is painted -- the row's
only other item is a heading, and its automatic minimum size absorbs the
pressure; the help control is an ActionIcon with a min-width it will not go
below either. The declaration stays as a statement of intent, with a comment
saying it is unproven, rather than a green test that does not discriminate.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
5491a82361
commit
f153d7c8d8
6 changed files with 174 additions and 43 deletions
|
|
@ -347,18 +347,46 @@ describe('Header', () => {
|
|||
expect(screen.getByText('Paste this into the extension')).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it('puts trailing content inside the heading, not after its wrapper', () => {
|
||||
it("puts trailing content in the heading's row, not after its wrapper", () => {
|
||||
/*
|
||||
* The whole point of the slot. `.wrolpi-header` is a block, so anything placed after
|
||||
* it starts a new line -- which is what happened to every help icon in the app when
|
||||
* these headings stopped being a bare `<h3>`. Inside the heading element it joins
|
||||
* the existing flex row.
|
||||
* these headings stopped being a bare `<h3>`. A shared flex row holds them together.
|
||||
*/
|
||||
const {container} = renderUI(
|
||||
<Header as='h3' after={<button type='button'>Help</button>}>Root CA Certificate</Header>);
|
||||
|
||||
const heading = container.querySelector('h3');
|
||||
expect(heading).toContainElement(screen.getByRole('button', {name: 'Help'}));
|
||||
const row = container.querySelector('.wrolpi-header-row');
|
||||
expect(row).toContainElement(container.querySelector('h3'));
|
||||
expect(row).toContainElement(screen.getByRole('button', {name: 'Help'}));
|
||||
});
|
||||
|
||||
it("keeps the control out of the heading's accessible name", () => {
|
||||
// Inside the <h3> the control becomes part of the name, so heading navigation
|
||||
// announces "Root CA Certificate Help".
|
||||
renderUI(<Header as='h3' after={<button type='button'>Help</button>}>Root CA Certificate</Header>);
|
||||
|
||||
expect(screen.getByRole('heading')).toHaveAccessibleName('Root CA Certificate');
|
||||
});
|
||||
|
||||
it('puts layout styles on the block, not on the heading inside it', () => {
|
||||
/*
|
||||
* `style` is used for spacing the header as a whole -- marginBottom on Status's
|
||||
* "Drive Bandwidth", marginTop on the extension page. On the inner heading those set
|
||||
* a margin inside the wrapper and worked only through margin collapse, which stops as
|
||||
* soon as the wrapper gains padding or a border.
|
||||
*/
|
||||
const {container} = renderUI(
|
||||
<Header as='h3' style={{marginBottom: '1em'}}>Drive Bandwidth</Header>);
|
||||
|
||||
expect(container.querySelector('.wrolpi-header')).toHaveStyle({marginBottom: '1em'});
|
||||
expect(container.querySelector('h3').style.marginBottom).toBe('');
|
||||
});
|
||||
|
||||
it('still colours the heading text from the colour prop', () => {
|
||||
const {container} = renderUI(<Header as='h4' color='danger'>2 items to remove</Header>);
|
||||
|
||||
expect(container.querySelector('h4')).toHaveStyle({color: 'var(--danger)'});
|
||||
});
|
||||
|
||||
it('renders nothing extra when there is no trailing content', () => {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue