mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
02aed6d7f5
CI's cypress-e2e job went red on the interface scale: `directory-search.cy.js` failed `expected '<div.wrolpi-searchbox-result-title>' to be 'visible'`. The suggestion list is capped at `min(60vh, 30rem)`. The rem ceiling scales with the interface but a fraction of the VIEWPORT does not, so when the type grew 10% the rows grew and the cap did not: the full set of grouped suggestions now needs about 420px, and 60vh of a 660px-tall window -- Cypress's default -- is 396px. The last group was clipped again, which is the exact defect the comment on that rule already describes. 70vh is 462px there, and the 30rem ceiling still bounds it on a tall window, so the list cannot cover the page either way. Measured rather than guessed: the spec fails at 660px of viewport height and passes from 700px up, so the shortfall was about 24px. Verified: all 50 e2e specs pass locally, 248 ui-layout component tests, 1141 jest tests. |
||
|---|---|---|
| .. | ||
| Button.tsx | ||
| DataTable.tsx | ||
| Feedback.tsx | ||
| Icon.tsx | ||
| index.ts | ||
| Inputs.tsx | ||
| modal-stack.cy.js | ||
| Navigation.tsx | ||
| Overlays.tsx | ||
| SearchBox.tsx | ||
| Surfaces.tsx | ||
| ThemePicker.tsx | ||
| toast.test.js | ||
| toast.ts | ||
| ui-layout.cy.js | ||
| ui.css | ||
| ui.test.js | ||