mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
Add a VNC toggle to the Controller (both UIs) that starts/stops whichever VNC backend is installed: wayvnc for Wayland (Raspberry Pi OS), RealVNC for X11. Runtime-only, like the Desktop toggle: the unit is never enabled, so VNC does not return after a reboot. Users who want it permanently on can enable it with raspi-config. VNC serves the desktop session, so starting it without a desktop gives clients a blank screen. The gate lives in the backend, not just the UI, so curl callers get it too (409, distinct from a systemctl failure). Stopping is never gated so a running VNC server can't be stranded on with no way to turn it off. Backend selection deliberately avoids raspi-config's live-compositor probe (pgrep labwc), which reports X11 — and would pick the wrong backend — whenever the desktop is stopped. wayvnc also requires its config to exist; that is checked directly rather than via the unit's ConditionResult, which reports 'no' for any unit that has never been started. Extracts _unit_properties()/_systemctl_unit() so Desktop and VNC share one systemd probe and start/stop path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
57 lines
2 KiB
JavaScript
57 lines
2 KiB
JavaScript
import React from 'react';
|
|
import {render, screen} from '@testing-library/react';
|
|
import userEvent from '@testing-library/user-event';
|
|
import {VncToggle} from './Common';
|
|
|
|
const mockSetVnc = jest.fn();
|
|
let mockVncState = {on: false, desktopRunning: true};
|
|
|
|
jest.mock('../hooks/customHooks', () => ({
|
|
...jest.requireActual('../hooks/customHooks'),
|
|
useVnc: () => ({...mockVncState, setVnc: mockSetVnc}),
|
|
}));
|
|
|
|
describe('VncToggle', () => {
|
|
beforeEach(() => {
|
|
mockSetVnc.mockClear();
|
|
mockVncState = {on: false, desktopRunning: true};
|
|
});
|
|
|
|
it('starts VNC when the Desktop is running', async () => {
|
|
render(<VncToggle/>);
|
|
const toggle = screen.getByTestId('toggle');
|
|
expect(toggle).not.toBeDisabled();
|
|
await userEvent.click(toggle);
|
|
expect(mockSetVnc).toHaveBeenCalledWith(true);
|
|
});
|
|
|
|
it('is disabled while the Desktop is stopped', async () => {
|
|
mockVncState = {on: false, desktopRunning: false};
|
|
render(<VncToggle/>);
|
|
await userEvent.click(screen.getByTestId('toggle'));
|
|
expect(mockSetVnc).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('can always be stopped, even with the Desktop stopped', async () => {
|
|
// Otherwise a running VNC server would be stranded on with no way to stop it.
|
|
mockVncState = {on: true, desktopRunning: false};
|
|
render(<VncToggle/>);
|
|
const toggle = screen.getByTestId('toggle');
|
|
expect(toggle).toBeChecked();
|
|
await userEvent.click(toggle);
|
|
expect(mockSetVnc).toHaveBeenCalledWith(false);
|
|
});
|
|
|
|
it('renders checked when VNC is running', () => {
|
|
mockVncState = {on: true, desktopRunning: true};
|
|
render(<VncToggle/>);
|
|
expect(screen.getByTestId('toggle')).toBeChecked();
|
|
});
|
|
|
|
it('does nothing when VNC is unsupported', async () => {
|
|
mockVncState = {on: null, desktopRunning: true};
|
|
render(<VncToggle/>);
|
|
await userEvent.click(screen.getByTestId('toggle'));
|
|
expect(mockSetVnc).not.toHaveBeenCalled();
|
|
});
|
|
});
|