wrolpi/.github/workflows/controller-tests.yml
lrnselfreliance 8edace08bd
Python packages install from hash-locked requirements; yt-dlp still floats (#913)
* Python packages install from hash-locked requirements; yt-dlp still floats

Every pip install trusted PyPI over TLS: requirements.txt pins only top-level versions
(some with >=), the controller's are almost all >=, and dependencies were never pinned, so
a forged certificate (as the eMudhra key compromise allowed) could change code in the API,
the controller, or the archive container.  scripts/lock_requirements.sh generates a
universal, hash-locked .lock beside each requirements.txt, and
install_python_requirements.sh installs it with --require-hashes at every site.  yt-dlp is
left out of the lock and upgraded afterwards so devices still get YouTube fixes; its
dependencies are locked.  The unpinned `pip install --upgrade pip` steps are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* The unhashed yt-dlp install cannot replace locked packages, and nothing builds from source

Review of #913 found two holes.  The yt-dlp step ran without --no-deps, so pip's
only-if-needed strategy would still fetch an unhashed dependency whenever yt-dlp's metadata
asked for a version the lock did not install.  And srt is published only as a source
archive, whose build installed setuptools with hash checking off on every install.

The yt-dlp step now uses --no-deps (its dependencies come only from the lock), both steps
are retried as the image builds did before, and installs and locks are wheels-only.  srt
3.5.3 is vendored unmodified as wrolpi/vendor/srt.py (MIT), verified against the sdist
hash the lock pinned; webvtt-py's SRT reader rejects WROLPi's own test file, so it is not
a replacement.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 12:00:39 -07:00

36 lines
1.1 KiB
YAML

name: Controller Tests
# `pull_request` is unfiltered for the same reason as jest-tests.yml: `branches: [master]` meant
# this never ran on a pull request into any other branch. It is why Controller Tests is absent
# from the checks on the pull request that moved this job to Python 3.13 -- the change to this
# file could not be verified by the run that contained it.
on:
push:
branches: [master, feature/*]
pull_request:
jobs:
controller-tests:
runs-on: ubuntu-latest
defaults:
run:
working-directory: controller
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
# Trixie ships 3.13, and docker/controller/Dockerfile is python:3.13-slim-trixie.
python-version: '3.13'
cache: 'pip'
cache-dependency-path: controller/requirements.lock
- name: Install dependencies
run: ../scripts/install_python_requirements.sh pip requirements.txt
- name: Run pytest
run: python -m pytest test/ -v --tb=short --confcutdir=$(pwd)