mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-20 15:06:19 -05:00
* Warn in the navbar when a hard drive runs hot. The navbar already warns about high CPU temperature; add the equivalent for drive temperature, since an overheating disk risks data loss and a user running an off-grid library won't be watching for it. - controller/lib/smart.py: build_smart_stats() returns the per-drive list plus warning thresholds (55C warn / 65C critical) so the frontend stays dumb. Reading SMART wakes a spun-down drive, so drives in standby are detected with `smartctl -n standby` (which works through the USB-SATA bridges where `hdparm -C` only reports "unknown") and NOT read; their last-known reading is reused instead. - controller/lib/status_worker.py: collect SMART on a slow 60s cadence (cached on app.state) rather than the 5s status loop, so the poll does not keep USB drives awake. The result flows into the same cached payload via a new collect_all_status(smart_stats=...) kwarg. - Frontend: useDriveTemperature() reports the hottest drive; Nav.js shows a yellow/red `hdd` icon with a popup, mirroring the CPU warning. Verified on hardware: smart_stats reports real temps and SMART runs once a minute, not every 5s. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Address Greptile review on HDD temperature warning. - _drive_is_asleep also treats SLEEP mode as asleep, not just STANDBY. smartctl -n standby exits "Device is in SLEEP mode, exit(2)" for the deeper power mode; matching only "STANDBY" meant a SLEEP drive was read and woken — the exact failure the check prevents. (TDD: added a failing SLEEP test, then fixed.) - useDriveTemperature uses ?? instead of || for the temperature fallback to express "fall back only on null/undefined". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
180 lines
6.9 KiB
JavaScript
180 lines
6.9 KiB
JavaScript
import React from 'react';
|
|
import {act, renderHook} from '@testing-library/react';
|
|
import {render, screen} from '@testing-library/react';
|
|
import {usePages, useDriveTemperature} from './customHooks';
|
|
import {QueryContext, StatusContext} from '../contexts/contexts';
|
|
import {Paginator} from '../components/Common';
|
|
|
|
// Build a wrapper that provides a controlled QueryContext so usePages can read
|
|
// `o` and `l` from searchParams without a real router.
|
|
const makeWrapper = (initialParams = {}) => {
|
|
const params = new URLSearchParams(initialParams);
|
|
const Wrapper = ({children}) => {
|
|
const [searchParams, setSearchParams] = React.useState(params);
|
|
|
|
const updateQuery = (newParams) => {
|
|
const next = new URLSearchParams(searchParams.toString());
|
|
Object.entries(newParams).forEach(([k, v]) => {
|
|
if (v === null || v === undefined) {
|
|
next.delete(k);
|
|
} else {
|
|
next.set(k, String(v));
|
|
}
|
|
});
|
|
setSearchParams(next);
|
|
};
|
|
|
|
return (
|
|
<QueryContext.Provider value={{searchParams, updateQuery, getLocationStr: () => '/'}}>
|
|
{children}
|
|
</QueryContext.Provider>
|
|
);
|
|
};
|
|
return Wrapper;
|
|
};
|
|
|
|
// Mock Media so Paginator renders both mobile + tablet variants synchronously.
|
|
jest.mock('../contexts/contexts', () => {
|
|
const actual = jest.requireActual('../contexts/contexts');
|
|
return {
|
|
...actual,
|
|
Media: ({children}) => <>{children}</>,
|
|
};
|
|
});
|
|
|
|
describe('usePages.setTotal -> totalPages', () => {
|
|
// These cases describe the contract: how many pages should the Paginator
|
|
// render given a total result count and a per-page limit?
|
|
const cases = [
|
|
// [total, limit, expectedPages, label]
|
|
[0, 24, 1, 'no results -> 1 page'],
|
|
[1, 24, 1, 'fewer than one page'],
|
|
[23, 24, 1, 'just under one page'],
|
|
[24, 24, 1, 'exactly one page (BUG: reports 2)'],
|
|
[25, 24, 2, 'one full page plus one'],
|
|
[47, 24, 2, 'just under two pages'],
|
|
[48, 24, 2, 'exactly two pages (BUG: reports 3)'],
|
|
[49, 24, 3, 'just over two pages'],
|
|
[72, 24, 3, 'exactly three pages (BUG: reports 4)'],
|
|
[100, 24, 5, 'partial last page'],
|
|
[144, 24, 6, 'exactly six pages (BUG: reports 7)'],
|
|
];
|
|
|
|
test.each(cases)('total=%i limit=%i -> %i pages (%s)', (total, limit, expected) => {
|
|
const wrapper = makeWrapper({l: String(limit)});
|
|
const {result} = renderHook(() => usePages(limit), {wrapper});
|
|
|
|
act(() => {
|
|
result.current.setTotal(total);
|
|
});
|
|
|
|
expect(result.current.totalPages).toBe(expected);
|
|
});
|
|
|
|
test('the last reported page yields an offset within total (no empty trailing page)', () => {
|
|
// This is the user-visible symptom: clicking the last page link should
|
|
// produce an offset that the API can still satisfy. When totalPages is
|
|
// off-by-one, the last page maps to offset === total (or > total) and
|
|
// the API returns zero rows.
|
|
const total = 48;
|
|
const limit = 24;
|
|
const wrapper = makeWrapper({l: String(limit)});
|
|
const {result} = renderHook(() => usePages(limit), {wrapper});
|
|
|
|
act(() => {
|
|
result.current.setTotal(total);
|
|
});
|
|
|
|
act(() => {
|
|
result.current.setPage(result.current.totalPages);
|
|
});
|
|
|
|
// setPage stores (page - 1) * limit as `o` in the query.
|
|
const lastOffset = (result.current.totalPages - 1) * limit;
|
|
expect(lastOffset).toBeLessThan(total);
|
|
});
|
|
});
|
|
|
|
describe('useDriveTemperature', () => {
|
|
const makeStatusWrapper = (status) => ({children}) => (
|
|
<StatusContext.Provider value={{status}}>
|
|
{children}
|
|
</StatusContext.Provider>
|
|
);
|
|
|
|
test('selects the hottest drive and reads thresholds from the payload', () => {
|
|
const status = {
|
|
smart_stats: {
|
|
drives: [
|
|
{device: 'sda', temperature: 51},
|
|
{device: 'sdb', temperature: 60},
|
|
],
|
|
high_temperature: 55,
|
|
critical_temperature: 65,
|
|
},
|
|
};
|
|
const {result} = renderHook(() => useDriveTemperature(),
|
|
{wrapper: makeStatusWrapper(status)});
|
|
expect(result.current.device).toBe('sdb');
|
|
expect(result.current.temperature).toBe(60);
|
|
expect(result.current.highTemperature).toBe(55);
|
|
expect(result.current.criticalTemperature).toBe(65);
|
|
});
|
|
|
|
test('ignores drives without a numeric temperature', () => {
|
|
const status = {
|
|
smart_stats: {
|
|
drives: [
|
|
{device: 'sda', temperature: null},
|
|
{device: 'sdb', temperature: 48},
|
|
],
|
|
high_temperature: 55,
|
|
critical_temperature: 65,
|
|
},
|
|
};
|
|
const {result} = renderHook(() => useDriveTemperature(),
|
|
{wrapper: makeStatusWrapper(status)});
|
|
expect(result.current.device).toBe('sdb');
|
|
expect(result.current.temperature).toBe(48);
|
|
});
|
|
|
|
test('defaults to no warning and default thresholds when smart_stats is absent', () => {
|
|
const {result} = renderHook(() => useDriveTemperature(),
|
|
{wrapper: makeStatusWrapper({})});
|
|
expect(result.current.device).toBeNull();
|
|
expect(result.current.temperature).toBe(0);
|
|
expect(result.current.highTemperature).toBe(55);
|
|
expect(result.current.criticalTemperature).toBe(65);
|
|
});
|
|
|
|
test('returns no drive when none report a temperature', () => {
|
|
const status = {
|
|
smart_stats: {
|
|
drives: [{device: 'sda', temperature: null}],
|
|
high_temperature: 55,
|
|
critical_temperature: 65,
|
|
},
|
|
};
|
|
const {result} = renderHook(() => useDriveTemperature(),
|
|
{wrapper: makeStatusWrapper(status)});
|
|
expect(result.current.device).toBeNull();
|
|
expect(result.current.temperature).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('Paginator rendering', () => {
|
|
test('renders exactly totalPages numbered page links (no phantom trailing link)', () => {
|
|
// 48 results at 24 per page -> 2 pages. If totalPages is 3, semantic-ui
|
|
// will render an extra "3" link that fetches an empty page.
|
|
render(
|
|
<Paginator activePage={1} totalPages={2} onPageChange={() => {}}/>
|
|
);
|
|
|
|
// Semantic UI renders page numbers as <a> elements with the page text.
|
|
// Tablet + mobile variants both render here because Media is mocked to
|
|
// pass children through, so each numeric page appears at least once.
|
|
expect(screen.queryAllByText('1').length).toBeGreaterThan(0);
|
|
expect(screen.queryAllByText('2').length).toBeGreaterThan(0);
|
|
expect(screen.queryByText('3')).toBeNull();
|
|
});
|
|
});
|