mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-20 06:56:18 -05:00
The library has been uninstalled for some time, but the codebase still read as though it were there: identifiers named after it, rules written against its class names, and about 180 comments explaining a rule in terms of a thing that is no longer installed. Renamed, keeping the vocabulary the app actually uses: semanticUIColorMap -> navColorHexMap, semanticColorNames -> paletteColorNames, semanticNames -> iconNameAliases, semanticSizes -> sizeAliases, and SemanticUIColors -> NavColors in wrolpi/schema.py, which is what validates nav_color on the way in. ColorToSemanticHexColor had no callers at all and is gone. The baseline ratchet has done its job -- the list reached zero, so the JSON is deleted and the guard keeps only the checks with teeth: no package, no import, no `className="ui "`, no toast library. Its Theme.tsx check went with the wrappers it was watching for. It also asserts its own walk found files, so a clean result cannot mean it scanned nothing. Deleted from App.css: every rule requiring `.ui`, `.inverted`, `.segment` or `.modal`, none of which any component has set since the stylesheet stopped loading, plus the form skeletons, ui-alerts and progress-text rules that nothing renders. Two of them were doing harm rather than nothing: the drag tints had a dark-theme variant under `.inverted` that stopped applying, leaving 15% of a fixed blue over a dark row, and now mix a token instead. Two selectors naming markup that no longer exists were live bugs. The file browser's filter had `.ui.input.file-browser-filter`, so it rendered at the browser default width on a bar laid out to give it 34em -- now qualified by its container, because `.wrolpi-action-input` sets `width: 100%` at the same specificity and is loaded later. And SearchBox takes named props rather than a rest spread, so the `id` DestinationForm hands it was dropped in silence and the label it renders pointed at nothing; the download forms' Destination field has had no associated label since the migration. "Semantic roles" survives in four places, where it means what it says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
81 lines
3.6 KiB
JavaScript
81 lines
3.6 KiB
JavaScript
import fs from 'fs';
|
|
import path from 'path';
|
|
|
|
/*
|
|
* Semantic UI is gone, and this is what keeps it gone.
|
|
*
|
|
* It began as a ratchet: a JSON baseline listing the 75 files that still imported the
|
|
* library, which was only ever allowed to shrink. The list reached zero and the file has
|
|
* been deleted with it; what is left is the part that still has teeth.
|
|
*
|
|
* An import of a missing module fails loudly on its own, so that is not really what this
|
|
* guards. It guards the quiet ways the library comes back: reinstalling a package to
|
|
* "just use a Semantic component for this one thing", which drags a 300kB stylesheet into
|
|
* the bundle with it, or writing `className="ui stackable grid"` in the belief that those
|
|
* rules are still loaded, which they have not been since Phase 4 -- markup like that does
|
|
* not error, it simply has no effect, and the layout quietly comes out wrong.
|
|
*
|
|
* It is a test rather than an ESLint rule deliberately: `no-restricted-imports` would
|
|
* either print warnings on every dev rebuild or fail the build outright, and CI unsets CI=
|
|
* for its build step, so warnings there guard nothing.
|
|
*
|
|
* New UI code imports from `src/components/ui`.
|
|
*/
|
|
|
|
const SRC = __dirname;
|
|
const REPO = path.join(SRC, '..');
|
|
|
|
/** Every source file under src/, excluding tests. */
|
|
const sourceFiles = (dir = SRC) => fs.readdirSync(dir, {withFileTypes: true}).flatMap(entry => {
|
|
const full = path.join(dir, entry.name);
|
|
if (entry.isDirectory()) return sourceFiles(full);
|
|
if (!/\.(js|jsx|ts|tsx)$/.test(entry.name)) return [];
|
|
if (/\.(test|cy)\.(js|jsx|ts|tsx)$/.test(entry.name)) return [];
|
|
return [path.relative(REPO, full)];
|
|
});
|
|
|
|
const filesMatching = (pattern) => sourceFiles()
|
|
.filter(file => pattern.test(fs.readFileSync(path.join(REPO, file), 'utf8')))
|
|
.sort();
|
|
|
|
describe('Semantic UI stays removed', () => {
|
|
it('scans a source tree, so a clean result means something', () => {
|
|
// Every assertion below is "this list is empty". Without this one they would all
|
|
// pass just as well if the walk found no files at all.
|
|
expect(sourceFiles().length).toBeGreaterThan(100);
|
|
});
|
|
|
|
it('has no file importing Semantic UI', () => {
|
|
expect(filesMatching(/from ['"](semantic-ui-react|semantic-ui-react\/)/)).toEqual([]);
|
|
});
|
|
|
|
it('has nobody left calling the Semantic toast library', () => {
|
|
/*
|
|
* A toast raised through react-semantic-toasts-2 needs `<SemanticToastContainer/>`
|
|
* mounted, and that came out of App.js when App.js migrated. So this import fails
|
|
* in the way that is hardest to notice: no error, no warning, just a notification
|
|
* the user is never shown. Import `toast` from `src/components/ui` instead; it
|
|
* takes the same options.
|
|
*/
|
|
expect(filesMatching(/from ['"]react-semantic-toasts-2/)).toEqual([]);
|
|
});
|
|
|
|
it('has no file leaning on the Semantic stylesheet', () => {
|
|
/*
|
|
* `className="ui stackable grid"` and friends. semantic.min.css is not loaded, so
|
|
* a `ui ...` class name now styles nothing at all -- which is why this cannot be
|
|
* left to the import check: nothing about it fails, the element simply loses the
|
|
* layout its author expected.
|
|
*/
|
|
expect(filesMatching(/className=["']ui /)).toEqual([]);
|
|
});
|
|
|
|
it('has no Semantic package installed', () => {
|
|
const pkg = JSON.parse(fs.readFileSync(path.join(REPO, 'package.json'), 'utf8'));
|
|
const named = [...Object.keys(pkg.dependencies || {}),
|
|
...Object.keys(pkg.devDependencies || {})]
|
|
.filter(name => /semantic/i.test(name));
|
|
|
|
expect(named).toEqual([]);
|
|
});
|
|
});
|