mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
These five carried no `size` at all, so they rendered at Mantine's 440px default -- a width nobody had chosen, inherited from the library rather than decided. Roland audited them: FileBrowser rename small (440, unchanged) FileBrowser move large (620) FileBrowser ignore small (440, unchanged) FileBrowser make directory large (620) Files filter small (440, unchanged) The three "unchanged" ones are written down rather than left implicit, so the decision lives in the source and a future change to Mantine's default cannot move them. Roland asked for `medium` on the ignore dialog and there is no such modal size: the vocabulary is mini/tiny/small/large/fullscreen, and Mantine has no token between 440 and 620. An unknown name would have passed through untranslated, rendered at 440 anyway, and left the source claiming otherwise -- which is what the size guard in ui.test.js was added to catch. Asked rather than guessed; `small` was the answer, and the guard would have failed the build either way. Verified in the browser rather than from the props: move 620, make directory 620, ignore 440, rename 440. Move and ignore need a selection before they can be opened, so a directory was selected first. 1134 jest / 64 suites, clean npm run build. The full suite needs `--maxWorkers=2` on this machine at the moment: at load average 38 four unrelated suites (ControllerPage, CollectionReorganizeModal, CollectionTagModal, Flasher) time out and the run takes 183s instead of 5s. They pass in isolation and with reduced parallelism; nothing in this change touches them. |
||
|---|---|---|
| .. | ||
| api | ||
| components | ||
| contexts | ||
| hooks | ||
| themes | ||
| types | ||
| api.js | ||
| App.css | ||
| App.js | ||
| DashboardPage.js | ||
| DashboardPage.test.js | ||
| Events.js | ||
| import-cycles.test.js | ||
| index.css | ||
| index.js | ||
| logo.svg | ||
| reportWebVitals.js | ||
| semantic-baseline.json | ||
| semantic-baseline.test.js | ||
| setupTests.js | ||
| Tags.cy.js | ||
| Tags.js | ||
| Tags.test.js | ||
| test-fixtures.js | ||
| test-fixtures.test.js | ||
| test-utils.js | ||
| test-utils.test.js | ||