wrolpi/app/src/components/ui
Roland 450aaa7334
ui: map the twelve icon names that were rendering as question marks
The calculators page had seven "?" glyphs in a row -- `cogs`, `tint`, `food`,
`signal`, `thermometer`, `car`, `th large` -- and `arrow left` was unmapped
while `arrow down`, `right` and `up` were all there.  Also `tags`, `comments`,
`chevron down`, and `closed captioning outline`.

An unmapped name is not subtle: it renders IconHelpCircle and logs a console
error.  It shipped anyway, because nothing failed on it.

Three tests already guarded this and all three missed it.  They cover the
theme picker's choices, the names the mimetype helpers can return, and the
map's own integrity -- none of them looks at what call sites write.  The new
guard walks src/ and checks every name it finds, in each of the four
spellings, each of which was hiding at least one of these:

    <Icon name='x'/> and icon='x'    the plain JSX prop
    {icon: 'x'}                      a data table; how the calculators declare theirs
    icon={active ? 'tags' : 'tag'}   a ternary, where `tags` was unmapped
    name={s === 'descending' ? ...}  a comparison operand, which is NOT a name

The last one is why the extraction strips comparison operands first: the sort
arrow in DataTable tests a direction, and reading 'descending' as an icon name
would be a false positive that trains everyone to ignore this test.

Verified by planting each spelling in the file it was found in, and by
reverting the map additions -- the guard reports them.  Also swept thirteen
routes in a real browser with console.error hooked: no icon errors left.

Drops `taggedImageLabel`, a Semantic Label prop bag with no consumers, whose
`corner: 'left'` was never an icon name at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-08 18:05:45 -06:00
..
Button.tsx ui: three silent library defects the agents' reports surfaced 2026-08-08 18:04:02 -06:00
DataTable.tsx ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Feedback.tsx ui: tags look like tags, and stay readable in every theme 2026-08-08 18:05:44 -06:00
Icon.tsx ui: map the twelve icon names that were rendering as question marks 2026-08-08 18:05:45 -06:00
index.ts ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Inputs.tsx ui: name the directory fields, announce their help text, let long prefixes shrink 2026-08-08 18:04:04 -06:00
Navigation.tsx ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Overlays.tsx ui: migrate the extension pages and Configs; five components they needed 2026-08-08 18:04:00 -06:00
SearchBox.tsx ui: fix the cypress failures, and two real defects behind them 2026-08-08 18:04:01 -06:00
Surfaces.tsx ui: Statistic and StatisticGroup, and the four defects they had 2026-08-08 18:05:44 -06:00
ThemePicker.tsx ui: media filtering is a per-theme setting, not a night-mode hardcode 2026-08-08 18:04:00 -06:00
toast.test.js test: act on review — observe the wiring, and stop the soft assertions 2026-08-08 18:05:45 -06:00
toast.ts ui: restore the clickable toast the migration dropped 2026-08-08 18:05:45 -06:00
ui-layout.cy.js test: act on review — the skeleton guard was reading the wrong layer 2026-08-08 18:05:45 -06:00
ui.css test: act on review — the skeleton guard was reading the wrong layer 2026-08-08 18:05:45 -06:00
ui.test.js ui: map the twelve icon names that were rendering as question marks 2026-08-08 18:05:45 -06:00