4c71e84696
* ui: two upload dialogs that had drifted apart The dashboard and the file browser each had their own upload component: two dropzones, two overwrite toggles, two copies of the progress-bar rendering, against the same `useUploadFile` state. The file browser's dialog was made fullscreen with a drop target that grows; the dashboard's stayed a `large` dialog with a strip to drop onto, because it was a different file. They differ in one thing that is real: the file browser knows the destination because the user selected it, and the dashboard has to ask. That is now the `destination` prop -- `undefined` asks, a string uploads there, and '' is the media directory rather than a missing destination. Everything else is one component, so the next change to either entry point lands on both. * review: an upload dialog that looped on the media directory Pressing Upload in the file browser with nothing selected passes `''` -- the media directory. Three checks along that path read it as "no destination": * The clearing effect ran, and `doClear` is a new function every render whose own setState scheduled the next one. React ended it with "Maximum update depth exceeded", 16 warnings deep, on the default Upload path. The effect now clears only while asking, and `doClear` is stable. * The title read `Upload to: /media/wrolpi/`. * `doUpload` bailed, so a drop on the media root uploaded nothing. All three predate this branch; moving the dialog is what put them behind one component. Tests cover the title, what the hook is told, and that a fixed destination is never the thing that empties the queue. |
||
|---|---|---|
| .. | ||
| cypress | ||
| public | ||
| scripts | ||
| src | ||
| .gitignore | ||
| cypress.config.js | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| serve.json | ||
| tsconfig.json | ||
Getting Started with Create React App
This project was bootstrapped with Create React App.
Available Scripts
In the project directory, you can run:
npm start
Runs the app in the development mode.
Open http://localhost:3000 to view it in your browser.
The page will reload when you make changes.
You may also see any lint errors in the console.
npm test
Launches the test runner in the interactive watch mode.
See the section about running tests for more
information.
npm run build
Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.
The build is minified and the filenames include the hashes.
Your app is ready to be deployed!
See the section about deployment for more information.
npm run eject
Note: this is a one-way operation. Once you eject, you can't go back!
If you aren't satisfied with the build tool and configuration choices, you can eject at any time. This command will
remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right
into your project so you have full control over them. All of the commands except eject will still work, but they will
point to the copied scripts so you can tweak them. At this point you're on your own.
You don't have to ever use eject. The curated feature set is suitable for small and middle deployments, and you
shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't
customize it when you are ready for it.
Learn More
You can learn more in the Create React App documentation.
To learn React, check out the React documentation.
Code Splitting
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
Analyzing the Bundle Size
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
Making a Progressive Web App
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
Advanced Configuration
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
Deployment
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
npm run build fails to minify
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify