wrolpi/app/src
Roland 561c48e783
ui: Statistic and StatisticGroup, and the four defects they had
These three exports had no test of their own.  Statistic had already been
caught out once -- it relied on Semantic's `Statistic.Group` for its
spacing, so it broke silently when that was uninstalled -- and they are
on the Status, Dashboard, Apps, Docs, Videos, Archive and Channels pages.

Four defects, each with a test that goes red without the fix:

* StatisticGroup ruled between columns only, with a `border-right` on
  every cell but the last.  `auto-fit` wraps, so the seven statistics on
  the Docs page became four rows on a phone with no rule between them,
  and the cell ending each earlier row drew its border straight onto the
  group's outer one, making that edge 2px on the right and 1px on the
  left.  The hairlines are now a 1px grid gap filled by an outline on
  each cell, which rules both axes however the tracks fall.

  Ruling the gaps with a border-coloured background behind the grid --
  which is where this went first -- has the same reach but paints every
  track no cell landed in: an odd count left the last slot a solid grey
  block.  An outline is drawn only where a cell is.  Both of these are
  guarded, because the second was introduced while fixing the first.

* A statistic that renders nothing left a padded cell and a stray
  hairline mid-row.  FanRPMStatistic returns null on a device with no fan
  connector, which is most of them, so this was the Status page's normal
  appearance.  The group cannot render a child to find out, so the cell
  is still emitted and `:empty` takes it out of the grid -- which is why
  the cells carry no inline style for that rule to have to outrank.

* Statistic destructured five props and dropped the rest.  LoadStatistic
  and the four Status wrappers all end in `{...props}`, so anything
  passed through a wrapper vanished with no error anywhere.

* VideosStatistics passed `style={{margin: '2em'}}` to every statistic,
  Semantic-era spacing that the grid now provides.  It beat the group's
  own rule, being inline, and made that one page's statistics sit
  differently from the six others.

CardGroup was the only component in the library with no class of its own,
which left nothing to assert against -- `container.firstChild` in jsdom
is Mantine's injected <style> element.  It has one now, and takes
className/style/rest like its siblings.

The gallery grows a seventh statistic, so the group wraps at a normal
window width where the row hairlines can be seen, and a second group of
coloured readings as Status renders them.

Geometry, hairlines and per-theme token resolution are in ui-layout.cy.js
rather than jest: jsdom returns zeros from getBoundingClientRect and
never resolves a var(), so it cannot judge any of it.
2026-08-05 18:37:08 -06:00
..
api controller: VNC toggle, gated on the Desktop running 2026-07-29 18:10:05 -06:00
components ui: Statistic and StatisticGroup, and the four defects they had 2026-08-05 18:37:08 -06:00
contexts test: one place for fixtures, real providers instead of mocked context modules 2026-08-05 18:36:48 -06:00
hooks build: uninstall Semantic UI 2026-08-05 18:36:31 -06:00
themes ui: a browser layer for the library, and the .media reset that never applied 2026-08-05 18:36:34 -06:00
types ui: the last Semantic UI file, and the stylesheet with it 2026-08-05 18:36:26 -06:00
api.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-05 18:34:58 -06:00
App.css test: one place for fixtures, real providers instead of mocked context modules 2026-08-05 18:36:48 -06:00
App.js ui: the last Semantic UI file, and the stylesheet with it 2026-08-05 18:36:26 -06:00
DashboardPage.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-05 18:34:58 -06:00
DashboardPage.test.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-05 18:34:58 -06:00
Events.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-05 18:34:58 -06:00
index.css ui: the last Semantic UI file, and the stylesheet with it 2026-08-05 18:36:26 -06:00
index.js Fixing changes before merge. 2023-02-08 21:18:51 -07:00
logo.svg Renaming examples to avoid grouping of pdf with ebooks. Reworking URLs for media files to avoid escaping url safe characters. 2023-03-29 13:46:39 -06:00
reportWebVitals.js Renaming examples to avoid grouping of pdf with ebooks. Reworking URLs for media files to avoid escaping url safe characters. 2023-03-29 13:46:39 -06:00
semantic-baseline.json ui: the last Semantic UI file, and the stylesheet with it 2026-08-05 18:36:26 -06:00
semantic-baseline.test.js build: uninstall Semantic UI 2026-08-05 18:36:31 -06:00
setupTests.js ui: Common.js and thirteen more files off Semantic 2026-08-05 18:34:50 -06:00
Tags.cy.js Video downloads have many more options. Downloads are migrated. 2024-11-28 09:48:57 -07:00
Tags.js ui: thirty-five files off Semantic, leaving fifteen 2026-08-05 18:34:58 -06:00
test-fixtures.js test: check declared types, not just field names, and fix the three that were wrong 2026-08-05 18:37:01 -06:00
test-fixtures.test.js test: one place for fixtures, real providers instead of mocked context modules 2026-08-05 18:36:48 -06:00
test-utils.js test: the theme drives the colour scheme, and mockModule takes the module 2026-08-05 18:36:53 -06:00
test-utils.test.js test: the theme drives the colour scheme, and mockModule takes the module 2026-08-05 18:36:53 -06:00