wrolpi/app/src/components/ui
Roland 738fb51d77
review: the spread was overwriting the stack, and the guard was blind
Acting on the review of #622.  Two bugs, both real, and the second one is a
test of mine that could not fail for its stated reason.

The stack props were set BEFORE `{...props}`, so any call site passing
`closeOnEscape` overwrote the stack's decision and re-armed Mantine's
window-level Escape listener on a modal that is not on top -- reinstating the
bug the change exists to fix.  Three call sites pass it: CollectionReorganizeModal
and BatchReorganizeModal disable Escape while a reorganize runs, Flasher while
it writes an image.  The concrete breakage is the one place the app really does
stack two modals: ConflictResolutionModal opens as a sibling above the
reorganize modal, so the moment the reorganize finished and `closeOnEscape`
returned to true, one Escape closed both.  They are now destructured out and
composed -- `isTop && closeOnEscape` -- because "only the top modal answers
Escape" and "do not dismiss me while I am busy" are both true.  Mantine's own
Modal.Stack applies its stack props after the caller's for the same reason.
Two Cypress cases, one per direction; planting the old order reddens the first.

`Confirm` was still passing Mantine's raw `sm`, and the audit guard I added in
the same PR was supposed to catch exactly that.  It did not, and the reason is
worse than the miss: the scanner matched `<Modal\b[^>]*?\bsize='...'`, and
`onClose={() => ...}` contains a `>`, so it stopped at the arrow and never saw
the rest of the tag.  It read 44 of the 56 modals that declare a size; the
twelve it skipped included the single offender in the codebase, in this very
file.  A guard that scans a fifth of nothing looks identical to a clean
codebase.  It now walks the tag with a paren counter, accepts either quote
style, and asserts it scanned more than fifty tags first -- so a scanner that
silently matches nothing fails instead of passing.  Confirm says `tiny`.

Also from the review: a bare `expect(titles()).to.not.include('Parent')` in the
Cypress spec ran during the synchronous phase, before any cy command executed
and while nothing was open, so it always passed and guarded nothing.  Deleted
rather than repaired -- the retried assertion above it already makes the claim.

An unregistered-but-open modal reported `isTop` even with a parent registered,
which gave both the same z-index for the frame before the effect ran -- a visible
flash of the wrong modal in front.  It is only top now if the stack is empty.

Nit: the comment claimed Mantine ignores unknown size names.  It ignores unknown
SEMANTIC names and falls back to 440px; it recognises and honours its own.  Two
different hazards, both silent, and the comment now says which is which.

1124 jest / 62 suites, 10 in modal-stack.cy.js, 196 in ui-layout.cy.js,
clean npm run build.
2026-08-08 18:05:49 -06:00
..
Button.tsx ui: an icon button is the same height as the button beside it 2026-08-08 18:05:47 -06:00
DataTable.tsx ui: give tables a real header, drop the column grid, quiet the row rules 2026-08-08 18:05:45 -06:00
Feedback.tsx ui: semantic roles, so night and amber can tell severity apart at all 2026-08-08 18:05:46 -06:00
Icon.tsx ui: map the twelve icon names that were rendering as question marks 2026-08-08 18:05:45 -06:00
index.ts ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Inputs.tsx fix: break the import cycle that put useCalculators in the TDZ 2026-08-08 18:05:47 -06:00
modal-stack.cy.js review: the spread was overwriting the stack, and the guard was blind 2026-08-08 18:05:49 -06:00
Navigation.tsx ui: nine leaf files off Semantic, and the components they needed 2026-08-08 18:04:00 -06:00
Overlays.tsx review: the spread was overwriting the stack, and the guard was blind 2026-08-08 18:05:49 -06:00
SearchBox.tsx ui: fix the cypress failures, and two real defects behind them 2026-08-08 18:04:01 -06:00
Surfaces.tsx ui: cards get legible titles, contained posters, and meta beside the title 2026-08-08 18:05:47 -06:00
ThemePicker.tsx ui: media filtering is a per-theme setting, not a night-mode hardcode 2026-08-08 18:04:00 -06:00
toast.test.js ui: semantic roles, so night and amber can tell severity apart at all 2026-08-08 18:05:46 -06:00
toast.ts ui: semantic roles, so night and amber can tell severity apart at all 2026-08-08 18:05:46 -06:00
ui-layout.cy.js review: measure what can be measured, and say what is not 2026-08-08 18:05:49 -06:00
ui.css ui: the corner triggers, the More button, and the search modal 2026-08-08 18:05:49 -06:00
ui.test.js review: the spread was overwriting the stack, and the guard was blind 2026-08-08 18:05:49 -06:00