mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-10-26 19:01:39 -04:00
Phase 2, part 3. Baseline 63 -> 50.
Common.js is the one that mattered: 51 files import it, so its Semantic usage
was propping up the rest of the migration. Everything in it now comes from the
library -- Paginator, the two search inputs, DirectorySearch, TabLinks, the
toggles, the messages, APIButton, Breadcrumbs, SimpleAccordion, IframeViewer,
CardPoster, FileIcon, LoadStatistic, the theme menu, and the hotspot icons.
Also migrated: Placeholder, Apps, ArchivePreview, CbzViewer, AddToPlaylist,
TaggedDeleteConfirmModal, the collection edit/tag forms, and four inventory
components.
New in the library, all in the gallery and tested:
SearchBox Semantic's `<Search category>` with its grouped results shape
kept, because four call sites already build it. A real
combobox rather than a div that listens for clicks.
Pagination Semantic's prop names; onPageChange gets the page number.
TabBar the strip only -- routing stays with the caller.
IconStack Semantic's IconGroup, named once for assistive technology.
Table.HeaderCell sorted/onSort -- a real button carrying aria-sort.
Button/IconButton translate Semantic's size names.
That last one is defensive: unmigrated callers still pass size='tiny', and
Mantine drops a size it does not recognise without a word, so the button
quietly renders at the wrong size. Mapping here keeps the mixed state honest.
Three real bugs found and fixed on the way, none of them cosmetic:
* `fileSuffixIconName` returned fourteen icon names the map did not have, so
opening a folder with a PDF, a Word document or an archive in it logged an
error and drew a fallback glyph. All fourteen mapped, with a test that
walks the mapper's own return values, and another asserting every mapped
name resolves to a Tabler component that exists.
* `Statistic` relied on Semantic's `Statistic.Group` for its spacing, so on
the dashboard the load averages ran together into "1 MIN. LOAD5 MIN.
LOAD15 MIN. LOAD". It carries its own spacing now.
* Semantic's inverted stylesheet colors every descendant of an inverted
segment, so Toggle labels inherited #dddddd -- white pixels in night mode,
on the Settings page, which is exactly where someone adjusts their WROLPi
in the dark. Restated from tokens.
The baseline ratchet gained a third assertion: a migrated file may still lean
on Semantic's CSS classes without importing the library, which the import check
cannot see and which would collapse silently when Phase 4 deletes the
stylesheet. There is one such bridge today and it is now declared.
40 lines
2 KiB
JavaScript
40 lines
2 KiB
JavaScript
import React from "react";
|
|
import {fireEvent, screen} from "@testing-library/react";
|
|
import {renderWithProviders} from "../../test-utils";
|
|
import {InventorySummary} from "./InventorySummary";
|
|
|
|
// Group by the first text field (category); two groups with different item counts and size totals.
|
|
const FIELDS = [
|
|
{key: 'category', label: 'Category', type: 'text', order: 0},
|
|
{key: 'item_size', label: 'Size', type: 'quantity', unit: 'lb', order: 1},
|
|
{key: 'count', label: 'Count', type: 'number', order: 2},
|
|
];
|
|
const ITEMS = [
|
|
{id: 1, category: 'grains', item_size: '10', item_size_unit: 'lb', count: '2'}, // 20 lb
|
|
{id: 2, category: 'grains', item_size: '5', item_size_unit: 'lb', count: '2'}, // 10 lb -> grains: 2 items, 30 lb
|
|
{id: 3, category: 'beans', item_size: '25', item_size_unit: 'lb', count: '4'}, // beans: 1 item, 100 lb
|
|
];
|
|
|
|
const groupOrder = () =>
|
|
[...document.querySelectorAll('tbody tr')].map(tr => tr.querySelector('td:first-child').textContent);
|
|
|
|
describe('InventorySummary sortable columns', () => {
|
|
test('defaults to group name ascending', () => {
|
|
renderWithProviders(<InventorySummary fields={FIELDS} items={ITEMS}/>);
|
|
expect(groupOrder()).toEqual(['beans', 'grains']);
|
|
});
|
|
|
|
test('sorting by Items uses the numeric count', () => {
|
|
renderWithProviders(<InventorySummary fields={FIELDS} items={ITEMS}/>);
|
|
fireEvent.click(screen.getByText('Items')); // first click -> descending
|
|
expect(groupOrder()).toEqual(['grains', 'beans']); // grains has 2 items, beans 1
|
|
fireEvent.click(screen.getByText('Items')); // toggle -> ascending
|
|
expect(groupOrder()).toEqual(['beans', 'grains']);
|
|
});
|
|
|
|
test('sorting by Total uses the summed magnitude, not the formatted string', () => {
|
|
renderWithProviders(<InventorySummary fields={FIELDS} items={ITEMS}/>);
|
|
fireEvent.click(screen.getByText('Total')); // descending
|
|
expect(groupOrder()).toEqual(['beans', 'grains']); // beans 100 lb > grains 30 lb
|
|
});
|
|
});
|