mirror of
https://github.com/lrnselfreliance/wrolpi.git
synced 2026-11-21 15:36:18 -05:00
Addresses the automated review on #583; all three were real. The night filter only applied to elements tagged `.media`, and nothing in the app carried that class - so selecting Night filtered the interface but left every video, thumbnail, PDF and map full-colour, which is precisely the thing the mode exists to prevent. The Settings copy promised otherwise, so it was also wrong. It now targets the element types instead of an opt-in class, because night mode has to fail safe: a library of thousands of files reaches the screen through many components, and one that forgot to opt in would undo half an hour of dark adaptation. `.media` still works for wrappers that must be filtered as a unit, and `.night-unfiltered` opts out. The filter is restated on `:fullscreen`, which a filter on an ancestor stops reaching. Verified on the videos page: all 25 media elements filtered. Three of the five theme choices rendered a fallback glyph and logged errors, because the icon map was built by grepping literal name='...' strings and the navigation picker passes its icon through a variable. Adds sun, moon and lightbulb, plus a test asserting every theme choice resolves to a real icon. The pre-paint script wrapped the `matchMedia` fallback in the same try as the storage read, so a device with storage blocked painted light even when it prefers dark - recreating the flash the script exists to prevent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
180 lines
5.9 KiB
TypeScript
180 lines
5.9 KiB
TypeScript
import React from 'react';
|
|
import * as Tabler from '@tabler/icons-react';
|
|
|
|
/*
|
|
* Icons.
|
|
*
|
|
* Semantic UI shipped an icon font; we use Tabler's bundled SVG components, which
|
|
* are tree-shaken at build time and need nothing from the network.
|
|
*
|
|
* Icons never name a color. They stroke with `currentColor`, inheriting from the
|
|
* button or text that wraps them, so status color and every theme come for free.
|
|
*/
|
|
|
|
/** 16px inline (default), 20px emphasis, 24px page-level. */
|
|
export type IconSize = 'small' | 'medium' | 'large';
|
|
|
|
const sizes: Record<IconSize, number> = {small: 16, medium: 20, large: 24};
|
|
|
|
/**
|
|
* Semantic icon name -> Tabler component name.
|
|
*
|
|
* Covers every name the app renders today so call sites can migrate without also
|
|
* choosing new icons. New code should import the Tabler component directly and
|
|
* pass it as `component`; this map exists for the migration, not forever.
|
|
*/
|
|
const semanticNames: Record<string, keyof typeof Tabler> = {
|
|
'add': 'IconPlus',
|
|
'archive': 'IconArchive',
|
|
'arrow alternate circle up': 'IconCircleArrowUp',
|
|
'arrow down': 'IconArrowDown',
|
|
'arrow right': 'IconArrowRight',
|
|
'arrow up': 'IconArrowUp',
|
|
'balance scale': 'IconScale',
|
|
'book': 'IconBook',
|
|
'bug': 'IconBug',
|
|
'calculator': 'IconCalculator',
|
|
'calendar': 'IconCalendar',
|
|
'charset': 'IconLanguage',
|
|
'check': 'IconCheck',
|
|
'check circle': 'IconCircleCheck',
|
|
'checkmark': 'IconCheck',
|
|
'chevron left': 'IconChevronLeft',
|
|
'chevron right': 'IconChevronRight',
|
|
'chrome': 'IconBrandChrome',
|
|
'circle': 'IconCircle',
|
|
'circle notch': 'IconLoader2',
|
|
'circle notched': 'IconLoader2',
|
|
'close': 'IconX',
|
|
'columns': 'IconColumns',
|
|
'copy': 'IconCopy',
|
|
'cube': 'IconCube',
|
|
'directory': 'IconFolder',
|
|
'disk': 'IconDatabase',
|
|
'download': 'IconDownload',
|
|
'dropdown': 'IconChevronDown',
|
|
'edit': 'IconEdit',
|
|
'exclamation': 'IconExclamationMark',
|
|
'exclamation triangle': 'IconAlertTriangle',
|
|
'expand arrows alternate': 'IconArrowsMaximize',
|
|
'external': 'IconExternalLink',
|
|
'eye': 'IconEye',
|
|
'eye slash': 'IconEyeOff',
|
|
'file': 'IconFile',
|
|
'file alternate': 'IconFileDescription',
|
|
'file alternate outline': 'IconFileDescription',
|
|
'file code': 'IconFileCode',
|
|
'file pdf outline': 'IconFileTypePdf',
|
|
'file text': 'IconFileText',
|
|
'file video': 'IconFileSmile',
|
|
'film': 'IconMovie',
|
|
'filter': 'IconFilter',
|
|
'firefox': 'IconBrandFirefox',
|
|
'folder': 'IconFolder',
|
|
'folder open': 'IconFolderOpen',
|
|
'folder open outline': 'IconFolderOpen',
|
|
'folder outline': 'IconFolder',
|
|
'globe': 'IconWorld',
|
|
'hand point right': 'IconHandFinger',
|
|
'hdd': 'IconDeviceSdCard',
|
|
'heart': 'IconHeart',
|
|
'heartbeat': 'IconHeartRateMonitor',
|
|
'history': 'IconHistory',
|
|
'image': 'IconPhoto',
|
|
'lightbulb': 'IconBulb',
|
|
'lightbulb outline': 'IconBulb',
|
|
'lightning': 'IconBolt',
|
|
'moon': 'IconMoon',
|
|
'moon outline': 'IconMoon',
|
|
'linkify': 'IconLink',
|
|
'list': 'IconList',
|
|
'lock': 'IconLock',
|
|
'map outline': 'IconMap',
|
|
'microchip': 'IconCpu',
|
|
'minus': 'IconMinus',
|
|
'play': 'IconPlayerPlay',
|
|
'plug': 'IconPlug',
|
|
'plus': 'IconPlus',
|
|
'print': 'IconPrinter',
|
|
'puzzle piece': 'IconPuzzle',
|
|
'qrcode': 'IconQrcode',
|
|
'question': 'IconHelp',
|
|
'redo': 'IconArrowForwardUp',
|
|
'refresh': 'IconRefresh',
|
|
'rss': 'IconRss',
|
|
'save': 'IconDeviceFloppy',
|
|
'search': 'IconSearch',
|
|
'server': 'IconServer',
|
|
'settings': 'IconSettings',
|
|
'share': 'IconShare',
|
|
'shield': 'IconShield',
|
|
'spinner': 'IconLoader2',
|
|
'star': 'IconStarFilled',
|
|
'star outline': 'IconStar',
|
|
'stop': 'IconPlayerStop',
|
|
'sun': 'IconSun',
|
|
'sun outline': 'IconSun',
|
|
'sync': 'IconRefresh',
|
|
'tachometer alternate': 'IconGauge',
|
|
'tag': 'IconTag',
|
|
'terminal': 'IconTerminal2',
|
|
'th': 'IconLayoutGrid',
|
|
'thumbs up': 'IconThumbUp',
|
|
'trash': 'IconTrash',
|
|
'undo': 'IconArrowBackUp',
|
|
'unlock': 'IconLockOpen',
|
|
'upload': 'IconUpload',
|
|
'usb': 'IconUsb',
|
|
'volume up': 'IconVolume',
|
|
'warning': 'IconAlertTriangle',
|
|
'warning circle': 'IconAlertCircle',
|
|
'warning sign': 'IconAlertTriangle',
|
|
'wifi': 'IconWifi',
|
|
'wrench': 'IconTool',
|
|
'x': 'IconX',
|
|
};
|
|
|
|
export interface IconProps extends Omit<React.SVGProps<SVGSVGElement>, 'name' | 'ref'> {
|
|
/** A Semantic UI icon name, for migrated call sites. */
|
|
name?: string;
|
|
/** A Tabler component, for new code. */
|
|
component?: React.ComponentType<any>;
|
|
size?: IconSize | number;
|
|
/** Rotate continuously; for spinners and in-progress states. */
|
|
loading?: boolean;
|
|
/** Accessible name. Omit for decorative icons, which are hidden instead. */
|
|
label?: string;
|
|
}
|
|
|
|
/** Resolve a Semantic icon name to its Tabler component, or undefined if unmapped. */
|
|
export const resolveIconName = (name: string): React.ComponentType<any> | undefined => {
|
|
const taberName = semanticNames[name.trim().toLowerCase()];
|
|
return taberName ? (Tabler[taberName] as React.ComponentType<any>) : undefined;
|
|
}
|
|
|
|
export function Icon({name, component, size = 'small', loading, label, ...props}: IconProps) {
|
|
let Component = component;
|
|
if (!Component && name) {
|
|
Component = resolveIconName(name);
|
|
if (!Component) {
|
|
// Loud on purpose: a silently missing icon leaves a hole in the interface.
|
|
console.error(`No icon for Semantic name "${name}"; pass a Tabler component instead.`);
|
|
Component = Tabler.IconHelpCircle;
|
|
}
|
|
}
|
|
if (!Component) {
|
|
console.error('Icon requires `name` or `component`.');
|
|
return null;
|
|
}
|
|
|
|
const pixels = typeof size === 'number' ? size : sizes[size];
|
|
return <Component
|
|
size={pixels}
|
|
stroke={2}
|
|
className={loading ? 'wrolpi-icon-spin' : undefined}
|
|
aria-hidden={label ? undefined : 'true'}
|
|
aria-label={label}
|
|
role={label ? 'img' : undefined}
|
|
{...props}
|
|
/>
|
|
}
|