a65c55e463
Acting on the review of #628. No bugs; one suggestion and one nit, and the suggestion is answered with a measurement rather than a change. The review asked whether MakeDirectoryModal should drop back to `small`, on the grounds that its body -- a path, one field and a button -- is the same shape as RenameModal's, which is `small`. The shapes are the same; the content is not. Rename shows a RELATIVE path, make-directory shows the absolute one including the media directory, and a bare `<pre>` is `white-space: pre`, so it scrolls out of sight rather than wrapping. Measured in the browser at both widths: 440px holds 42 characters, 620px holds 61. `/media/wrolpi/videos/Practical Engineering/Season 2024/` is 55. So an ordinary channel-and-season path is unreadable at 440 and fits at 620, which is exactly the condition the review set for keeping it. The dev tree hides this -- its paths are around 22 characters and fit either way. Both `large` call sites now carry the audit comment the other three had, which was the nit. Make-directory's records the measurement, because it does read like an inconsistency beside rename and the next person to notice should see the numbers before narrowing it back. 1134 jest / 64 suites (--maxWorkers=2; see the previous commit), clean build. |
||
|---|---|---|
| .. | ||
| cypress | ||
| public | ||
| scripts | ||
| src | ||
| .gitignore | ||
| cypress.config.js | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| serve.json | ||
| tsconfig.json | ||
Getting Started with Create React App
This project was bootstrapped with Create React App.
Available Scripts
In the project directory, you can run:
npm start
Runs the app in the development mode.
Open http://localhost:3000 to view it in your browser.
The page will reload when you make changes.
You may also see any lint errors in the console.
npm test
Launches the test runner in the interactive watch mode.
See the section about running tests for more
information.
npm run build
Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.
The build is minified and the filenames include the hashes.
Your app is ready to be deployed!
See the section about deployment for more information.
npm run eject
Note: this is a one-way operation. Once you eject, you can't go back!
If you aren't satisfied with the build tool and configuration choices, you can eject at any time. This command will
remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right
into your project so you have full control over them. All of the commands except eject will still work, but they will
point to the copied scripts so you can tweak them. At this point you're on your own.
You don't have to ever use eject. The curated feature set is suitable for small and middle deployments, and you
shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't
customize it when you are ready for it.
Learn More
You can learn more in the Create React App documentation.
To learn React, check out the React documentation.
Code Splitting
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
Analyzing the Bundle Size
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
Making a Progressive Web App
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
Advanced Configuration
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
Deployment
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
npm run build fails to minify
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify