wrolpi/modules/zim/test
Roland 70ab0fcd5d
Tests fail when a request writes outside request.ctx.db.write()
A request's transaction begins deferred.  A write in it after a read fails
instantly ("database is locked") when another connection wrote in between,
and a write left for the response middleware's commit can be lost after the
response was sent.  #846-#853 and #863 moved handlers' writes into
request.ctx.db.write(); this keeps it that way.

Under pytest, a listener records every INSERT/UPDATE/DELETE/REPLACE made
while a request runs (or in a task it started) outside RequestDB.write()
or get_db_session(commit=True), and the autouse no_deferred_request_writes
fixture fails the test.  allow_deferred_request_writes opts a test out.
The test-only response listener now runs switches outside the request,
as production's perpetual process does.

It found three more:
- DELETE /api/zim/<ids> deleted the .zim file, returned 204, then lost the
  row's delete when the middleware's commit failed under contention.  It
  now writes in request.ctx.db.write().
- Viewing a file recorded the view in a background task on the request's
  Session, after the request ended.  set_file_viewed opens its own write.
- tags.import_config (startup and config import) read, then wrote, in a
  deferred get_db_session().  It now begins as a writer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 14:51:55 -06:00
..
__init__.py Zim/Kiwix (Wikipedia) feature 2023-07-10 21:30:40 -06:00
test_api.py Tests fail when a request writes outside request.ctx.db.write() 2026-10-23 14:51:55 -06:00
test_lib.py Rename skip_circleci to skip_ci (#797) 2026-10-08 17:28:13 -06:00
test_read_config_value.py zim: address PR review — config race, YAML null, path traversal, pinned build 2026-07-20 19:10:09 -06:00
test_restart_kiwix.py Reset file worker status when a synchronous refresh is cancelled (#775) 2026-10-04 11:25:25 -06:00
test_start_kiwix_serve.py zim: address PR review — config race, YAML null, path traversal, pinned build 2026-07-20 19:10:09 -06:00
test_zim_downloaders.py Migrating Kiwix downloaders. 2026-05-07 15:54:53 -06:00
test_zim_modeler_loop.py files: shared modeler batch loop for video, doc, zim, archive (#722) 2026-09-24 16:47:46 -06:00