wrolpi/app
Roland ac6f69d19a
review: one figure for the point's room, and name the row-vs-chip contract
Two review notes, no bugs.

The geometry numbers disagreed with each other: I fixed one of the two
"17.3px" mentions and left the other, and the figures were rendered px
while ui.css states the same margin in design px, so three comments told
three stories about one value.  All of them now say 18.7px rendered and
cross-reference the 1.0625rem in the stylesheet, with the unit stated.

TagsLinkGroup peels `style` for the row and forwards the rest to each chip,
which is right for `onClick` but is exactly the shape of the bug just
fixed -- `className`, a Mantine Group prop, or a `data-*` meant for the row
would all still land on every tag.  `className` now goes with `style`,
since it is unambiguously a row concern and the likeliest next one, and the
split is documented next to the component.  Not inverted to an explicit
chipProps: that reshapes a working API with one call site.

The contract is tested rather than only described, both halves in one test,
because they are one destructure apart and the `style` half was wrong for
as long as it existed.  Verified by planting the regression: routing
className back to the chips fails it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 18:41:16 -06:00
..
cypress review: close the mixed-unit gaps the scale left behind 2026-08-05 18:41:01 -06:00
public ui: media filtering is a per-theme setting, not a night-mode hardcode 2026-08-05 18:34:47 -06:00
scripts Changing favicon color when navbar color changes. 2026-02-04 12:28:55 -07:00
src review: one figure for the point's room, and name the row-vs-chip contract 2026-08-05 18:41:16 -06:00
.gitignore A new start 2021-11-01 16:43:09 -06:00
cypress.config.js Skipping Caddy tests on CICD. 2026-03-10 20:30:46 -06:00
package-lock.json build: uninstall Semantic UI 2026-08-05 18:36:31 -06:00
package.json build: uninstall Semantic UI 2026-08-05 18:36:31 -06:00
README.md Fixing bug where file search would issue twice on load. 2023-04-09 14:34:33 -06:00
serve.json Adding serve.json so epub.html is not rewritten by serve. Buildling app during pi-gen/debian image builds. 2025-03-13 19:34:28 -06:00
tsconfig.json Converting Theme.js to typescript so we can use shorthands like Card.Icon. 2025-12-07 12:41:10 -07:00

Getting Started with Create React App

This project was bootstrapped with Create React App.

Available Scripts

In the project directory, you can run:

npm start

Runs the app in the development mode.
Open http://localhost:3000 to view it in your browser.

The page will reload when you make changes.
You may also see any lint errors in the console.

npm test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

npm run build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

npm run eject

Note: this is a one-way operation. Once you eject, you can't go back!

If you aren't satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.

You don't have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.

Code Splitting

This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting

Analyzing the Bundle Size

This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size

Making a Progressive Web App

This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app

Advanced Configuration

This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration

Deployment

This section has moved here: https://facebook.github.io/create-react-app/docs/deployment

npm run build fails to minify

This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify