wrolpi/app/src/components/ui
Roland ac7012c51d
test: act on review — observe the wiring, and stop the soft assertions
All five points were right.

* The gallery's Toasts copy still read "Bottom right" after the container
  moved.  Anyone using that page as a visual checklist would have looked in
  the wrong corner and concluded the change had not landed.

* Nothing observed ThemeProvider's own wiring.  Both suites mount their own
  `<Notifications position='top-right' limit={5}/>`, so moving the container
  back, or dropping it, would have failed neither -- while the comments
  claimed "container missing while call sites still fire" as the failure
  already shipped once.  Three tests in ThemeProvider.test.js now raise a
  real toast through the provider and assert it appears, and where.

  Asserted through a toast rather than by querying for a container: Mantine
  renders an empty container for every position it supports, so the obvious
  selector returns `top-center` no matter how the provider is configured.
  That is what the first version of this test did, and it failed for that
  reason rather than the intended one.

  The five-at-once test is honest about what it covers: Mantine's own
  default limit is also 5, so it does not prove the prop is there.  It
  catches the limit being raised.

* The default duration was untested.  Sleeping 150ms and finding the toast
  still up rules out "vanishes next tick" and nothing else -- it passes for
  a 200ms default, for `false`, and for Mantine's own 4000ms.  Read the
  deadline back off Mantine's store instead: 5000 when unset, the caller's
  number when given, `false` for 0.

* Space activates a followable toast in `toast.ts` and only Enter was
  covered, so dropping that branch stayed green.

* Colour assertions used `toContain('red')`, which any declaration
  containing those three letters satisfies.  They match the whole custom
  property now.

Planted four regressions to check the new tests: position, limit, the
5000ms default, and the Space branch.  Three went red; the limit one did
not, for the reason recorded above.
2026-08-05 18:37:22 -06:00
..
Button.tsx ui: three silent library defects the agents' reports surfaced 2026-08-05 18:35:43 -06:00
DataTable.tsx ui: nine leaf files off Semantic, and the components they needed 2026-08-05 18:34:49 -06:00
Feedback.tsx ui: tags look like tags, and stay readable in every theme 2026-08-05 18:37:13 -06:00
Icon.tsx ui: Common.js and thirteen more files off Semantic 2026-08-05 18:34:50 -06:00
index.ts ui: nine leaf files off Semantic, and the components they needed 2026-08-05 18:34:49 -06:00
Inputs.tsx ui: name the directory fields, announce their help text, let long prefixes shrink 2026-08-05 18:36:43 -06:00
Navigation.tsx ui: nine leaf files off Semantic, and the components they needed 2026-08-05 18:34:49 -06:00
Overlays.tsx ui: migrate the extension pages and Configs; five components they needed 2026-08-05 18:34:46 -06:00
SearchBox.tsx ui: fix the cypress failures, and two real defects behind them 2026-08-05 18:35:07 -06:00
Surfaces.tsx ui: Statistic and StatisticGroup, and the four defects they had 2026-08-05 18:37:08 -06:00
ThemePicker.tsx ui: media filtering is a per-theme setting, not a night-mode hardcode 2026-08-05 18:34:47 -06:00
toast.test.js test: act on review — observe the wiring, and stop the soft assertions 2026-08-05 18:37:22 -06:00
toast.ts ui: restore the clickable toast the migration dropped 2026-08-05 18:37:20 -06:00
ui-layout.cy.js test: prove the toast contrast fix in a browser, and fix the harness that hid it 2026-08-05 18:37:22 -06:00
ui.css ui: toasts move to the top right, get readable titles, and get tests 2026-08-05 18:37:19 -06:00
ui.test.js ui: two more labels were painting text with an inline colour, and shorthand hex 2026-08-05 18:37:18 -06:00